Update tests and fixes

Small fixes

Author: lkdvos

ext/TensorKitChainRulesCoreExt/factorizations.jl

@@ -5,7 +5,7 @@ function ChainRulesCore.rrule(::typeof(TensorKit.tsvd!), t::AbstractTensorMap;
                               kwargs...)
     # TODO: I think we can use tsvd! here without issues because we don't actually require
     # the data of `t` anymore.
-    USVᴴ = tsvd(t; trunc=TensorKit.notrunc(), alg)
+    USVᴴ = tsvd(t; trunc=TensorKit.notrunc(), kwargs...)
 
     if trunc != TensorKit.notrunc() && !isempty(blocksectors(t))
         USVᴴ′ = MatrixAlgebraKit.truncate!(svd_trunc!, USVᴴ, trunc)
@@ -16,7 +16,7 @@ function ChainRulesCore.rrule(::typeof(TensorKit.tsvd!), t::AbstractTensorMap;
     function tsvd!_pullback(ΔUSVᴴ′)
         ΔUSVᴴ = unthunk.(ΔUSVᴴ′)
         Δt = similar(t)
-        foreachblock(Δt) do (c, b)
+        foreachblock(Δt) do c, (b,)
             USVᴴc = block.(USVᴴ, Ref(c))
             ΔUSVᴴc = block.(ΔUSVᴴ, Ref(c))
             svd_compact_pullback!(b, USVᴴc, ΔUSVᴴc)
@@ -49,7 +49,7 @@ function ChainRulesCore.rrule(::typeof(TensorKit.eig!), t::AbstractTensorMap; kw
     function eig!_pullback(ΔDV′)
         ΔDV = unthunk.(ΔDV′)
         Δt = similar(t)
-        foreachblock(Δt) do (c, b)
+        foreachblock(Δt) do c, (b,)
             DVc = block.(DV, Ref(c))
             ΔDVc = block.(ΔDV, Ref(c))
             eig_full_pullback!(b, DVc, ΔDVc)
@@ -68,7 +68,7 @@ function ChainRulesCore.rrule(::typeof(TensorKit.eigh!), t::AbstractTensorMap; k
     function eigh!_pullback(ΔDV′)
         ΔDV = unthunk.(ΔDV′)
         Δt = similar(t)
-        foreachblock(Δt) do (c, b)
+        foreachblock(Δt) do c, (b,)
             DVc = block.(DV, Ref(c))
             ΔDVc = block.(ΔDV, Ref(c))
             eigh_full_pullback!(b, DVc, ΔDVc)

src/tensors/factorizations/factorizations.jl

@@ -45,7 +45,6 @@ include("matrixalgebrakit.jl")
 include("truncation.jl")
 include("deprecations.jl")
 
-
 function isisometry(t::AbstractTensorMap, (p₁, p₂)::Index2Tuple)
     t = permute(t, (p₁, p₂); copy=false)
     return isisometry(t)

test/ad.jl

@@ -398,7 +398,7 @@ Vlist = ((ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'),
             test_rrule(eigh′, H; atol, output_tangent=(ΔD, ΔU))
         end
 
-        let (U, S, V, ϵ) = tsvd(A)
+        let (U, S, V) = tsvd(A)
             ΔU = randn(scalartype(U), space(U))
             ΔS = randn(scalartype(S), space(S))
             ΔV = randn(scalartype(V), space(V))
@@ -408,54 +408,54 @@ Vlist = ((ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'),
                     mul!(block(ΔU, c), block(U, c), Diagonal(imag(diag(b))), -im, 1)
                 end
             end
-            test_rrule(tsvd, A; atol, output_tangent=(ΔU, ΔS, ΔV, 0.0))
+            test_rrule(tsvd, A; atol, output_tangent=(ΔU, ΔS, ΔV))
 
             allS = mapreduce(x -> diag(x[2]), vcat, blocks(S))
             truncval = (maximum(allS) + minimum(allS)) / 2
-            U, S, V, ϵ = tsvd(A; trunc=truncerr(truncval))
+            U, S, V = tsvd(A; trunc=truncerr(truncval))
             ΔU = randn(scalartype(U), space(U))
             ΔS = randn(scalartype(S), space(S))
             ΔV = randn(scalartype(V), space(V))
             T <: Complex && remove_svdgauge_depence!(ΔU, ΔV, U, S, V)
-            test_rrule(tsvd, A; atol, output_tangent=(ΔU, ΔS, ΔV, 0.0),
+            test_rrule(tsvd, A; atol, output_tangent=(ΔU, ΔS, ΔV),
                        fkwargs=(; trunc=truncerr(truncval)))
         end
 
-        let (U, S, V, ϵ) = tsvd(B)
+        let (U, S, V) = tsvd(B)
             ΔU = randn(scalartype(U), space(U))
             ΔS = randn(scalartype(S), space(S))
             ΔV = randn(scalartype(V), space(V))
             T <: Complex && remove_svdgauge_depence!(ΔU, ΔV, U, S, V)
-            test_rrule(tsvd, B; atol, output_tangent=(ΔU, ΔS, ΔV, 0.0))
+            test_rrule(tsvd, B; atol, output_tangent=(ΔU, ΔS, ΔV))
 
             Vtrunc = spacetype(S)(TensorKit.SectorDict(c => ceil(Int, size(b, 1) / 2)
                                                        for (c, b) in blocks(S)))
 
-            U, S, V, ϵ = tsvd(B; trunc=truncspace(Vtrunc))
+            U, S, V = tsvd(B; trunc=truncspace(Vtrunc))
             ΔU = randn(scalartype(U), space(U))
             ΔS = randn(scalartype(S), space(S))
             ΔV = randn(scalartype(V), space(V))
             T <: Complex && remove_svdgauge_depence!(ΔU, ΔV, U, S, V)
-            test_rrule(tsvd, B; atol, output_tangent=(ΔU, ΔS, ΔV, 0.0),
+            test_rrule(tsvd, B; atol, output_tangent=(ΔU, ΔS, ΔV),
                        fkwargs=(; trunc=truncspace(Vtrunc)))
         end
 
-        let (U, S, V, ϵ) = tsvd(C)
+        let (U, S, V) = tsvd(C)
             ΔU = randn(scalartype(U), space(U))
             ΔS = randn(scalartype(S), space(S))
             ΔV = randn(scalartype(V), space(V))
             T <: Complex && remove_svdgauge_depence!(ΔU, ΔV, U, S, V)
-            test_rrule(tsvd, C; atol, output_tangent=(ΔU, ΔS, ΔV, 0.0))
+            test_rrule(tsvd, C; atol, output_tangent=(ΔU, ΔS, ΔV))
 
             c, = TensorKit.MatrixAlgebra._argmax(x -> sqrt(dim(x[1])) * maximum(diag(x[2])),
                                                  blocks(S))
             trunc = truncdim(round(Int, 2 * dim(c)))
-            U, S, V, ϵ = tsvd(C; trunc)
+            U, S, V = tsvd(C; trunc)
             ΔU = randn(scalartype(U), space(U))
             ΔS = randn(scalartype(S), space(S))
             ΔV = randn(scalartype(V), space(V))
             T <: Complex && remove_svdgauge_depence!(ΔU, ΔV, U, S, V)
-            test_rrule(tsvd, C; atol, output_tangent=(ΔU, ΔS, ΔV, 0.0), fkwargs=(; trunc))
+            test_rrule(tsvd, C; atol, output_tangent=(ΔU, ΔS, ΔV), fkwargs=(; trunc))
         end
 
         let D = LinearAlgebra.eigvals(C)