fix AD tests

Author: lkdvos

ext/TensorKitChainRulesCoreExt/factorizations.jl

@@ -65,7 +65,7 @@ function ChainRulesCore.rrule(::typeof(LinearAlgebra.eigvals!), t::AbstractTenso
 end
 
 function ChainRulesCore.rrule(::typeof(leftorth!), t::AbstractTensorMap; alg=QRpos())
-    alg isa TensorKit.QR || alg isa TensorKit.QRpos ||
+    alg isa MatrixAlgebraKit.LAPACK_HouseholderQR ||
         error("only `alg=QR()` and `alg=QRpos()` are supported")
     QR = leftorth(t; alg)
     function leftorth!_pullback(ΔQR′)
@@ -85,7 +85,7 @@ function ChainRulesCore.rrule(::typeof(leftorth!), t::AbstractTensorMap; alg=QRp
 end
 
 function ChainRulesCore.rrule(::typeof(rightorth!), t::AbstractTensorMap; alg=LQpos())
-    alg isa TensorKit.LQ || alg isa TensorKit.LQpos ||
+    alg isa MatrixAlgebraKit.LAPACK_HouseholderLQ ||
         error("only `alg=LQ()` and `alg=LQpos()` are supported")
     LQ = rightorth(t; alg)
     function rightorth!_pullback(ΔLQ′)

src/TensorKit.jl

@@ -82,9 +82,6 @@ export left_orth, right_orth, left_null, right_null,
        eigh_vals!, eigh_vals, eig_vals!, eig_vals,
        isposdef, isposdef!, ishermitian, isisometry, isunitary, sylvester, rank, cond
 
-# deprecate:
-export eig, eig!, eigh, eigh!, eigen, eigen!, tsvd, tsvd!, leftorth, leftorth!, rightorth,
-       rightorth!, leftnull, leftnull!, rightnull, rightnull!
 export braid, braid!, permute, permute!, transpose, transpose!, twist, twist!, repartition,
        repartition!
 export catdomain, catcodomain, absorb, absorb!

src/tensors/factorizations/matrixalgebrakit.jl

@@ -611,11 +611,17 @@ function left_orth!(t::AbstractTensorMap;
     trunc == notrunc() || kind === :svd ||
         throw(ArgumentError("truncation not supported for left_orth with kind = $kind"))
 
-    kind === :qr && return qr_compact!(t; alg_qr...)
-    kind === :polar && return left_orth_polar!(t; alg_polar...)
-    kind === :svd && return left_orth_svd!(t; trunc, alg_svd...)
-
-    throw(ArgumentError(lazy"`left_orth!` received unknown value `kind = $kind`"))
+    return if kind === :qr
+        alg_qr isa NamedTuple ? qr_compact!(t; alg_qr...) : qr_compact!(t; alg=alg_qr)
+    elseif kind === :polar
+        alg_polar isa NamedTuple ? left_orth_polar!(t; alg_polar...) :
+        left_orth_polar!(t; alg=alg_polar)
+    elseif kind === :svd
+        alg_svd isa NamedTuple ? left_orth_svd!(t; trunc, alg_svd...) :
+        left_orth_svd!(t; trunc, alg=alg_svd)
+    else
+        throw(ArgumentError(lazy"`left_orth!` received unknown value `kind = $kind`"))
+    end
 end
 function right_orth!(t::AbstractTensorMap;
                      trunc::TruncationStrategy=notrunc(),
@@ -624,11 +630,17 @@ function right_orth!(t::AbstractTensorMap;
     trunc == notrunc() || kind === :svd ||
         throw(ArgumentError("truncation not supported for right_orth with kind = $kind"))
 
-    kind === :lq && return lq_compact!(t; alg_lq...)
-    kind === :polar && return right_orth_polar!(t; alg_polar...)
-    kind === :svd && return right_orth_svd!(t; trunc, alg_svd...)
-
-    throw(ArgumentError(lazy"`right_orth!` received unknown value `kind = $kind`"))
+    return if kind === :lq
+        alg_lq isa NamedTuple ? lq_compact!(t; alg_lq...) : lq_compact!(t; alg=alg_lq)
+    elseif kind === :polar
+        alg_polar isa NamedTuple ? right_orth_polar!(t; alg_polar...) :
+        right_orth_polar!(t; alg=alg_polar)
+    elseif kind === :svd
+        alg_svd isa NamedTuple ? right_orth_svd!(t; trunc, alg_svd...) :
+        right_orth_svd!(t; trunc, alg=alg_svd)
+    else
+        throw(ArgumentError(lazy"`right_orth!` received unknown value `kind = $kind`"))
+    end
 end
 
 function left_orth_polar!(t::AbstractTensorMap; alg=nothing, kwargs...)