Conversation
lkdvos
force-pushed
the
ld-frobschur
branch
2 times, most recently
from
55bbeac to
a734548
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Jutho
approved these changes
Sep 24, 2025
Member
Jutho
left a comment
Jutho
left a comment
There was a problem hiding this comment.
I am not the greatest fan of underscores, but I guess that in the current case, it becomes a bit unwieldy without. So this looks good to go for me.
Member
|
Coverage is a bit low, probably because |
lkdvos
force-pushed
the
ld-frobschur
branch
from
a734548 to
9d7654f
Compare
Member
Author
|
I checked, the missed lines are mostly the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #27 by introducing
frobenius_schur_phaseandfrobenius_schur_indicatorto distinguish between the categoric and group-theoretic versions of that concept.I deprecated
frobeniusschurto forward tofrobenius_schur_phase, so this wouldn't be immediately breaking for TensorKit, even though it would be for packages that provide implementations of sectors and specializedfrobeniusschur.