Merge "CliffordOpeartor improvements"

Author: sagnikpal2004

src/dense_cliffords.jl

@@ -63,6 +63,11 @@ end
 CliffordOperator(op::CliffordOperator) = op
 CliffordOperator(paulis::AbstractVector{<:PauliOperator}) = CliffordOperator(Tableau(paulis))
 CliffordOperator(destab::Destabilizer) = CliffordOperator(tab(destab))
+function CliffordOperator(pauli::PauliOperator)
+    res = one(CliffordOperator, nqubits(pauli))
+    phases(res) .⊻= 0x02 .* comm(pauli, tab(res))
+    return res
+end
 
 Base.:(==)(l::CliffordOperator, r::CliffordOperator) = tab(l) == tab(r)
 Base.hash(c::T, h::UInt) where {T<:CliffordOperator} = hash(T, hash(tab(c), h))

test/test_apply_right.jl

@@ -3,26 +3,6 @@
     using QuantumClifford: AbstractCliffordOperator, CliffordOperator
 
     test_sizes = [1,2,63,64,65,127,128,129,511,512,513]
-
-    function CliffordOperator(pauli::PauliOperator)
-        n = nqubits(pauli)
-        res = one(CliffordOperator, n)
-
-        for i in 1:2n
-            if comm(pauli, tab(res), i) == 0x1
-                phases(res)[i] ⊻= 0x02
-            end
-        end
-        return res
-    end
-    
-    @testset "CliffordOperator constructor from PauliOperator" begin
-        for n in test_sizes
-            l = random_clifford(n)
-            pauli = random_pauli(n)
-            @test isequal(apply!(copy(l), pauli; phases=true), apply!(l, CliffordOperator(pauli); phases=true))
-        end
-    end
 
     # SLOW version of apply_right! for testing
     function apply_right_slow!(l::CliffordOperator, r::CliffordOperator; phases=true)

test/test_cliff.jl

@@ -23,6 +23,13 @@
         @testset "Constructors" begin
             @test_throws DimensionMismatch CliffordOperator(T"X")
         end
+        @testset "Constructor from PauliOperator" begin
+            for n in test_sizes
+                l = random_clifford(n)
+                pauli = random_pauli(n)
+                @test isequal(apply!(copy(l), pauli; phases=true), apply!(l, CliffordOperator(pauli); phases=true))
+            end
+        end
         @testset "Permutations of qubits" begin
             for c in [tCNOT, tId1⊗tHadamard, tCNOT⊗tCNOT, tensor_pow(tCNOT,6), tensor_pow(tCNOT,7), tensor_pow(tCNOT,6)⊗tPhase, tensor_pow(tCNOT,7)⊗tPhase]
                 for rep in 1:5