fix: Add types to packages

Author: Quenty

src/acceltween/src/Shared/AccelTween.lua

@@ -1,3 +1,4 @@
+--!nocheck
 --[=[
 	Provides a means to, with both a continuous position and velocity,
 	accelerate from its current position to a target position in minimum time

src/adorneeboundingbox/src/Shared/AdorneeBoundingBox.lua

@@ -18,7 +18,7 @@ local AdorneeBoundingBox = setmetatable({}, BaseObject)
 AdorneeBoundingBox.ClassName = "AdorneeBoundingBox"
 AdorneeBoundingBox.__index = AdorneeBoundingBox
 
-function AdorneeBoundingBox.new(initialAdornee)
+function AdorneeBoundingBox.new(initialAdornee: Instance)
 	local self = setmetatable(BaseObject.new(), AdorneeBoundingBox)
 
 	self._adornee = self._maid:Add(ValueObject.new(initialAdornee))
@@ -41,7 +41,7 @@ function AdorneeBoundingBox.new(initialAdornee)
 	return self
 end
 
-function AdorneeBoundingBox:SetAdornee(adornee)
+function AdorneeBoundingBox:SetAdornee(adornee: Instance?)
 	assert(typeof(adornee) == "Instance" or adornee == nil, "Bad adornee")
 
 	self._adornee.Value = adornee
@@ -90,7 +90,7 @@ end
 	Gets the CFrame of the adornee
 	@return Vector3
 ]=]
-function AdorneeBoundingBox:GetCFrame()
+function AdorneeBoundingBox:GetCFrame(): CFrame?
 	return self._bbCFrame.Value
 end
 
@@ -106,7 +106,7 @@ end
 	Gets the size of the adornee
 	@return Vector3
 ]=]
-function AdorneeBoundingBox:GetSize()
+function AdorneeBoundingBox:GetSize(): Vector3
 	return self._bbSize.Value
 end
 
@@ -153,7 +153,7 @@ function AdorneeBoundingBox:_setupTool(tool)
 	return topMaid
 end
 
-function AdorneeBoundingBox:_setupModel(model)
+function AdorneeBoundingBox:_setupModel(model: Model)
 	assert(typeof(model) == "Instance" and model:IsA("Model"), "Bad model")
 
 	local topMaid = Maid.new()
@@ -190,7 +190,7 @@ function AdorneeBoundingBox:_setupHumanoid(humanoid: Humanoid)
 	return topMaid
 end
 
-function AdorneeBoundingBox:_setupAttachment(attachment)
+function AdorneeBoundingBox:_setupAttachment(attachment: Attachment)
 	assert(typeof(attachment) == "Instance" and attachment:IsA("Attachment"), "Bad attachment")
 
 	local maid = Maid.new()
@@ -224,7 +224,7 @@ function AdorneeBoundingBox:_setupAttachment(attachment)
 	return maid
 end
 
-function AdorneeBoundingBox:_setupPart(part)
+function AdorneeBoundingBox:_setupPart(part: BasePart)
 	assert(typeof(part) == "Instance" and part:IsA("BasePart"), "Bad part")
 
 	local maid = Maid.new()

src/adorneeboundingbox/src/Shared/AdorneeModelBoundingBox.lua

@@ -17,7 +17,7 @@ local AdorneeModelBoundingBox = setmetatable({}, BaseObject)
 AdorneeModelBoundingBox.ClassName = "AdorneeModelBoundingBox"
 AdorneeModelBoundingBox.__index = AdorneeModelBoundingBox
 
-function AdorneeModelBoundingBox.new(model)
+function AdorneeModelBoundingBox.new(model: Model)
 	local self = setmetatable(BaseObject.new(model), AdorneeModelBoundingBox)
 
 	self._bbCFrame = self._maid:Add(ValueObject.new(nil))

src/adorneeboundingbox/src/Shared/AdorneePartBoundingBox.lua

@@ -14,7 +14,7 @@ local AdorneePartBoundingBox = setmetatable({}, BaseObject)
 AdorneePartBoundingBox.ClassName = "AdorneePartBoundingBox"
 AdorneePartBoundingBox.__index = AdorneePartBoundingBox
 
-function AdorneePartBoundingBox.new(part)
+function AdorneePartBoundingBox.new(part: BasePart)
 	assert(typeof(part) == "Instance" and part:IsA("BasePart"), "Bad part")
 
 	local self = setmetatable(BaseObject.new(part), AdorneePartBoundingBox)

src/adorneeboundingbox/src/Shared/RxPartBoundingBoxUtils.lua

@@ -8,7 +8,7 @@ local RxInstanceUtils = require("RxInstanceUtils")
 
 local RxPartBoundingBoxUtils = {}
 
-function RxPartBoundingBoxUtils.observePartCFrame(part)
+function RxPartBoundingBoxUtils.observePartCFrame(part: BasePart)
 	assert(typeof(part) == "Instance" and part:IsA("BasePart"), "Bad part")
 
 	return RxInstanceUtils.observeProperty(part, "CFrame")

src/adorneedata/src/Shared/AdorneeData.lua

@@ -89,7 +89,7 @@ AdorneeData.__index = AdorneeData
 	@param prototype any
 	@return AdorneeData<T>
 ]=]
-function AdorneeData.new(prototype)
+function AdorneeData.new(prototype: any)
 	local self = setmetatable({}, AdorneeData)
 
 	self._fullPrototype = assert(prototype, "Bad prototype")
@@ -128,6 +128,8 @@ function AdorneeData:__index(index)
 				return AttributeValue.new(adornee, index, found)
 			end, found)
 		end
+	else
+		error("Bad index")
 	end
 end
 
@@ -138,7 +140,7 @@ end
 	@return boolean
 	@return string -- Error message
 ]=]
-function AdorneeData:IsStrictData(data)
+function AdorneeData:IsStrictData(data): (boolean, string?)
 	return self:GetStrictTInterface()(data)
 end
 

src/adorneedata/src/Shared/AdorneeDataEntry.lua

@@ -64,7 +64,7 @@ end
 	@param data any
 	@return boolean
 ]=]
-function AdorneeDataEntry.isAdorneeDataEntry(data)
+function AdorneeDataEntry.isAdorneeDataEntry(data: any): boolean
 	return DuckTypeUtils.isImplementation(AdorneeDataEntry, data)
 end
 

src/adorneeutils/src/Shared/AdorneeUtils.lua

@@ -1,3 +1,4 @@
+--!strict
 --[=[
 	Utilities involving an "Adornee" effectively, any Roblox instance. This is an extremely
 	useful library to use as it lets you abstract applying effects to any Roblox instance
@@ -54,7 +55,7 @@ end
 	@return CFrame? -- Center of the bounding box
 	@return Vector3? -- Size of the bounding box
 ]=]
-function AdorneeUtils.getBoundingBox(adornee: Instance): (CFrame, Vector3)
+function AdorneeUtils.getBoundingBox(adornee: Instance): (CFrame?, Vector3?)
 	if adornee:IsA("Model") then
 		return adornee:GetBoundingBox()
 	elseif adornee:IsA("Attachment") then
@@ -97,15 +98,15 @@ function AdorneeUtils.getParts(adornee: Instance): { BasePart }
 		table.insert(parts, adornee)
 	end
 
-	local searchParent
+	local searchParent: Instance?
 	if adornee:IsA("Humanoid") then
 		searchParent = adornee.Parent
 	else
 		searchParent = adornee
 	end
 
-	if searchParent then
-		for _, part in pairs(searchParent:GetDescendants()) do
+	if searchParent ~= nil then
+		for _, part in searchParent:GetDescendants() do
 			if part:IsA("BasePart") then
 				table.insert(parts, part)
 			end
@@ -183,7 +184,7 @@ function AdorneeUtils.getPartVelocity(adornee: Instance): Vector3?
 		return nil
 	end
 
-	return part.Velocity
+	return part.AssemblyLinearVelocity
 end
 
 --[=[
@@ -197,10 +198,11 @@ function AdorneeUtils.getPart(adornee: Instance): BasePart?
 	if adornee:IsA("BasePart") then
 		return adornee
 	elseif adornee:IsA("Model") then
-		if adornee.PrimaryPart then
+		if adornee.PrimaryPart ~= nil then
 			return adornee.PrimaryPart
 		else
-			return adornee:FindFirstChildWhichIsA("BasePart")
+			local basePart: BasePart = adornee:FindFirstChildWhichIsA("BasePart")
+			return basePart
 		end
 	elseif adornee:IsA("Attachment") then
 		return adornee:FindFirstAncestorWhichIsA("BasePart")
@@ -237,7 +239,8 @@ function AdorneeUtils.getRenderAdornee(adornee: Instance): Instance?
 	elseif adornee:IsA("Humanoid") then
 		return adornee.Parent
 	elseif adornee:IsA("Accessory") or adornee:IsA("Clothing") then
-		return adornee:FindFirstChildWhichIsA("BasePart")
+		local basePart = adornee:FindFirstChildWhichIsA("BasePart")
+		return basePart
 	elseif adornee:IsA("Tool") then
 		local handle = adornee:FindFirstChild("Handle")
 		if handle and handle:IsA("BasePart") then

src/adorneevalue/src/Shared/AdorneeValue.lua

@@ -27,8 +27,6 @@ function AdorneeValue.new()
 	self._adornee = ValueObject.new()
 	self._maid:GiveTask(self._adornee)
 
-
-
 	return self
 end
 
@@ -37,7 +35,7 @@ end
 
 	@return Instance | CFrame | Vector3 | nil
 ]=]
-function AdorneeValue:GetAdornee()
+function AdorneeValue:GetAdornee(): (Instance | CFrame | Vector3)?
 	return self._adornee.Value
 end
 
@@ -79,10 +77,10 @@ end
 
 function AdorneeValue:__newindex(index, value)
 	if index == "Value" then
-		assert(typeof(value) == "Instance"
-		or typeof(value) == "Vector3"
-		or typeof(value) == "CFrame"
-		or value == nil, "Bad value")
+		assert(
+			typeof(value) == "Instance" or typeof(value) == "Vector3" or typeof(value) == "CFrame" or value == nil,
+			"Bad value"
+		)
 
 		self._adornee.Value = value
 	elseif index == "_adornee" or index == "_maid" then
@@ -102,19 +100,19 @@ end
 	@return Observable<CFrame | nil>
 ]=]
 function AdorneeValue:ObserveBottomCFrame()
-	return Blend.Computed(self._adornee, function(adornee)
+	return Blend.Computed(self._adornee, function(adornee: Instance): CFrame?
 		if typeof(adornee) == "CFrame" then
 			return adornee
 		elseif typeof(adornee) == "Vector3" then
 			return CFrame.new(adornee)
 		elseif typeof(adornee) == "Instance" then
 			-- TODO: Nearest bounding box stuff.
 			local bbCFrame, bbSize = AdorneeUtils.getBoundingBox(adornee)
-			if not bbCFrame then
+			if not bbCFrame or not bbSize then
 				return nil
 			end
 
-			return bbCFrame * CFrame.new(0, -bbSize.y/2, 0)
+			return bbCFrame * CFrame.new(0, -bbSize.Y / 2, 0)
 		elseif adornee then
 			warn("Bad adornee")
 			return nil
@@ -140,7 +138,7 @@ end
 
 	@return Vector3 | nil
 ]=]
-function AdorneeValue:GetCenterPosition()
+function AdorneeValue:GetCenterPosition(): Vector3?
 	local adornee = self._adornee.Value
 
 	if typeof(adornee) == "CFrame" then
@@ -174,7 +172,7 @@ end
 
 	@return number?
 ]=]
-function AdorneeValue:GetRadius()
+function AdorneeValue:GetRadius(): number?
 	local adornee = self._adornee.Value
 
 	if typeof(adornee) == "CFrame" then
@@ -184,11 +182,11 @@ function AdorneeValue:GetRadius()
 	elseif typeof(adornee) == "Instance" then
 		-- TODO: Nearest bounding box stuff.
 		local bbCFrame, bbSize = AdorneeUtils.getBoundingBox(adornee)
-		if not bbCFrame then
+		if not bbCFrame or not bbSize then
 			return nil
 		end
 
-		return bbSize.magnitude/2
+		return bbSize.Magnitude / 2
 	elseif adornee then
 		warn("Bad adornee")
 		return nil
@@ -212,9 +210,10 @@ function AdorneeValue:ObservePositionTowards(observeTargetPosition, observeRadiu
 		observeTargetPosition,
 		self:ObserveCenterPosition(),
 		observeRadius or self:ObserveRadius(),
-		function(target, radius, center)
+		function(target: Vector3, radius: number, center: Vector3)
 			return self:_getPositionTowards(target, radius, center)
-		end)
+		end
+	)
 end
 
 --[=[
@@ -226,7 +225,7 @@ end
 	@param center Vector3
 	@return Vector3
 ]=]
-function AdorneeValue:GetPositionTowards(target, radius, center)
+function AdorneeValue:GetPositionTowards(target: Vector3, radius: number, center: Vector3): Vector3?
 	assert(typeof(target) == "Vector3", "Bad target")
 
 	center = center or self:GetCenterPosition()
@@ -235,13 +234,13 @@ function AdorneeValue:GetPositionTowards(target, radius, center)
 	return self:_getPositionTowards(target, radius, center)
 end
 
-function AdorneeValue:_getPositionTowards(target, radius, center)
+function AdorneeValue:_getPositionTowards(target: Vector3, radius: number, center: Vector3): Vector3?
 	if not (radius and target and center) then
 		return nil
 	end
 
 	local offset = target - center
-	if offset.magnitude == 0 then
+	if offset.Magnitude == 0 then
 		return nil
 	end
 
@@ -255,7 +254,7 @@ end
 	@return Observable<Instance?>
 ]=]
 function AdorneeValue:ObserveAttachmentParent()
-	return Blend.Computed(self._adornee, function(adornee)
+	return Blend.Computed(self._adornee, function(adornee): Instance?
 		if typeof(adornee) == "Instance" then
 			-- TODO: Nearest bounding box stuff.
 			local part = AdorneeUtils.getPart(adornee)
@@ -286,7 +285,7 @@ end
 function AdorneeValue:RenderPositionAttachment(props)
 	props = props or {}
 
-	local observeWorldPosition = props.WorldPosition or self:ObserveCenterPosition();
+	local observeWorldPosition = props.WorldPosition or self:ObserveCenterPosition()
 	local observeParentPart = self:ObserveAttachmentParent()
 
 	local observeCFrame = Blend.Computed(observeParentPart, observeWorldPosition, function(parentPart, position)
@@ -295,7 +294,7 @@ function AdorneeValue:RenderPositionAttachment(props)
 		else
 			return CFrame.new(0, 0, 0)
 		end
-	end);
+	end)
 
 	return Blend.New "Attachment" {
 		Name = props.Name or "AdorneeValueAttachment";

src/animations/src/Shared/AnimationPromiseUtils.lua

@@ -15,10 +15,10 @@ local AnimationPromiseUtils = {}
 	Promises that the track is finished
 
 	@param animationTrack AnimationTrack
-	@param endMarkerName string | nil
+	@param endMarkerName string?
 	@return Promise
 ]=]
-function AnimationPromiseUtils.promiseFinished(animationTrack, endMarkerName)
+function AnimationPromiseUtils.promiseFinished(animationTrack: AnimationTrack, endMarkerName: string?)
 	assert(typeof(animationTrack) == "Instance", "Bad animationTrack")
 	assert(type(endMarkerName) == "string" or endMarkerName == nil, "Bad endMarkerName")
 	local promise = Promise.new()
@@ -52,7 +52,7 @@ end
 	@param animationTrack AnimationTrack
 	@return Promise
 ]=]
-function AnimationPromiseUtils.promiseLoaded(animationTrack)
+function AnimationPromiseUtils.promiseLoaded(animationTrack: AnimationTrack)
 	assert(typeof(animationTrack) == "Instance", "Bad animationTrack")
 
 	if animationTrack.Length > 0 then
@@ -97,7 +97,7 @@ end
 	@param keyframeName string
 	@return Promise
 ]=]
-function AnimationPromiseUtils.promiseKeyframeReached(animationTrack, keyframeName)
+function AnimationPromiseUtils.promiseKeyframeReached(animationTrack: AnimationTrack, keyframeName: string)
 	assert(typeof(animationTrack) == "Instance", "Bad animationTrack")
 	assert(type(keyframeName) == "string", "Bad endMarkerName")