Merge pull request #531 from Quenty/users/quenty/wfyb

Bulk refactors and small bug fixes

Author: Quenty

src/buttonhighlightmodel/src/Client/HandleHighlightModel.lua

@@ -10,6 +10,7 @@ local BaseObject = require("BaseObject")
 local Maid = require("Maid")
 local Blend = require("Blend")
 local Rx = require("Rx")
+local ValueObject = require("ValueObject")
 
 local HandleHighlightModel = setmetatable({}, BaseObject)
 HandleHighlightModel.ClassName = "HandleHighlightModel"
@@ -18,17 +19,11 @@ HandleHighlightModel.__index = HandleHighlightModel
 function HandleHighlightModel.new()
 	local self = setmetatable(BaseObject.new(), HandleHighlightModel)
 
-	self.IsMouseOver = Instance.new("BoolValue")
-	self.IsMouseOver.Value = false
-	self._maid:GiveTask(self.IsMouseOver)
+	self.IsMouseOver = self._maid:Add(ValueObject.new(false, "boolean"))
 
-	self.IsMouseDown = Instance.new("BoolValue")
-	self.IsMouseDown.Value = false
-	self._maid:GiveTask(self.IsMouseDown)
+	self.IsMouseDown = self._maid:Add(ValueObject.new(false, "boolean"))
 
-	self.IsHighlighted = Instance.new("BoolValue")
-	self.IsHighlighted.Value = false
-	self._maid:GiveTask(self.IsHighlighted)
+	self.IsHighlighted = self._maid:Add(ValueObject.new(false, "boolean"))
 
 	self._maid:GiveTask(self.IsMouseDown.Changed:Connect(function()
 		self:_updateHighlighted()

src/camera/package.json

@@ -37,6 +37,7 @@
     "@quenty/qframe": "file:../qframe",
     "@quenty/servicebag": "file:../servicebag",
     "@quenty/spring": "file:../spring",
+    "@quenty/valueobject": "file:../valueobject",
     "@quenty/vector3utils": "file:../vector3utils"
   },
   "devDependencies": {

src/camera/src/Client/Controls/GamepadRotateModel.lua

@@ -9,6 +9,7 @@ local require = require(script.Parent.loader).load(script)
 local AccelTween = require("AccelTween")
 local BaseObject = require("BaseObject")
 local CameraGamepadInputUtils = require("CameraGamepadInputUtils")
+local ValueObject = require("ValueObject")
 
 local GamepadRotateModel = setmetatable({}, BaseObject)
 GamepadRotateModel.__index = GamepadRotateModel
@@ -24,9 +25,7 @@ function GamepadRotateModel.new()
 	self._rampVelocityX = AccelTween.new(25)
 	self._rampVelocityY = AccelTween.new(25)
 
-	self.IsRotating = Instance.new("BoolValue")
-	self.IsRotating.Value = false
-	self._maid:GiveTask(self.IsRotating)
+	self.IsRotating = self._maid:Add(ValueObject.new(false, "boolean"))
 
 	return self
 end

src/chatproviderservice/src/Server/Commands/ChatProviderCommandService.lua

@@ -22,6 +22,7 @@ function ChatProviderCommandService:Init(serviceBag)
 
 	-- External
 	self._cmdrService = self._serviceBag:GetService(require("CmdrService"))
+	self._permissionService = self._serviceBag:GetService(require("PermissionService"))
 
 	-- Internal
 	self._chatProviderService = self._serviceBag:GetService(require("ChatProviderService"))

src/chatproviderservice/src/Shared/Binders/HasChatTagsBase.lua

@@ -18,8 +18,7 @@ HasChatTagsBase.__index = HasChatTagsBase
 function HasChatTagsBase.new(player)
 	local self = setmetatable(BaseObject.new(player), HasChatTagsBase)
 
-	self._lastChatTags = ValueObject.new(nil)
-	self._maid:GiveTask(self._lastChatTags)
+	self._lastChatTags = self._maid:Add(ValueObject.new(nil))
 
 	self._maid:GiveTask(task.defer(function()
 		self._maid:GiveTask(self:_observeTagDataListBrio():Subscribe(function(brio)

src/colorpalette/src/Shared/Swatch/ColorSwatch.lua

@@ -26,8 +26,7 @@ function ColorSwatch.new(color, vividness)
 	self._color = ValueObject.new(Color3.new(0, 0, 0))
 	self._maid:GiveTask(self._color)
 
-	self._vividness = ValueObject.new(nil)
-	self._maid:GiveTask(self._vividness)
+	self._vividness = self._maid:Add(ValueObject.new(nil))
 
 	self:SetBaseColor(color)
 	self:SetVividness(vividness)

src/flipbook/src/Client/Player/FlipbookPlayer.lua

@@ -29,17 +29,13 @@ function FlipbookPlayer.new(imageLabel)
 
 	assert(typeof(self._obj) == "Instance" and (self._obj:IsA("ImageLabel") or self._obj:IsA("ImageButton")), "Bad imageLabel")
 
-	self._isPlaying = ValueObject.new(false, "boolean")
-	self._maid:GiveTask(self._isPlaying)
+	self._isPlaying = self._maid:Add(ValueObject.new(false, "boolean"))
 
-	self._isBoomarang = ValueObject.new(false, "boolean")
-	self._maid:GiveTask(self._isBoomarang)
+	self._isBoomarang = self._maid:Add(ValueObject.new(false, "boolean"))
 
-	self._playData = ValueObject.new(nil)
-	self._maid:GiveTask(self._playData)
+	self._playData = self._maid:Add(ValueObject.new(nil))
 
-	self._flipbook = ValueObject.new(nil)
-	self._maid:GiveTask(self._flipbook)
+	self._flipbook = self._maid:Add(ValueObject.new(nil))
 
 	self._originalImage = self._obj.Image
 	self._originalRectOffset = self._obj.ImageRectOffset

src/gameproductservice/src/Shared/Ownership/PlayerAssetOwnershipTracker.lua

@@ -130,7 +130,7 @@ function PlayerAssetOwnershipTracker:PromiseOwnsAsset(idOrKey)
 			return Promise.resolved(true)
 		end
 	else
-		warn(string.format("[PlayerAssetOwnershipTracker.PromiseOwnsAsset] - Nothing with key %q", tostring(idOrKey)))
+		return Promise.rejected(string.format("[PlayerAssetOwnershipTracker.PromiseOwnsAsset] - Nothing with key %q", tostring(idOrKey)))
 	end
 
 	-- Check actual callback querying Roblox

src/guivisiblemanager/package.json

@@ -28,7 +28,8 @@
     "@quenty/baseobject": "file:../baseobject",
     "@quenty/cancellabledelay": "file:../cancellabledelay",
     "@quenty/loader": "file:../loader",
-    "@quenty/maid": "file:../maid"
+    "@quenty/maid": "file:../maid",
+    "@quenty/valueobject": "file:../valueobject"
   },
   "publishConfig": {
     "access": "public"

src/guivisiblemanager/src/Client/GuiVisibleManager.lua

@@ -14,6 +14,7 @@ local HttpService = game:GetService("HttpService")
 local BaseObject = require("BaseObject")
 local Maid = require("Maid")
 local cancellableDelay = require("cancellableDelay")
+local ValueObject = require("ValueObject")
 
 local GuiVisibleManager = setmetatable({}, BaseObject)
 GuiVisibleManager.ClassName = "GuiVisibleManager"
@@ -34,9 +35,7 @@ function GuiVisibleManager.new(promiseNewPane, maxHideTime)
 
 	self._nextDoNotAnimate = false
 
-	self._paneVisible = Instance.new("BoolValue")
-	self._paneVisible.Value = false
-	self._maid:GiveTask(self._paneVisible)
+	self._paneVisible = self._maid:Add(ValueObject.new(false, "boolean"))
 
 	self._showHandles = {}