fix: Fix existing tests

Author: unrooot

src/binder/src/Shared/BinderProvider.spec.lua

@@ -26,7 +26,7 @@ describe("BinderProvider.new()", function()
 			end))
 		end)
 
-		expect(provider).to.be.a("table")
+		expect(provider).toEqual(expect.any("table"))
 	end)
 
 	it("should initialize", function()
@@ -36,8 +36,10 @@ describe("BinderProvider.new()", function()
 	end)
 
 	it("should contain the binder", function()
-		expect(provider.Test).to.be.a("table")
+		expect(provider.Test).toEqual(expect.any("table"))
 	end)
 
-	provider:Destroy()
+	if provider then
+		provider:Destroy()
+	end
 end)

src/clienttranslator/src/Shared/Numbers/NumberLocalizationUtils.spec.lua

@@ -10,7 +10,7 @@ local it = Jest.Globals.it
 
 local function checkLocale(locale, responseMapping)
 	for input, output in pairs(responseMapping) do
-		expect(NumberLocalizationUtils.localize(input, locale)).to.equal(output)
+		expect(NumberLocalizationUtils.localize(input, locale)).toBe(output)
 	end
 end
 
@@ -36,21 +36,21 @@ describe("NumberLocalizationUtils.localize", function()
 	-- 	local logs = Logging.capture(function()
 	-- 		checkValid_en_zh("bad_locale")
 	-- 	end)
-	-- 	expect(string.match(logs.warnings[1], "^Warning: Locale not found:") ~= nil).to.equal(true)
+	-- 	expect(string.match(logs.warnings[1], "^Warning: Locale not found:") ~= nil).toBe(true)
 	-- end)
 
 	-- it("should default to en-us when locale is nil", function()
 	-- 	local logs = Logging.capture(function()
 	-- 		checkValid_en_zh(nil)
 	-- 	end)
-	-- 	expect(string.match(logs.warnings[1], "^Warning: Locale not found:") ~= nil).to.equal(true)
+	-- 	expect(string.match(logs.warnings[1], "^Warning: Locale not found:") ~= nil).toBe(true)
 	-- end)
 
 	-- it("should default to en-us when locale is empty", function()
 	-- 	local logs = Logging.capture(function()
 	-- 		checkValid_en_zh("")
 	-- 	end)
-	-- 	expect(string.match(logs.warnings[1], "^Warning: Locale not found:") ~= nil).to.equal(true)
+	-- 	expect(string.match(logs.warnings[1], "^Warning: Locale not found:") ~= nil).toBe(true)
 	-- end)
 
 	it("should localize correctly. (en-us)", function()
@@ -106,7 +106,7 @@ describe("NumberLocalizationUtils.abbreviate", function()
 		}
 
 		for input, output in pairs(roundToZeroMap) do
-			expect(NumberLocalizationUtils.abbreviate(input, "en-us", RoundingBehaviourTypes.TRUNCATE)).to.equal(output)
+			expect(NumberLocalizationUtils.abbreviate(input, "en-us", RoundingBehaviourTypes.TRUNCATE)).toBe(output)
 		end
 	end)
 end)

src/elo/src/Shared/EloUtils.spec.lua

@@ -5,6 +5,7 @@
 
 local require = require(game:GetService("ServerScriptService"):FindFirstChild("LoaderUtils", true).Parent).bootstrapStory(script)
 
+local EloMatchResult = require("EloMatchResult")
 local EloUtils = require("EloUtils")
 local Jest = require("Jest")
 
@@ -28,11 +29,11 @@ describe("EloUtils.getNewElo", function()
 			playerRating,
 			opponentRating,
 			{
-				EloUtils.MatchResult.PLAYER_ONE_WIN;
+				EloMatchResult.PLAYER_ONE_WIN;
 			})
 
-		expect(newPlayerWinRating > playerRating).to.equal(true)
-		expect(newOpponentWinRating < opponentRating).to.equal(true)
+		expect(newPlayerWinRating > playerRating).toBe(true)
+		expect(newOpponentWinRating < opponentRating).toBe(true)
 	end)
 
 	it("should change on a loss", function()
@@ -41,11 +42,11 @@ describe("EloUtils.getNewElo", function()
 			playerRating,
 			opponentRating,
 			{
-				EloUtils.MatchResult.PLAYER_TWO_WIN;
+				EloMatchResult.PLAYER_TWO_WIN;
 			})
 
-		expect(newPlayerLossRating < playerRating).to.equal(true)
-		expect(newOpponentLossRating > opponentRating).to.equal(true)
+		expect(newPlayerLossRating < playerRating).toBe(true)
+		expect(newOpponentLossRating > opponentRating).toBe(true)
 	end)
 
 	it("should change on a draw", function()
@@ -54,26 +55,26 @@ describe("EloUtils.getNewElo", function()
 			playerRating,
 			opponentRating,
 			{
-				EloUtils.MatchResult.DRAW;
+				EloMatchResult.DRAW;
 			})
 
-		expect(newPlayerDrawRating > playerRating).to.equal(true)
-		expect(newOpponentDrawRating < opponentRating).to.equal(true)
+		expect(newPlayerDrawRating > playerRating).toBe(true)
+		expect(newOpponentDrawRating < opponentRating).toBe(true)
 	end)
 
 	it("should change more on an unexpected win then a loss", function()
 		local winChange = math.abs(playerRating - newPlayerWinRating)
 		local drawChange = math.abs(playerRating - newPlayerDrawRating)
 		local lossChange = math.abs(playerRating - newPlayerLossRating)
 
-		expect(winChange > lossChange).to.equal(true)
-		expect(winChange > drawChange ).to.equal(true)
-		expect(drawChange > lossChange).to.equal(true)
+		expect(winChange > lossChange).toBe(true)
+		expect(winChange > drawChange ).toBe(true)
+		expect(drawChange > lossChange).toBe(true)
 	end)
 
 	it("should compute percentile as 0.5", function()
 		local percentile = EloUtils.getPercentile(config, 1400)
 
-		expect(percentile).to.equal(0.5)
+		expect(percentile).toBe(0.5)
 	end)
 end)

src/experiencecalculator/src/Shared/ExperienceUtils.spec.lua

@@ -18,25 +18,25 @@ local config = ExperienceUtils.createExperienceConfig({
 describe("ExperienceUtils.getLevel", function()
 	it("should return a level", function()
 		local level = ExperienceUtils.getLevel(config, 0)
-		expect(level).to.equal(1)
+		expect(level).toBe(1)
 
 		level = ExperienceUtils.getLevel(config, 399)
-		expect(level).to.equal(1)
+		expect(level).toBe(1)
 
 		level = ExperienceUtils.getLevel(config, 400)
-		expect(level).to.equal(2)
+		expect(level).toBe(2)
 	end)
 end)
 
 describe("ExperienceUtils.experienceFromLevel", function()
 	it("should return experience", function()
 		local experience = ExperienceUtils.experienceFromLevel(config, 1)
-		expect(experience).to.equal(0)
+		expect(experience).toBe(0)
 
 		experience = ExperienceUtils.experienceFromLevel(config, 2)
-		expect(experience).to.equal(400)
+		expect(experience).toBe(400)
 
 		experience = ExperienceUtils.experienceFromLevel(config, 3)
-		expect(experience).to.equal(1200)
+		expect(experience).toBe(1200)
 	end)
 end)