Skip to content

Commit 6eeb33b

Browse files
authored
fix: Small patches to nevermore libraries (#614)
1 parent 248db12 commit 6eeb33b

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

src/animations/src/Shared/AnimationSlotPlayer.lua

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,9 @@ function AnimationSlotPlayer.Play(
254254
priority = priority or self._defaultAnimationPriority.Value
255255
weight = weight or 1 -- We need to explicitly adjust the weight here
256256

257+
-- Make sure we stop our last animation fully
258+
self._maid._current = nil
259+
257260
local topMaid = Maid.new()
258261

259262
local animationId = RbxAssetUtils.toRbxAssetId(id)

src/getmechanismparts/src/Shared/getMechanismParts.lua

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,11 @@ return function(originParts: Instance | { BasePart }): { BasePart }
8686
local part1
8787
if joint:IsA("Constraint") then
8888
if not IGNORE_CONSTRAINT_SET[joint.ClassName] then
89-
part0 = joint.Attachment0.Parent
90-
part1 = joint.Attachment1.Parent
89+
local attachment0 = joint.Attachment0
90+
local attachment1 = joint.Attachment1
91+
92+
part0 = if attachment0 then attachment0:FindFirstAncestorWhichIsA("BasePart") else nil
93+
part1 = if attachment1 then attachment1:FindFirstAncestorWhichIsA("BasePart") else nil
9194
end
9295
else
9396
part0 = (joint :: any).Part0

src/tie/src/Shared/Members/Signals/TieSignalInterface.lua

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,13 @@ end
3636
function TieSignalInterface:Fire(...)
3737
local bindableEvent = self:_getBindableEvent()
3838
if not bindableEvent then
39-
warn(string.format("[TieSignalInterface] - No bindableEvent for %q", self._memberDefinition:GetMemberName()))
39+
warn(
40+
string.format(
41+
"[TieSignalInterface] - No bindableEvent for %q. Skipping fire.",
42+
self._memberDefinition:GetMemberName()
43+
)
44+
)
45+
return
4046
end
4147

4248
bindableEvent:Fire(TieUtils.encode(...))

0 commit comments

Comments
 (0)