fix: Additional type checking updates

Author: Quenty

.vscode/settings.json

@@ -5,7 +5,8 @@
     "out": true,
     "roblox.toml": true
   },
-  "luau-lsp.server.path": "/Users/jonnen/.aftman/bin/luau-lsp",
+  // "luau-lsp.server.path": "/Users/jonnen/.aftman/bin/luau-lsp",
+  "luau-lsp.server.path": "/Users/jonnen/git/games/luau-lsp/cmake-build-debug/luau-lsp",
   "luau-lsp.ignoreGlobs": ["**/node_modules/**"],
   "luau-lsp.fflags.enableNewSolver": false,
   "[lua]": {

aftman.toml

@@ -3,7 +3,7 @@
 
 # To add a new tool, add an entry to this table.
 [tools]
-luau-lsp = "Quenty/luau-lsp@1.42.0-quenty.1"
+luau-lsp = "Quenty/luau-lsp@1.45.0-quenty"
 lune = "lune-org/lune@0.8.9"
 mantle = "blake-mealey/mantle@0.10.7"
 moonwave-extractor = "UpliftGames/moonwave@1.3.0"

foreman.toml

@@ -0,0 +1,3 @@
+[tools]
+rojo = { github = "quenty/rojo", version = "=7.4.3-quenty-npm-canary.2" }
+luau-lsp = { github = "quenty/luau-lsp", version = "=1.45.0-quenty" }

games/integration/modules/Client/Button/LookAtButtonsClient.lua

@@ -16,14 +16,15 @@ local AdorneeUtils = require("AdorneeUtils")
 local Maid = require("Maid")
 local IKServiceClient = require("IKServiceClient")
 local IKAimPositionPriorites = require("IKAimPositionPriorites")
+local ServiceBag = require("ServiceBag")
 
 local LOOK_NEAR_DISTANCE = 15
 
 local LookAtButtonsClient = setmetatable({}, BaseObject)
 LookAtButtonsClient.ClassName = "LookAtButtonsClient"
 LookAtButtonsClient.__index = LookAtButtonsClient
 
-function LookAtButtonsClient.new(humanoid, serviceBag)
+function LookAtButtonsClient.new(humanoid, serviceBag: ServiceBag.ServiceBag)
 	local self = setmetatable(BaseObject.new(humanoid), LookAtButtonsClient)
 
 	self._serviceBag = assert(serviceBag, "No serviceBag")

games/integration/modules/Client/GameBindersClient.lua

@@ -6,9 +6,9 @@ local require = require(script.Parent.loader).load(script)
 
 local Binder = require("Binder")
 local BinderProvider = require("BinderProvider")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
-return BinderProvider.new(script.Name, function(self, serviceBag: _ServiceBag.ServiceBag)
+return BinderProvider.new(script.Name, function(self, serviceBag: ServiceBag.ServiceBag)
 	self:Add(Binder.new("PhysicalButton", require("PhysicalButtonClient"), serviceBag))
 	self:Add(Binder.new("LookAtButtons", require("LookAtButtonsClient"), serviceBag))
 end)

games/integration/modules/Client/GameServiceClient.lua

@@ -4,12 +4,12 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local GameServiceClient = {}
 GameServiceClient.ServiceName = "GameServiceClient"
 
-function GameServiceClient:Init(serviceBag: _ServiceBag.ServiceBag)
+function GameServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 
 	-- External

games/integration/modules/Server/GameBindersServer.lua

@@ -7,8 +7,9 @@ local require = require(script.Parent.loader).load(script)
 local Binder = require("Binder")
 local BinderProvider = require("BinderProvider")
 local PlayerHumanoidBinder = require("PlayerHumanoidBinder")
+local ServiceBag = require("ServiceBag")
 
-return BinderProvider.new(script.Name, function(self, serviceBag)
+return BinderProvider.new(script.Name, function(self, serviceBag: ServiceBag.ServiceBag)
 	self:Add(Binder.new("PhysicalButton", require("PhysicalButton"), serviceBag))
 	self:Add(PlayerHumanoidBinder.new("LookAtButtons", require("LookAtButtons"), serviceBag))
 end)

games/integration/modules/Server/GameServiceServer.lua

@@ -4,11 +4,11 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local GameServiceServer = {}
 
-function GameServiceServer:Init(serviceBag: _ServiceBag.ServiceBag)
+function GameServiceServer:Init(serviceBag: ServiceBag.ServiceBag)
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 
 	-- External

src/actionmanager/src/Client/ActionManager.lua

@@ -16,7 +16,7 @@ local ValueObject = require("ValueObject")
 local Signal = require("Signal")
 local Maid = require("Maid")
 
-local ActionManager = setmetatable({}, {})
+local ActionManager = {}
 ActionManager.__index = ActionManager
 ActionManager.ClassName = "ActionManager"
 

src/adorneeboundingbox/src/Shared/AdorneeBoundingBox.lua

@@ -9,12 +9,12 @@ local AdorneeModelBoundingBox = require("AdorneeModelBoundingBox")
 local AdorneePartBoundingBox = require("AdorneePartBoundingBox")
 local BaseObject = require("BaseObject")
 local Maid = require("Maid")
+local Observable = require("Observable")
 local Rx = require("Rx")
 local RxBrioUtils = require("RxBrioUtils")
 local RxInstanceUtils = require("RxInstanceUtils")
 local RxPartBoundingBoxUtils = require("RxPartBoundingBoxUtils")
 local ValueObject = require("ValueObject")
-local _Observable = require("Observable")
 
 local AdorneeBoundingBox = setmetatable({}, BaseObject)
 AdorneeBoundingBox.ClassName = "AdorneeBoundingBox"
@@ -73,7 +73,7 @@ export type BoundingBoxData = {
 	Observes the bounding box of the adornee
 	@return Observable<BoundingBoxData>
 ]=]
-function AdorneeBoundingBox.ObserveBoundingBox(self: AdorneeBoundingBox): _Observable.Observable<BoundingBoxData>
+function AdorneeBoundingBox.ObserveBoundingBox(self: AdorneeBoundingBox): Observable.Observable<BoundingBoxData>
 	return Rx.combineLatest({
 		CFrame = self:ObserveCFrame(),
 		Size = self:ObserveSize(),
@@ -106,7 +106,7 @@ end
 	Observes the cframe of the adornee
 	@return Observable<Vector3>
 ]=]
-function AdorneeBoundingBox.ObserveCFrame(self: AdorneeBoundingBox): _Observable.Observable<CFrame?>
+function AdorneeBoundingBox.ObserveCFrame(self: AdorneeBoundingBox): Observable.Observable<CFrame?>
 	return self._bbCFrame:Observe()
 end
 
@@ -122,7 +122,7 @@ end
 	Observes the size of the adornee
 	@return Observable<Vector3>
 ]=]
-function AdorneeBoundingBox.ObserveSize(self: AdorneeBoundingBox): _Observable.Observable<Vector3?>
+function AdorneeBoundingBox.ObserveSize(self: AdorneeBoundingBox): Observable.Observable<Vector3?>
 	return self._bbSize:Observe()
 end
 
@@ -198,13 +198,14 @@ function AdorneeBoundingBox._setupHumanoid(self: AdorneeBoundingBox, humanoid: H
 	local topMaid = Maid.new()
 
 	topMaid:GiveTask(RxInstanceUtils.observePropertyBrio(humanoid, "Parent", function(parent: Instance)
-		return parent:IsA("Model")
+		return parent and parent:IsA("Model")
 	end):Subscribe(function(brio)
 		if brio:IsDead() then
 			return
 		end
 
 		local maid, model = brio:ToMaidAndValue()
+		assert(typeof(model) == "Instance" and model:IsA("Model"), "Bad model")
 
 		maid:GiveTask(self:_setupModel(model))
 	end))
@@ -236,8 +237,8 @@ function AdorneeBoundingBox._setupAttachment(self: AdorneeBoundingBox, attachmen
 				else
 					return Rx.of(nil)
 				end
-			end),
-			RxBrioUtils.flattenToValueAndNil,
+			end) :: any,
+			RxBrioUtils.flattenToValueAndNil :: any,
 		})
 		:Subscribe(function(cframe)
 			self._bbCFrame.Value = cframe