Skip to content

Commit 8eed34b

Browse files
committed
fix: Add types to packages
1 parent 310ec2a commit 8eed34b

File tree

672 files changed

+13540
-8914
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

672 files changed

+13540
-8914
lines changed

docs/servicebag.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ something like this:
187187
```lua
188188
local OtherService = require("OtherService")
189189

190-
function ServiceName:Init(serviceBag)
190+
function ServiceName:Init(serviceBag: ServiceBag.ServiceBag)
191191
assert(not self._serviceBag, "Already initialized")
192192

193193
self._serviceBag = assert(serviceBag, "No serviceBag")

games/integration/modules/Client/Button/LookAtButtonsClient.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ function LookAtButtonsClient:_setupLocal()
4747
self:_stopTrackingPhysicalButton(physicalButton)
4848
end))
4949

50-
for _, physicalButton in pairs(self._gameBindersClient.PhysicalButton:GetAll()) do
50+
for _, physicalButton in self._gameBindersClient.PhysicalButton:GetAll() do
5151
self:_trackPhysicalButton(physicalButton)
5252
end
5353

games/integration/modules/Client/GameBindersClient.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ local require = require(script.Parent.loader).load(script)
66

77
local Binder = require("Binder")
88
local BinderProvider = require("BinderProvider")
9+
local _ServiceBag = require("ServiceBag")
910

10-
return BinderProvider.new(script.Name, function(self, serviceBag)
11+
return BinderProvider.new(script.Name, function(self, serviceBag: _ServiceBag.ServiceBag)
1112
self:Add(Binder.new("PhysicalButton", require("PhysicalButtonClient"), serviceBag))
1213
self:Add(Binder.new("LookAtButtons", require("LookAtButtonsClient"), serviceBag))
1314
end)

games/integration/modules/Client/GameServiceClient.lua

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44

55
local require = require(script.Parent.loader).load(script)
66

7+
local _ServiceBag = require("ServiceBag")
8+
79
local GameServiceClient = {}
810
GameServiceClient.ServiceName = "GameServiceClient"
911

10-
function GameServiceClient:Init(serviceBag)
12+
function GameServiceClient:Init(serviceBag: _ServiceBag.ServiceBag)
1113
self._serviceBag = assert(serviceBag, "No serviceBag")
1214

1315
-- External

games/integration/modules/Server/Button/PhysicalButton.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ function PhysicalButton.new(obj, serviceBag)
3232
return self
3333
end
3434

35-
function PhysicalButton:_handleRemoteEvent(player)
35+
function PhysicalButton:_handleRemoteEvent(player: Player)
3636
local humanoid = CharacterUtils.getAlivePlayerHumanoid(player)
3737
if not humanoid then
3838
return

games/integration/modules/Server/GameServiceServer.lua

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@
44

55
local require = require(script.Parent.loader).load(script)
66

7+
local _ServiceBag = require("ServiceBag")
8+
79
local GameServiceServer = {}
810

9-
function GameServiceServer:Init(serviceBag)
11+
function GameServiceServer:Init(serviceBag: _ServiceBag.ServiceBag)
1012
self._serviceBag = assert(serviceBag, "No serviceBag")
1113

1214
-- External

plugins/preview-plugin/src/modules/Server/PreviewFinder.lua

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
--!strict
12
--[=[
23
@class PreviewFinder
34
]=]
@@ -24,7 +25,7 @@ PreviewFinder.ClassName = "PreviewFinder"
2425
PreviewFinder.__index = PreviewFinder
2526

2627
function PreviewFinder.new(serviceBag)
27-
local self = setmetatable(BaseObject.new(), PreviewFinder)
28+
local self = setmetatable(BaseObject.new() :: any, PreviewFinder)
2829

2930
self._serviceBag = assert(serviceBag, "No serviceBag")
3031
self:_setup()
@@ -53,16 +54,15 @@ function PreviewFinder:_setupParent(parent)
5354
self:_handleChildRemoving(child)
5455
end))
5556

56-
for _, child in pairs(parent:GetDescendants()) do
57+
for _, child in parent:GetDescendants() do
5758
self:_handleChild(child)
5859
end
5960

6061
return maid
6162
end
6263

6364
function PreviewFinder:_observeAll(child)
64-
return RxInstanceUtils.observeDescendants(service)
65-
65+
return RxInstanceUtils.observeDescendants(child)
6666
end
6767

6868
function PreviewFinder:_handleChildRemoving()

0 commit comments

Comments
 (0)