fix(cli): resolve package-relative paths and pipe exit codes

Selene and moonwave run per-package via lerna, producing paths like
src/Shared/Foo.lua instead of src/acceltween/src/Shared/Foo.lua.
Parsers now extract the package name from the lerna prefix to build
repo-root-relative paths. Also fixes PIPESTATUS capture so linter
jobs actually fail on errors.

Author: Quenty

.github/workflows/linting.yml

@@ -47,7 +47,7 @@ jobs:
         run: |
           set +e
           npm run lint:luau 2>&1 | tee lint-output.txt
-          echo "exit_code=$?" >> "$GITHUB_OUTPUT"
+          echo "exit_code=${PIPESTATUS[0]}" >> "$GITHUB_OUTPUT"
           exit 0
         continue-on-error: true
 
@@ -77,7 +77,7 @@ jobs:
         run: |
           set +e
           npm run lint:stylua 2>&1 | tee lint-output.txt
-          echo "exit_code=$?" >> "$GITHUB_OUTPUT"
+          echo "exit_code=${PIPESTATUS[0]}" >> "$GITHUB_OUTPUT"
           exit 0
         continue-on-error: true
 
@@ -111,7 +111,7 @@ jobs:
         run: |
           set +e
           npm run lint:selene 2>&1 | tee lint-output.txt
-          echo "exit_code=$?" >> "$GITHUB_OUTPUT"
+          echo "exit_code=${PIPESTATUS[0]}" >> "$GITHUB_OUTPUT"
           exit 0
         continue-on-error: true
 
@@ -145,7 +145,7 @@ jobs:
         run: |
           set +e
           npm run lint:moonwave 2>&1 | tee lint-output.txt
-          echo "exit_code=$?" >> "$GITHUB_OUTPUT"
+          echo "exit_code=${PIPESTATUS[0]}" >> "$GITHUB_OUTPUT"
           exit 0
         continue-on-error: true
 

docs/conventions/git-workflow.md

@@ -58,22 +58,9 @@ PR descriptions are for reviewers and future readers browsing git history. They
 **Good** — says what changed from the user's perspective:
 
 ```
-Test and deploy results now appear on the GitHub Actions run summary
-page in addition to PR comments.
+Test and deploy results now appear on the GitHub Actions run summary page in addition to PR comments.
 
-Also reorganizes the GitHub reporter code into `reporting/github/`
-with shared formatting and a separate API module.
-```
-
-**Bad** — restates the diff:
-
-```
-- Add `GithubJobSummaryReporter` that writes batch test/deploy results
-  to `$GITHUB_STEP_SUMMARY`
-- Refactor GitHub reporter code into a `reporting/github/` subfolder
-  with shared formatting extracted into `formatting.ts`
-- Wire up the new reporter in `batch test`, `batch deploy`, and
-  `post-test-results` commands
+Also reorganizes the GitHub reporter code into `reporting/github/` with shared formatting and a separate API module.
 ```
 
 Keep descriptions to 1-3 sentences of plain prose. No markdown headers, checklists, or "generated by" badges. If a PR needs a long explanation, that's usually a sign it should be split up.

tools/nevermore-cli/src/utils/linting/parsers/moonwave-parser.test.ts

@@ -53,7 +53,7 @@ describe('parseMoonwaveOutput', () => {
     const result = parseMoonwaveOutput(input);
 
     expect(result).toHaveLength(1);
-    expect(result[0].file).toBe('src/foo.lua');
+    expect(result[0].file).toBe('src/acceltween/src/foo.lua');
   });
 
   it('skips the aborting summary line', () => {

tools/nevermore-cli/src/utils/linting/parsers/moonwave-parser.ts

@@ -31,11 +31,12 @@ function _stripAnsi(text: string): string {
 /**
  * Matches the severity header line.
  * Optional lerna prefix.
- * Group 1: severity (error, warning)
- * Group 2: message
+ * Group 1: lerna package name (e.g. "acceltween") or undefined
+ * Group 2: severity (error, warning)
+ * Group 3: message
  */
 const SEVERITY_PATTERN =
-  /^(?:@[\w-]+\/[\w-]+:\s+)?\s*(error|warning):\s*(.+)$/;
+  /^(?:@[\w-]+\/([\w-]+):\s+)?\s*(error|warning):\s*(.+)$/;
 
 /**
  * Matches the location line with the `┌─` marker.
@@ -47,9 +48,19 @@ const SEVERITY_PATTERN =
 const LOCATION_PATTERN =
   /^(?:@[\w-]+\/[\w-]+:\s+)?\s+┌─ (.+?):(\d+):(\d+)/;
 
+/** Resolve a package-relative path to a repo-root-relative path. */
+function _resolvePackagePath(
+  packageName: string | undefined,
+  filePath: string
+): string {
+  if (!packageName) return filePath;
+  return `src/${packageName}/${filePath}`;
+}
+
 interface PendingDiagnostic {
   severity: DiagnosticSeverity;
   message: string;
+  packageName: string | undefined;
 }
 
 export function parseMoonwaveOutput(raw: string): Diagnostic[] {
@@ -66,10 +77,11 @@ export function parseMoonwaveOutput(raw: string): Diagnostic[] {
     // Try to match a severity header
     const sevMatch = line.match(SEVERITY_PATTERN);
     if (sevMatch) {
-      const [, severity, message] = sevMatch;
+      const [, packageName, severity, message] = sevMatch;
       pending = {
         severity: severity as DiagnosticSeverity,
         message: message.trim(),
+        packageName,
       };
       continue;
     }
@@ -78,7 +90,8 @@ export function parseMoonwaveOutput(raw: string): Diagnostic[] {
     if (pending) {
       const locMatch = line.match(LOCATION_PATTERN);
       if (locMatch) {
-        const [, file, lineStr, colStr] = locMatch;
+        const [, rawFile, lineStr, colStr] = locMatch;
+        const file = _resolvePackagePath(pending.packageName, rawFile);
         diagnostics.push({
           file,
           line: parseInt(lineStr, 10),

tools/nevermore-cli/src/utils/linting/parsers/selene-parser.test.ts

@@ -52,7 +52,7 @@ describe('parseSeleneOutput', () => {
     const result = parseSeleneOutput(input);
 
     expect(result).toHaveLength(1);
-    expect(result[0].file).toBe('src/foo.lua');
+    expect(result[0].file).toBe('src/acceltween/src/foo.lua');
     expect(result[0].severity).toBe('warning');
   });
 

tools/nevermore-cli/src/utils/linting/parsers/selene-parser.ts

@@ -25,12 +25,13 @@ import { type Diagnostic, type DiagnosticSeverity } from '@quenty/cli-output-hel
 /**
  * Matches the severity header line.
  * Optional lerna prefix: `@scope/pkg: `
- * Group 1: severity (error, warning)
- * Group 2: rule name
- * Group 3: message
+ * Group 1: lerna package name (e.g. "acceltween") or undefined
+ * Group 2: severity (error, warning)
+ * Group 3: rule name
+ * Group 4: message
  */
 const SEVERITY_PATTERN =
-  /^(?:@[\w-]+\/[\w-]+:\s+)?(error|warning)\[(\w+)\]: (.+)$/;
+  /^(?:@[\w-]+\/([\w-]+):\s+)?(error|warning)\[(\w+)\]: (.+)$/;
 
 /**
  * Matches the location line with the `┌─` marker.
@@ -42,10 +43,20 @@ const SEVERITY_PATTERN =
 const LOCATION_PATTERN =
   /^(?:@[\w-]+\/[\w-]+:\s+)?\s+┌─ (.+?):(\d+):(\d+)/;
 
+/** Resolve a package-relative path to a repo-root-relative path. */
+function _resolvePackagePath(
+  packageName: string | undefined,
+  filePath: string
+): string {
+  if (!packageName) return filePath;
+  return `src/${packageName}/${filePath}`;
+}
+
 interface PendingDiagnostic {
   severity: DiagnosticSeverity;
   rule: string;
   message: string;
+  packageName: string | undefined;
 }
 
 export function parseSeleneOutput(raw: string): Diagnostic[] {
@@ -57,11 +68,12 @@ export function parseSeleneOutput(raw: string): Diagnostic[] {
     // Try to match a severity header
     const sevMatch = line.match(SEVERITY_PATTERN);
     if (sevMatch) {
-      const [, severity, rule, message] = sevMatch;
+      const [, packageName, severity, rule, message] = sevMatch;
       pending = {
         severity: severity as DiagnosticSeverity,
         rule,
         message,
+        packageName,
       };
       continue;
     }
@@ -70,7 +82,8 @@ export function parseSeleneOutput(raw: string): Diagnostic[] {
     if (pending) {
       const locMatch = line.match(LOCATION_PATTERN);
       if (locMatch) {
-        const [, file, lineStr, colStr] = locMatch;
+        const [, rawFile, lineStr, colStr] = locMatch;
+        const file = _resolvePackagePath(pending.packageName, rawFile);
         diagnostics.push({
           file,
           line: parseInt(lineStr, 10),