Skip to content

Commit 8da329f

Browse files
committed
fix: rename to adbc_scanner
1 parent 14e890b commit 8da329f

File tree

7 files changed

+15
-15
lines changed

7 files changed

+15
-15
lines changed

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ Tests are written as [SQLLogicTests](https://duckdb.org/dev/sqllogictest/intro.h
119119

120120
- **Extension entry point**: `src/adbc_extension.cpp` - Registers all functions with DuckDB via `LoadInternal()`
121121
- **ADBC functions**: `src/adbc_functions.cpp` - Implements connection management, scanning, catalog, and execute functions
122-
- **Extension class**: `src/include/adbc_extension.hpp` - Defines `AdbcExtension` class inheriting from `duckdb::Extension`
122+
- **Extension class**: `src/include/adbc_scanner_extension.hpp` - Defines `AdbcScannerExtension` class inheriting from `duckdb::Extension`
123123
- **Configuration**: `extension_config.cmake` - Tells DuckDB build system to load this extension
124124
- **Dependencies**: `vcpkg.json` - Depends on `arrow-adbc` via vcpkg with custom overlay ports in `vcpkg-overlay/`
125125

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
cmake_minimum_required(VERSION 3.5)
22

33
# Set extension name here
4-
set(TARGET_NAME adbc)
4+
set(TARGET_NAME adbc_scanner)
55

66
find_package(tomlplusplus REQUIRED)
77
find_package(AdbcDriverManager CONFIG REQUIRED)
@@ -14,7 +14,7 @@ project(${TARGET_NAME})
1414
include_directories(src/include)
1515

1616
set(EXTENSION_SOURCES
17-
src/adbc_extension.cpp
17+
src/adbc_scanner_extension.cpp
1818
src/adbc_functions.cpp
1919
src/adbc_scan.cpp
2020
src/adbc_catalog.cpp

docs/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
# DuckDB ADBC Extension
1+
# DuckDB ADBC Scanner Extension
22

3-
The ADBC extension by [Query.Farm](https://query.farm) enables DuckDB to connect to external databases using [Arrow Database Connectivity (ADBC)](https://arrow.apache.org/adbc/), a column-oriented API standard for database access. ADBC provides efficient data transfer using Apache Arrow's columnar format.
3+
The ADBC Scanner extension by [Query.Farm](https://query.farm) enables DuckDB to connect to external databases using [Arrow Database Connectivity (ADBC)](https://arrow.apache.org/adbc/), a column-oriented API standard for database access. ADBC provides efficient data transfer using Apache Arrow's columnar format.
44

55
## Installation
66

77
```sql
8-
INSTALL adbc FROM community;
9-
LOAD adbc;
8+
INSTALL adbc_scanner FROM community;
9+
LOAD adbc_scanner;
1010
```
1111

1212
## Quick Start

extension_config.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This file is included by DuckDB's build system. It specifies which extension to load
22

33
# Extension from this repo
4-
duckdb_extension_load(adbc
4+
duckdb_extension_load(adbc_scanner
55
SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}
66
LOAD_TESTS
77
)
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#define DUCKDB_EXTENSION_MAIN
22

3-
#include "adbc_extension.hpp"
3+
#include "adbc_scanner_extension.hpp"
44
#include "adbc_functions.hpp"
55
#include "duckdb.hpp"
66
#include "duckdb/common/exception.hpp"
@@ -27,23 +27,23 @@ static void LoadInternal(ExtensionLoader &loader) {
2727
QueryFarmSendTelemetry(loader, "adbc", "2025120801");
2828
}
2929

30-
void AdbcExtension::Load(ExtensionLoader &loader) {
30+
void AdbcScannerExtension::Load(ExtensionLoader &loader) {
3131
LoadInternal(loader);
3232
}
3333

34-
std::string AdbcExtension::Name() {
34+
std::string AdbcScannerExtension::Name() {
3535
return "adbc";
3636
}
3737

38-
std::string AdbcExtension::Version() const {
38+
std::string AdbcScannerExtension::Version() const {
3939
return "2025120801";
4040
}
4141

4242
} // namespace duckdb
4343

4444
extern "C" {
4545

46-
DUCKDB_CPP_EXTENSION_ENTRY(adbc, loader) {
46+
DUCKDB_CPP_EXTENSION_ENTRY(adbc_scanner, loader) {
4747
duckdb::LoadInternal(loader);
4848
}
4949
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace duckdb {
66

7-
class AdbcExtension : public Extension {
7+
class AdbcScannerExtension : public Extension {
88
public:
99
void Load(ExtensionLoader &db) override;
1010
std::string Name() override;

test/sql/adbc.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ SELECT adbc_connect({'driver': 'test'});
99
Catalog Error: Scalar Function with name adbc_connect does not exist!
1010

1111
# Require statement will ensure this test is run with this extension loaded
12-
require adbc
12+
require adbc_scanner
1313

1414
# Test that adbc_connect requires 'driver' option (STRUCT syntax)
1515
statement error

0 commit comments

Comments
 (0)