fix: 1.4 specific changes

Author: rustyconover

.github/workflows/MainDistributionPipeline.yml

@@ -14,7 +14,7 @@ jobs:
     name: Build extension binaries
     uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
     with:
-      duckdb_version: main
+      duckdb_version: 1.4-andium
       ci_tools_version: main
       extension_name: adbc_scanner
       exclude_archs: wasm_mvp;wasm_eh;wasm_threads;

CMakeLists.txt

@@ -49,8 +49,8 @@ build_static_extension(${TARGET_NAME} ${EXTENSION_SOURCES})
 build_loadable_extension(${TARGET_NAME} " " ${EXTENSION_SOURCES})
 
 # Link dependencies in both the static library and the loadable extension
-target_link_libraries(${EXTENSION_NAME} AdbcDriverManager::adbc_driver_manager_static tomlplusplus::tomlplusplus nanoarrow::nanoarrow)
-target_link_libraries(${LOADABLE_EXTENSION_NAME} AdbcDriverManager::adbc_driver_manager_static tomlplusplus::tomlplusplus nanoarrow::nanoarrow)
+target_link_libraries(${EXTENSION_NAME} tomlplusplus::tomlplusplus nanoarrow::nanoarrow)
+target_link_libraries(${LOADABLE_EXTENSION_NAME} tomlplusplus::tomlplusplus nanoarrow::nanoarrow)
 
 # On Windows, when linking statically, we need to define ADBC_EXPORT as empty
 # to prevent __declspec(dllimport) from being used

duckdb

@@ -53,16 +53,16 @@ shared_ptr<AdbcConnectionWrapper> CreateConnectionFromOptions(const vector<pair<
 	database->Init();
 
 	// Enable manifest-based driver discovery by default
-	if (use_manifests) {
-		database->SetLoadFlags(ADBC_LOAD_FLAG_DEFAULT);
-	} else {
-		database->SetLoadFlags(ADBC_LOAD_FLAG_ALLOW_RELATIVE_PATHS);
-	}
+	// if (use_manifests) {
+	// 	database->SetLoadFlags(ADBC_LOAD_FLAG_DEFAULT);
+	// } else {
+	// 	database->SetLoadFlags(ADBC_LOAD_FLAG_ALLOW_RELATIVE_PATHS);
+	// }
 
 	// Set additional search paths if provided
-	if (!search_paths.empty()) {
-		database->SetAdditionalSearchPaths(search_paths);
-	}
+	// if (!search_paths.empty()) {
+	// 	database->SetAdditionalSearchPaths(search_paths);
+	// }
 
 	// Set driver (required)
 	database->SetOption("driver", driver);