fix: build error

Author: rustyconover

CMakeLists.txt

@@ -2,6 +2,9 @@ cmake_minimum_required(VERSION 3.5)
 
 # Set extension name here
 set(TARGET_NAME redis)
+set(CMAKE_CXX_STANDARD 17)
+set(CMAKE_CXX_STANDARD_REQUIRED 1)
+
 
 set(EXTENSION_NAME ${TARGET_NAME}_extension)
 set(LOADABLE_EXTENSION_NAME ${TARGET_NAME}_loadable_extension)

src/redis_extension.cpp

@@ -7,7 +7,7 @@
 #include "duckdb/parser/parsed_data/create_scalar_function_info.hpp"
 #include "duckdb/parser/parsed_data/create_table_function_info.hpp"
 #include "duckdb/function/table_function.hpp"
-
+#include "duckdb/main/extension/extension_loader.hpp"
 #include <boost/asio.hpp>
 #include <string>
 #include <mutex>
@@ -1023,4 +1023,8 @@ std::string RedisExtension::Version() const {
 
 } // namespace duckdb
 
-DUCKDB_CPP_EXTENSION_ENTRY(redis, duckdb::RedisExtension)
+extern "C" {
+DUCKDB_CPP_EXTENSION_ENTRY(redis, loader) {
+	duckdb::LoadInternal(loader);
+}
+}

src/redis_secret.cpp

@@ -1,67 +1,67 @@
 #include "redis_secret.hpp"
 #include "duckdb/common/exception.hpp"
 #include "duckdb/main/secret/secret.hpp"
-#include "duckdb/main/extension_loader.hpp"
+#include "duckdb/main/extension/extension_loader.hpp"
 
 namespace duckdb {
 
 static void CopySecret(const std::string &key, const CreateSecretInput &input, KeyValueSecret &result) {
-    auto val = input.options.find(key);
-    if (val != input.options.end()) {
-        result.secret_map[key] = val->second;
-    }
+	auto val = input.options.find(key);
+	if (val != input.options.end()) {
+		result.secret_map[key] = val->second;
+	}
 }
 
 static void RegisterCommonSecretParameters(CreateSecretFunction &function) {
-    // Register redis connection parameters
-    function.named_parameters["host"] = LogicalType::VARCHAR;
-    function.named_parameters["port"] = LogicalType::VARCHAR;
-    function.named_parameters["password"] = LogicalType::VARCHAR;
+	// Register redis connection parameters
+	function.named_parameters["host"] = LogicalType::VARCHAR;
+	function.named_parameters["port"] = LogicalType::VARCHAR;
+	function.named_parameters["password"] = LogicalType::VARCHAR;
 }
 
 static void RedactCommonKeys(KeyValueSecret &result) {
-    // Redact sensitive information
-    result.redact_keys.insert("password");
+	// Redact sensitive information
+	result.redact_keys.insert("password");
 }
 
 static unique_ptr<BaseSecret> CreateRedisSecretFromConfig(ClientContext &context, CreateSecretInput &input) {
-    auto scope = input.scope;
-    auto result = make_uniq<KeyValueSecret>(scope, input.type, input.provider, input.name);
+	auto scope = input.scope;
+	auto result = make_uniq<KeyValueSecret>(scope, input.type, input.provider, input.name);
 
-    // Copy all relevant secrets
-    CopySecret("host", input, *result);
-    CopySecret("port", input, *result);
-    CopySecret("password", input, *result);
+	// Copy all relevant secrets
+	CopySecret("host", input, *result);
+	CopySecret("port", input, *result);
+	CopySecret("password", input, *result);
 
-    // Redact sensitive keys
-    RedactCommonKeys(*result);
+	// Redact sensitive keys
+	RedactCommonKeys(*result);
 
-    return result;
+	return result;
 }
 
 static unique_ptr<BaseSecret> RedisSecretDeserialize(Deserializer &deserializer, BaseSecret base_secret) {
-    auto result = KeyValueSecret::Deserialize<KeyValueSecret>(deserializer, std::move(base_secret));
-    auto kv_secret = dynamic_cast<KeyValueSecret*>(result.get());
-    if (kv_secret) {
-        RedactCommonKeys(*kv_secret);
-    }
-    return result;
+	auto result = KeyValueSecret::Deserialize<KeyValueSecret>(deserializer, std::move(base_secret));
+	auto kv_secret = dynamic_cast<KeyValueSecret *>(result.get());
+	if (kv_secret) {
+		RedactCommonKeys(*kv_secret);
+	}
+	return result;
 }
 
 void CreateRedisSecretFunctions::Register(ExtensionLoader &loader) {
-    string type = "redis";
+	string type = "redis";
 
-    // Register the new type
-    SecretType secret_type;
-    secret_type.name = type;
-    secret_type.deserializer = RedisSecretDeserialize;
-    secret_type.default_provider = "config";
-    loader.RegisterSecretType(secret_type);
+	// Register the new type
+	SecretType secret_type;
+	secret_type.name = type;
+	secret_type.deserializer = RedisSecretDeserialize;
+	secret_type.default_provider = "config";
+	loader.RegisterSecretType(secret_type);
 
-    // Register the config secret provider
-    CreateSecretFunction config_function = {type, "config", CreateRedisSecretFromConfig};
-    RegisterCommonSecretParameters(config_function);
-    loader.RegisterFunction(config_function);
+	// Register the config secret provider
+	CreateSecretFunction config_function = {type, "config", CreateRedisSecretFromConfig};
+	RegisterCommonSecretParameters(config_function);
+	loader.RegisterFunction(config_function);
 }
 
-} // namespace duckdb 
+} // namespace duckdb