fix: add function docs

Author: rustyconover

duckdb

@@ -6,9 +6,9 @@ namespace duckdb {
 
 class TsidExtension : public Extension {
 public:
-	void Load(DuckDB &db) override;
+	void Load(ExtensionLoader &loader) override;
 	std::string Name() override;
-        std::string Version() const override;
+	std::string Version() const override;
 };
 
 } // namespace duckdb

src/include/tsid_extension.hpp

@@ -4,30 +4,18 @@
 #include "duckdb/common/exception.hpp"
 #include "duckdb/common/string_util.hpp"
 #include "duckdb/function/scalar_function.hpp"
-#include "duckdb/main/extension_util.hpp"
+#include "duckdb/main/extension/extension_loader.hpp"
 #include "duckdb/parser/parsed_data/create_scalar_function_info.hpp"
 #include "duckdb/common/exception/conversion_exception.hpp"
 #include "uutid.hpp"
 
 namespace duckdb {
 
-// Generate new TSID (with input parameter - ignored)
+// Generate new TSID
 static void TsidScalarFun(DataChunk &args, ExpressionState &state, Vector &result) {
     auto result_data = FlatVector::GetData<string_t>(result);
     auto &validity = FlatVector::Validity(result);
-    
-    for (idx_t i = 0; i < args.size(); i++) {
-        auto id = UUTID::new_id();
-        result_data[i] = StringVector::AddString(result, id.to_string());
-        validity.Set(i, true);
-    }
-}
 
-// Generate new TSID (no input parameter)
-static void TsidScalarFunNoArgs(DataChunk &args, ExpressionState &state, Vector &result) {
-    auto result_data = FlatVector::GetData<string_t>(result);
-    auto &validity = FlatVector::Validity(result);
-    
     for (idx_t i = 0; i < args.size(); i++) {
         auto id = UUTID::new_id();
         result_data[i] = StringVector::AddString(result, id.to_string());
@@ -52,32 +40,48 @@ static void TsidToTimestampScalarFun(DataChunk &args, ExpressionState &state, Ve
         });
 }
 
-static void LoadInternal(DatabaseInstance &instance) {
-    // Register tsid() functions
-    ScalarFunctionSet set("tsid");
-    
-    // Add variant with text parameter
-    ScalarFunction tsid_fun({LogicalType::VARCHAR}, LogicalType::VARCHAR, TsidScalarFun);
+static void LoadInternal(ExtensionLoader &loader) {
+    // Register tsid() function
+    ScalarFunction tsid_fun({}, LogicalType::VARCHAR, TsidScalarFun);
     tsid_fun.stability = FunctionStability::VOLATILE;
-    set.AddFunction(tsid_fun);
-    
-    // Add variant without parameters
-    ScalarFunction tsid_fun_no_args({}, LogicalType::VARCHAR, TsidScalarFunNoArgs);
-    tsid_fun_no_args.stability = FunctionStability::VOLATILE;
-    set.AddFunction(tsid_fun_no_args);
-    
-    ExtensionUtil::RegisterFunction(instance, set);
+
+    ScalarFunctionSet tsid_set("tsid");
+    tsid_set.AddFunction(tsid_fun);
+
+    CreateScalarFunctionInfo tsid_info(tsid_set);
+    FunctionDescription tsid_desc;
+    tsid_desc.description = "Generates a new Time-Sorted Unique Identifier (TSID). "
+                            "TSIDs are chronologically sortable 128-bit unique identifiers "
+                            "that embed a timestamp, making them ideal for distributed systems "
+                            "and time-series data.";
+    tsid_desc.examples = {"tsid()"};
+    tsid_desc.categories = {"uuid"};
+    tsid_info.descriptions.push_back(std::move(tsid_desc));
+
+    loader.RegisterFunction(std::move(tsid_info));
 
     // Register tsid_to_timestamp() function
-    auto tsid_to_timestamp_function = ScalarFunction(
-        "tsid_to_timestamp", {LogicalType::VARCHAR}, LogicalType::TIMESTAMP,
-        TsidToTimestampScalarFun
-    );
-    ExtensionUtil::RegisterFunction(instance, tsid_to_timestamp_function);
+    ScalarFunction tsid_to_ts_fun("tsid_to_timestamp", {LogicalType::VARCHAR}, LogicalType::TIMESTAMP,
+                                   TsidToTimestampScalarFun);
+
+    ScalarFunctionSet tsid_to_ts_set("tsid_to_timestamp");
+    tsid_to_ts_set.AddFunction(tsid_to_ts_fun);
+
+    CreateScalarFunctionInfo tsid_to_ts_info(tsid_to_ts_set);
+    FunctionDescription tsid_to_ts_desc;
+    tsid_to_ts_desc.parameter_names = {"tsid"};
+    tsid_to_ts_desc.parameter_types = {LogicalType::VARCHAR};
+    tsid_to_ts_desc.description = "Extracts the embedded timestamp from a TSID. "
+                                   "Returns the timestamp that was recorded when the TSID was generated.";
+    tsid_to_ts_desc.examples = {"tsid_to_timestamp('0193b9c8d23d7192bc1cc82b43e6e8f3')"};
+    tsid_to_ts_desc.categories = {"uuid"};
+    tsid_to_ts_info.descriptions.push_back(std::move(tsid_to_ts_desc));
+
+    loader.RegisterFunction(std::move(tsid_to_ts_info));
 }
 
-void TsidExtension::Load(DuckDB &db) {
-    LoadInternal(*db.instance);
+void TsidExtension::Load(ExtensionLoader &loader) {
+    LoadInternal(loader);
 }
 
 std::string TsidExtension::Name() {
@@ -96,13 +100,8 @@ std::string TsidExtension::Version() const {
 
 extern "C" {
 
-DUCKDB_EXTENSION_API void tsid_init(duckdb::DatabaseInstance &db) {
-    duckdb::DuckDB db_wrapper(db);
-    db_wrapper.LoadExtension<duckdb::TsidExtension>();
-}
-
-DUCKDB_EXTENSION_API const char *tsid_version() {
-    return duckdb::DuckDB::LibraryVersion();
+DUCKDB_CPP_EXTENSION_ENTRY(tsid, loader) {
+    duckdb::LoadInternal(loader);
 }
 
 }

src/tsid_extension.cpp

@@ -4,7 +4,7 @@
 
 # Before we load the extension, this will fail
 statement error
-SELECT tsid('Sam');
+SELECT tsid();
 ----
 Catalog Error: Scalar Function with name tsid does not exist!
 
@@ -14,19 +14,19 @@ require tsid
 # Test TSID generation
 # Verify it generates a valid hex string of correct length (32 chars)
 query I
-SELECT length(tsid('any')) = 32;
+SELECT length(tsid()) = 32;
 ----
 true
 
 # Verify hex format (all characters are valid hex)
 query I
-SELECT tsid('any') ~ '^[0-9a-f]{32}$';
+SELECT tsid() ~ '^[0-9a-f]{32}$';
 ----
 true
 
 # Test timestamp extraction
 query I
-SELECT tsid_to_timestamp(tsid('any')) IS NOT NULL;
+SELECT tsid_to_timestamp(tsid()) IS NOT NULL;
 ----
 true
 
@@ -38,13 +38,13 @@ Invalid TSID format
 
 # Verify timestamp is recent
 query I
-SELECT tsid_to_timestamp(tsid('any')) >= '2024-01-01';
+SELECT tsid_to_timestamp(tsid()) >= '2024-01-01';
 ----
 true
 
 # Test basic bulk operation
 query I
 SELECT COUNT(*)
-FROM (SELECT tsid('any') FROM range(10)) t;
+FROM (SELECT tsid() FROM range(10)) t;
 ----
 10