Skip to content

Commit ecbba5e

Browse files
committed
Merge branch 'xcode7.1'
2 parents f668b08 + 9e2be24 commit ecbba5e

File tree

9 files changed

+516
-36
lines changed

9 files changed

+516
-36
lines changed

CONTRIBUTING.md

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,15 @@ it.
3333
- Went to the kitchen, only to forget why you went in the first place?
3434
Better submit an issue.
3535

36+
Be sure to include in your issue:
37+
38+
- Your Xcode version (eg - Xcode 7.0.1 7A1001)
39+
- Your version of Nimble (eg - v2.0.0 or git sha `20a3f3b4e63cc8d97c92c4164bf36f2a2c9a6e1b`)
40+
- What are the steps to reproduce this issue?
41+
3642
## Building the Project
3743

38-
- Use `Nimble.xcproj` to work on Nimble.
44+
- Use `Nimble.xcodeproj` to work on Nimble.
3945

4046
## Pull Requests
4147

@@ -51,10 +57,8 @@ it.
5157
tests using `./test`.
5258
- If you've added a file to the project, make sure it's included in both
5359
the OS X and iOS targets.
54-
- To make minor updates to old versions of Nimble that support Swift
55-
1.1, issue a pull request against the `swift-1.1` branch. The master
56-
branch supports Swift 1.2. Travis CI will only pass for pull requests
57-
issued against the `swift-1.1` branch.
60+
- The `master` branch will always support the stable Xcode version. Other
61+
branches will point to their corresponding versions they support.
5862
- If you're making a configuration change, make sure to edit both the xcode
5963
project and the podspec file.
6064

@@ -95,7 +99,7 @@ some "ground rules":
9599

96100
The process is relatively straight forward, but here's is a useful checklist for tagging:
97101

98-
- Look a changes from the previously tagged release and write release notes: `git log v0.4.0...HEAD`
102+
- Look at changes from the previously tagged release and write release notes: `git log v0.4.0...HEAD`
99103
- Run the release script: `./script/release A.B.C release-notes-file`
100104
- Go to [github releases](https://github.com/Quick/Nimble/releases) and mark the tagged commit as a release.
101105
- Use the same release notes you created for the tag, but tweak up formatting for github.

Nimble.xcodeproj/project.pbxproj

Lines changed: 389 additions & 12 deletions
Large diffs are not rendered by default.

Nimble.xcodeproj/xcshareddata/xcschemes/Nimble-OSX.xcscheme

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0700"
3+
LastUpgradeVersion = "0710"
44
version = "2.0">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -23,10 +23,10 @@
2323
</BuildActionEntries>
2424
</BuildAction>
2525
<TestAction
26+
buildConfiguration = "Debug"
2627
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2728
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
28-
shouldUseLaunchSchemeArgsEnv = "YES"
29-
buildConfiguration = "Debug">
29+
shouldUseLaunchSchemeArgsEnv = "YES">
3030
<Testables>
3131
<TestableReference
3232
skipped = "NO">
@@ -43,11 +43,11 @@
4343
</AdditionalOptions>
4444
</TestAction>
4545
<LaunchAction
46+
buildConfiguration = "Debug"
4647
selectedDebuggerIdentifier = ""
4748
selectedLauncherIdentifier = "Xcode.IDEFoundation.Launcher.PosixSpawn"
4849
launchStyle = "0"
4950
useCustomWorkingDirectory = "NO"
50-
buildConfiguration = "Debug"
5151
ignoresPersistentStateOnLaunch = "NO"
5252
debugDocumentVersioning = "YES"
5353
debugXPCServices = "NO"
@@ -66,10 +66,10 @@
6666
</AdditionalOptions>
6767
</LaunchAction>
6868
<ProfileAction
69+
buildConfiguration = "Release"
6970
shouldUseLaunchSchemeArgsEnv = "YES"
7071
savedToolIdentifier = ""
7172
useCustomWorkingDirectory = "NO"
72-
buildConfiguration = "Release"
7373
debugDocumentVersioning = "YES">
7474
</ProfileAction>
7575
<AnalyzeAction

Nimble.xcodeproj/xcshareddata/xcschemes/Nimble-iOS.xcscheme

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0700"
3+
LastUpgradeVersion = "0710"
44
version = "2.0">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -23,10 +23,10 @@
2323
</BuildActionEntries>
2424
</BuildAction>
2525
<TestAction
26+
buildConfiguration = "Debug"
2627
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2728
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
28-
shouldUseLaunchSchemeArgsEnv = "YES"
29-
buildConfiguration = "Debug">
29+
shouldUseLaunchSchemeArgsEnv = "YES">
3030
<Testables>
3131
<TestableReference
3232
skipped = "NO">
@@ -43,11 +43,11 @@
4343
</AdditionalOptions>
4444
</TestAction>
4545
<LaunchAction
46+
buildConfiguration = "Debug"
4647
selectedDebuggerIdentifier = ""
4748
selectedLauncherIdentifier = "Xcode.IDEFoundation.Launcher.PosixSpawn"
4849
launchStyle = "0"
4950
useCustomWorkingDirectory = "NO"
50-
buildConfiguration = "Debug"
5151
ignoresPersistentStateOnLaunch = "NO"
5252
debugDocumentVersioning = "YES"
5353
debugXPCServices = "NO"
@@ -66,10 +66,10 @@
6666
</AdditionalOptions>
6767
</LaunchAction>
6868
<ProfileAction
69+
buildConfiguration = "Release"
6970
shouldUseLaunchSchemeArgsEnv = "YES"
7071
savedToolIdentifier = ""
7172
useCustomWorkingDirectory = "NO"
72-
buildConfiguration = "Release"
7373
debugDocumentVersioning = "YES">
7474
</ProfileAction>
7575
<AnalyzeAction
Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<Scheme
3+
LastUpgradeVersion = "0710"
4+
version = "1.3">
5+
<BuildAction
6+
parallelizeBuildables = "YES"
7+
buildImplicitDependencies = "YES">
8+
<BuildActionEntries>
9+
<BuildActionEntry
10+
buildForTesting = "YES"
11+
buildForRunning = "YES"
12+
buildForProfiling = "YES"
13+
buildForArchiving = "YES"
14+
buildForAnalyzing = "YES">
15+
<BuildableReference
16+
BuildableIdentifier = "primary"
17+
BlueprintIdentifier = "1F5DF1541BDCA0CE00C3A531"
18+
BuildableName = "Nimble.framework"
19+
BlueprintName = "Nimble-tvOS"
20+
ReferencedContainer = "container:Nimble.xcodeproj">
21+
</BuildableReference>
22+
</BuildActionEntry>
23+
</BuildActionEntries>
24+
</BuildAction>
25+
<TestAction
26+
buildConfiguration = "Debug"
27+
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
28+
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
29+
shouldUseLaunchSchemeArgsEnv = "YES">
30+
<Testables>
31+
<TestableReference
32+
skipped = "NO">
33+
<BuildableReference
34+
BuildableIdentifier = "primary"
35+
BlueprintIdentifier = "1F5DF15D1BDCA0CE00C3A531"
36+
BuildableName = "NimbleTests.xctest"
37+
BlueprintName = "Nimble-tvOSTests"
38+
ReferencedContainer = "container:Nimble.xcodeproj">
39+
</BuildableReference>
40+
</TestableReference>
41+
</Testables>
42+
<MacroExpansion>
43+
<BuildableReference
44+
BuildableIdentifier = "primary"
45+
BlueprintIdentifier = "1F5DF1541BDCA0CE00C3A531"
46+
BuildableName = "Nimble.framework"
47+
BlueprintName = "Nimble-tvOS"
48+
ReferencedContainer = "container:Nimble.xcodeproj">
49+
</BuildableReference>
50+
</MacroExpansion>
51+
<AdditionalOptions>
52+
</AdditionalOptions>
53+
</TestAction>
54+
<LaunchAction
55+
buildConfiguration = "Debug"
56+
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
57+
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
58+
launchStyle = "0"
59+
useCustomWorkingDirectory = "NO"
60+
ignoresPersistentStateOnLaunch = "NO"
61+
debugDocumentVersioning = "YES"
62+
debugServiceExtension = "internal"
63+
allowLocationSimulation = "YES">
64+
<MacroExpansion>
65+
<BuildableReference
66+
BuildableIdentifier = "primary"
67+
BlueprintIdentifier = "1F5DF1541BDCA0CE00C3A531"
68+
BuildableName = "Nimble.framework"
69+
BlueprintName = "Nimble-tvOS"
70+
ReferencedContainer = "container:Nimble.xcodeproj">
71+
</BuildableReference>
72+
</MacroExpansion>
73+
<AdditionalOptions>
74+
</AdditionalOptions>
75+
</LaunchAction>
76+
<ProfileAction
77+
buildConfiguration = "Release"
78+
shouldUseLaunchSchemeArgsEnv = "YES"
79+
savedToolIdentifier = ""
80+
useCustomWorkingDirectory = "NO"
81+
debugDocumentVersioning = "YES">
82+
<MacroExpansion>
83+
<BuildableReference
84+
BuildableIdentifier = "primary"
85+
BlueprintIdentifier = "1F5DF1541BDCA0CE00C3A531"
86+
BuildableName = "Nimble.framework"
87+
BlueprintName = "Nimble-tvOS"
88+
ReferencedContainer = "container:Nimble.xcodeproj">
89+
</BuildableReference>
90+
</MacroExpansion>
91+
</ProfileAction>
92+
<AnalyzeAction
93+
buildConfiguration = "Debug">
94+
</AnalyzeAction>
95+
<ArchiveAction
96+
buildConfiguration = "Release"
97+
revealArchiveInOrganizer = "YES">
98+
</ArchiveAction>
99+
</Scheme>

Nimble/Info.plist

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<key>CFBundleExecutable</key>
88
<string>${EXECUTABLE_NAME}</string>
99
<key>CFBundleIdentifier</key>
10-
<string>net.jeffhui.${PRODUCT_NAME:rfc1034identifier}</string>
10+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1111
<key>CFBundleInfoDictionaryVersion</key>
1212
<string>6.0</string>
1313
<key>CFBundleName</key>
@@ -20,9 +20,9 @@
2020
<string>????</string>
2121
<key>CFBundleVersion</key>
2222
<string>${CURRENT_PROJECT_VERSION}</string>
23-
<key>NSPrincipalClass</key>
24-
<string></string>
2523
<key>NSHumanReadableCopyright</key>
2624
<string>Copyright © 2014 Jeff Hui. All rights reserved.</string>
25+
<key>NSPrincipalClass</key>
26+
<string></string>
2727
</dict>
2828
</plist>

Nimble/Nimble.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#import <Foundation/Foundation.h>
2-
#import <Nimble/NMBExceptionCapture.h>
3-
#import <Nimble/DSL.h>
2+
#import "NMBExceptionCapture.h"
3+
#import "DSL.h"
44

55
FOUNDATION_EXPORT double NimbleVersionNumber;
6-
FOUNDATION_EXPORT const unsigned char NimbleVersionString[];
6+
FOUNDATION_EXPORT const unsigned char NimbleVersionString[];

NimbleTests/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<key>CFBundleExecutable</key>
88
<string>${EXECUTABLE_NAME}</string>
99
<key>CFBundleIdentifier</key>
10-
<string>net.jeffhui.${PRODUCT_NAME:rfc1034identifier}</string>
10+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1111
<key>CFBundleInfoDictionaryVersion</key>
1212
<string>6.0</string>
1313
<key>CFBundleName</key>

script/release

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ fi
8080
if [ ! -f "$RELEASE_NOTES" ]; then
8181
echo " > Failed to find $RELEASE_NOTES. Prompting editor"
8282
RELEASE_NOTES=.release-changes
83-
LATEST_TAG=`git for-each-ref refs/tags --sort=-refname --format="%(refname:short)" | grep 'v\\?\\d\\+\\.\\d\\+\\.\\d\\+' | ruby -e 'puts STDIN.read.split("\n").sort { |a,b| a.gsub("v", "").split(".").map(&:to_i) <=> b.gsub("v", "").split(".").map(&:to_i) }.last'`
83+
LATEST_TAG=`git for-each-ref refs/tags --sort=-refname --format="%(refname:short)" | grep -E "^v\d+\.\d+\.\d+(-\w+(\.\d)?)?\$" | ruby -e 'puts STDIN.read.split("\n").sort { |a,b| Gem::Version.new(a.gsub(/^v/, "")) <=> Gem::Version.new(b.gsub(/^v/, "")) }.last'`
8484
echo " > Latest tag ${LATEST_TAG}"
8585
echo "${POD_NAME} v$VERSION" > $RELEASE_NOTES
8686
echo "================" >> $RELEASE_NOTES

0 commit comments

Comments
 (0)