cleanup up warnings

Author: a2800276

Rakefile

@@ -84,7 +84,6 @@ spec = Gem::Specification.new do |s|
   s.requirements << "none"
   s.require_path = "lib"
   s.description = LONG_DESC
-  s.has_rdoc = true
   s.authors = ["Tim Becker", "Slava Kravchenko"]
   s.email = ["tim.becker@kuriositaet.de","cordawyn@gmail.com"]
   s.homepage = "http://github.com/a2800276/8583/"
@@ -125,7 +124,7 @@ end
 Rake::TestTask.new do |t|
   t.libs << "test"
   t.libs << "."
-  t.ruby_opts = ["-rubygems"]
+  t.ruby_opts = ["-rrubygems"]
   t.test_files = FileList["test/*.rb"]
   t.verbose = true
 end

iso8583.gemspec

@@ -17,7 +17,6 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = ">= 1.3.6"
   s.required_ruby_version     = ">= 1.9"
   s.rubyforge_project         = "iso8583"
-  s.has_rdoc                  = true
 
   s.requirements << "none"
 

lib/iso8583/berlin.rb

@@ -72,7 +72,7 @@ class BerlinMessage < Message
   mes[2] = 474747474747
   mes["Processing Code"] = "123456"
 
-  pan = mes["Primary Account Number (PAN)"]
+  #pan = mes["Primary Account Number (PAN)"]
   #mes.pan = 47474747474747
 
   #puts mes.pan

lib/iso8583/codec.rb

@@ -113,7 +113,7 @@ def encode(value)
     [val].pack("H*")
   }
   Packed_Number.decoder = lambda{|encoded|
-    d = encoded.unpack("H*")[0].to_i
+    encoded.unpack("H*")[0].to_i
   }
 
   A_Codec = Codec.new

lib/iso8583/fields.rb

@@ -57,63 +57,75 @@ module ISO8583
   }
 
   LL_BCD        = BCDField.new
+  LL_BCD.name   = "LL_BCD"
   LL_BCD.length = 2
   LL_BCD.codec  = Packed_Number
 
   # Two byte variable length ASCII numeral, payload ASCII numerals
   LLVAR_N        = Field.new
+  LLVAR_N.name   = "LLVAR_N"
   LLVAR_N.length = LL
   LLVAR_N.codec  = ASCII_Number
 
   # Three byte variable length ASCII numeral, payload ASCII numerals
   LLLVAR_N        = Field.new
+  LLLVAR_N.name   = "LLLVAR_N"
   LLLVAR_N.length = LLL
   LLLVAR_N.codec  = ASCII_Number
 
   # Two byte variable length ASCII numeral, payload Track2 data
   LLVAR_Z         = Field.new
+  LLVAR_Z.name    = "LLVAR_Z"
   LLVAR_Z.length  = LL
   LLVAR_Z.codec   = Track2
 
   # Two byte variable length ASCII numeral, payload ASCII, fixed length, zeropadded (right)
   LLVAR_AN        = Field.new
+  LLVAR_AN.name   = "LLVAR_AN"
   LLVAR_AN.length = LL
   LLVAR_AN.codec  = AN_Codec
 
   # Two byte variable length ASCII numeral, payload ASCII+special
   LLVAR_ANS        = Field.new
+  LLVAR_ANS.name   = "LLVAR_ANS"
   LLVAR_ANS.length = LL
   LLVAR_ANS.codec  = ANS_Codec
 
   # Three byte variable length ASCII numeral, payload ASCII, fixed length, zeropadded (right)
   LLLVAR_AN        = Field.new
+  LLLVAR_AN.name   = "LLLVAR_AN"
   LLLVAR_AN.length = LLL
   LLLVAR_AN.codec  = AN_Codec
 
   # Three byte variable length ASCII numeral, payload ASCII+special
   LLLVAR_ANS        = Field.new
+  LLLVAR_ANS.name   = "LLLVAR_ANS"
   LLLVAR_ANS.length = LLL
   LLLVAR_ANS.codec  = ANS_Codec
 
   # Two byte variable length binary payload
   LLVAR_B        = Field.new
+  LLVAR_B.name   = "LLVAR_B"
   LLVAR_B.length = LL
   LLVAR_B.codec  = Null_Codec
 
 
   # Three byte variable length binary payload
   LLLVAR_B        = Field.new
+  LLLVAR_B.name   = "LLLVAR_B"
   LLLVAR_B.length = LLL
   LLLVAR_B.codec  = Null_Codec
 
   # Fixed lengh numerals, repesented in ASCII, padding right justified using zeros
   N = Field.new
+  N.name  = "N"
   N.codec = ASCII_Number
   N.padding = lambda {|val, len|
     sprintf("%0#{len}d", val)
   }
 
   N_BCD = BCDField.new
+  N_BCD.name  = "N_BCD"
   N_BCD.codec = Packed_Number
 
   PADDING_LEFT_JUSTIFIED_SPACES = lambda {|val, len|
@@ -122,25 +134,30 @@ module ISO8583
 
   # Fixed length ASCII letters [A-Za-z]
   A = Field.new
+  A.name  = "A"
   A.codec = A_Codec
 
   # Fixed lengh ASCII [A-Za-z0-9], padding left justified using spaces.
   AN = Field.new
+  AN.name  = "AN"
   AN.codec = AN_Codec
   AN.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Fixed lengh ASCII [A-Za-z0-9] and space, padding left, spaces
   ANP = Field.new
+  ANP.name  = "ANP"
   ANP.codec = ANP_Codec
   ANP.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Fixed length ASCII  [\x20-\x7E], padding left, spaces
   ANS = Field.new
+  ANS.name = ANS
   ANS.codec = ANS_Codec
   ANS.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Binary data, padding left using nulls (0x00)
   B = Field.new
+  B.name  = "B"
   B.codec = Null_Codec
   B.padding = lambda {|val, len|
     while val.length < len
@@ -151,24 +168,29 @@ module ISO8583
 
   # Date, formatted as described in ASCII numerals
   MMDDhhmmss        = Field.new
+  MMDDhhmmss.name   = "MMDDhhmmss"
   MMDDhhmmss.codec  = MMDDhhmmssCodec
   MMDDhhmmss.length = 10
 
   #Date, formatted as described in ASCII numerals
   YYMMDDhhmmss        = Field.new
+  YYMMDDhhmmss.name   = "YYMMDDhhmmss"
   YYMMDDhhmmss.codec  = YYMMDDhhmmssCodec
   YYMMDDhhmmss.length = 12
 
   #Date, formatted as described in ASCII numerals
   YYMM        = Field.new
+  YYMM.name   = "YYMM"
   YYMM.codec  = YYMMCodec
   YYMM.length = 4
 
   MMDD        = Field.new
+  MMDD.name   = "MMDD"
   MMDD.codec  = MMDDCodec
   MMDD.length = 4
 
   Hhmmss        = Field.new
+  Hhmmss.name   = "Hhmmss"
   Hhmmss.codec  = HhmmssCodec
   Hhmmss.length = 6
 

lib/iso8583/message.rb

@@ -135,7 +135,7 @@ def initialize(mti = nil)
     #    mes = MyMessage.new
     #    mes.mti = 1100 # or mes.mti = "Authorization Request Acquirer Gateway"
     def mti=(value)
-      num, name = _get_mti_definition(value)
+      num, _ = _get_mti_definition(value)
       @mti = num
     end
 

test/BitmapTests.rb

@@ -22,14 +22,14 @@ def test_create_empty
 
     assert_raises(ISO8583Exception) {b.set 1000 }
     assert_raises(ISO8583Exception) {	b.set 1 }
-    assert_raises(ISO8583Exception) {	b.set -1 }
+    assert_raises(ISO8583Exception) {	b.set(-1) }
   end
 
   def test_out_of_bounds_errors
     b = Bitmap.new
     assert_raises(ISO8583Exception) {b.set 1000 }
     assert_raises(ISO8583Exception) {	b.set 1 }
-    assert_raises(ISO8583Exception) {	b.set -1 }
+    assert_raises(ISO8583Exception) {	b.set(-1) }
   end
 
   def test_parse_bmp
@@ -82,7 +82,7 @@ def test_each_w_two_bitmaps_doesnt_yield_first_field
     tst = "\x80\x00\x10\x20\x40\x81\x02\x04\x08\x10\x20\x40\x81\x02\x04\x08"
     bmp = Bitmap.new tst
     arr = []
-    first = bmp.each{|bit|
+    bmp.each{|bit|
       arr.push bit
     }
     assert_equal 20, arr.first

test/message_test.rb

@@ -38,7 +38,7 @@ def test_parse
     pan = 474747474747
 
     assert_raises(ISO8583Exception) {
-      mes = BerlinMessage.parse "@\000\000\000\000\000\000\00012474747474747"
+      BerlinMessage.parse "@\000\000\000\000\000\000\00012474747474747"
     }
     mes = BerlinMessage.parse "1430@\000\000\000\000\000\000\00012474747474747"
     assert_equal pan, mes.pan
@@ -50,6 +50,7 @@ def test_rescue_standard_error
     begin
       BerlinMessage.parse("bogus")
     rescue => error
+      assert_instance_of ISO8583Exception, error
       rescued = true
     end
 
@@ -168,8 +169,8 @@ def test_round_trip
     mes[64] = "\xF0\xF0\xF0\xF0"
 
     bytes = mes.to_b
-    mes2 = BerlinMessage.parse(mes.to_b)
-    assert_equal(mes.to_b, mes2.to_b)
+    mes2 = BerlinMessage.parse(bytes)
+    assert_equal(bytes, mes2.to_b)
   end
 
   def test_remove_field

test/test_codec.rb

@@ -101,26 +101,26 @@ def test_YMMCodec
   end
   def test_A_Codec
     assert_raise(ISO8583Exception) {
-      dt = A_Codec.encode "!!!"
+      A_Codec.encode "!!!"
     }
     assert_equal "bla", AN_Codec.encode("bla")
     assert_equal "bla", AN_Codec.decode("bla")
   end
 
   def test_AN_Codec
     assert_raise(ISO8583Exception) {
-      dt = AN_Codec.encode "!!!"
+      AN_Codec.encode "!!!"
     }
     assert_equal "bla", AN_Codec.encode("bla")
     assert_equal "bla", AN_Codec.decode("bla")
   end
 
   def test_Track2_Codec
     assert_raise(ISO8583Exception) {
-      dt = Track2.encode "!!!"
+      Track2.encode "!!!"
     }
     assert_raise(ISO8583Exception) {
-      dt = Track2.encode ";12312312=123?5"
+      Track2.encode ";12312312=123?5"
     }
     assert_equal ";123123123=123?5", Track2.encode(";123123123=123?5")
     assert_equal ";123123123=123?5", Track2.decode(";123123123=123?5")
@@ -133,10 +133,10 @@ def test_packed_codec
     assert_equal "\x02", Packed_Number.encode(2)
     assert_equal "\x02\x55", Packed_Number.encode(0xff)
     assert_raise(ISO8583Exception) {
-      dt = Packed_Number.encode ";12312312=123?5"
+      Packed_Number.encode ";12312312=123?5"
     }
     assert_raise(ISO8583Exception) {
-      dt = Packed_Number.encode "F"
+      Packed_Number.encode "F"
     }
   end
 
@@ -145,7 +145,7 @@ def test_BE_U16
       BE_U16.encode 2**16
     }
     assert_raise(ISO8583Exception) {
-      BE_U16.encode -1
+      BE_U16.encode(-1)
     }
     assert_equal "\0\0", BE_U16.encode(0)
     expected = "\xff\xff".force_encoding('ASCII-8BIT')
@@ -164,7 +164,7 @@ def test_BE_U32
       BE_U32.encode 2**32
     }
     assert_raise(ISO8583Exception) {
-      BE_U32.encode -1
+      BE_U32.encode(-1)
     }
     assert_equal "\0\0\0\0", BE_U32.encode(0)
     expected = "\xff\xff\xff\xff".force_encoding('ASCII-8BIT')

test/test_fields.rb

@@ -10,7 +10,7 @@ def test_LLL
     assert_equal "456", rest
 
     assert_raise(ISO8583ParseException) {
-      l,rest = LLL.parse "12"
+      _,rest = LLL.parse "12"
     }
 
     enc = LLL.encode 123
@@ -50,10 +50,10 @@ def test_LLVAR_AN
     assert_equal "123ABC", value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLLVAR_AN.parse "12"
+      _,rest = LLLVAR_AN.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_AN.parse "12123"
+      _,rest = LLVAR_AN.parse "12123"
     }
 
     enc = LLVAR_AN.encode "123A"
@@ -83,10 +83,10 @@ def test_LLVAR_N
     assert_equal 1234, value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLLVAR_N.parse "12"
+      _,rest = LLLVAR_N.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_N.parse "12123"
+      _,rest = LLVAR_N.parse "12123"
     }
 
     enc = LLVAR_N.encode 1234
@@ -116,10 +116,10 @@ def test_LLVAR_Z
     assert_equal ";123123123=123?5", value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_Z.parse "12"
+      _,rest = LLVAR_Z.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_Z.parse "17;123123123=123?5"
+      _,rest = LLVAR_Z.parse "17;123123123=123?5"
     }
 
     enc = LLVAR_Z.encode ";123123123=123?5"
@@ -213,6 +213,7 @@ def test_N_BCD
     fld.length=3
     value, rest = fld.parse "\x01\x23\x45"
     assert_equal 123, value
+    assert_equal "\x45", rest
 
     assert_equal "\x01\x23", fld.encode(123)
     assert_equal "\x01\x23", fld.encode("123")
@@ -241,6 +242,7 @@ def test_Hhmmss
     assert_equal 12, dt.hour
     assert_equal 34, dt.min
     assert_equal 56, dt.sec
+    assert_equal "", rest
 
     assert_raise(ISO8583Exception) {
       fld.encode 1234567