try to fix the display issue

Author: Ghost-chu

quickshop-bukkit/src/main/java/com/ghostchu/quickshop/shop/ContainerShop.java

@@ -345,7 +345,6 @@ public void checkDisplay() {
         if (!displayStatus) {
             if (this.displayItem != null) {
                 this.displayItem.remove();
-                this.displayItem = null;
             }
             return;
         }

quickshop-bukkit/src/main/java/com/ghostchu/quickshop/shop/display/VirtualDisplayItem.java

@@ -54,8 +54,8 @@ public class VirtualDisplayItem extends AbstractDisplayItem implements Reloadabl
     //cache chunk x and z
     private SimpleShopChunk chunkLocation;
     //If packet initialized
-    private volatile boolean initialized = false;
-    private volatile boolean isSpawned = false;
+    private final AtomicBoolean initialized = new AtomicBoolean(false);
+    private final AtomicBoolean isSpawned = new AtomicBoolean(false);
     //packets
     private PacketContainer fakeItemSpawnPacket;
     private PacketContainer fakeItemMetaPacket;
@@ -100,7 +100,7 @@ public void fixDisplayNeedRegen() {
 
     @Override
     public boolean isSpawned() {
-        return isSpawned;
+        return isSpawned.get();
     }
 
     @Override
@@ -114,7 +114,7 @@ public void remove() {
         if (isSpawned()) {
             sendPacketToAll(fakeItemDestroyPacket);
             unload();
-            isSpawned = false;
+            isSpawned.set(false);
         }
     }
 
@@ -138,7 +138,7 @@ public void safeGuard(@Nullable Entity entity) {
     @Override
     public void spawn() {
         Util.ensureThread(false);
-        if (isSpawned || shop.isDeleted() || !shop.isLoaded()) {
+        if (isSpawned.get() || shop.isDeleted() || !shop.isLoaded()) {
             return;
         }
         if (new ShopDisplayItemSpawnEvent(shop, originalItemStack, DisplayType.VIRTUALITEM).callCancellableEvent()) {
@@ -148,7 +148,7 @@ public void spawn() {
         }
 
         //lazy initialize
-        if (!initialized) {
+        if (!initialized.get()) {
             initFakeDropItemPacket();
         }
 
@@ -162,15 +162,15 @@ public void spawn() {
         }*/
 
         sendFakeItemToAll();
-        isSpawned = true;
+        isSpawned.set(true);
     }
 
     private void initFakeDropItemPacket() {
         fakeItemSpawnPacket = PacketFactory.createFakeItemSpawnPacket(entityID, getDisplayLocation());
         fakeItemMetaPacket = PacketFactory.createFakeItemMetaPacket(entityID, getOriginalItemStack().clone());
         fakeItemVelocityPacket = PacketFactory.createFakeItemVelocityPacket(entityID);
         fakeItemDestroyPacket = PacketFactory.createFakeItemDestroyPacket(entityID);
-        initialized = true;
+        initialized.set(true);
     }
 
     //Due to the delay task in ChunkListener
@@ -198,6 +198,10 @@ public void sendFakeItem(@NotNull Player player) {
         sendPacket(player, fakeItemVelocityPacket);
     }
 
+    public void sendDestroyItem(@NotNull Player player) {
+        sendPacket(player, fakeItemDestroyPacket);
+    }
+
     private void sendPacket(@NotNull Player player, @NotNull PacketContainer packet) {
         PROTOCOL_MANAGER.sendServerPacket(player, packet);
     }
@@ -272,6 +276,7 @@ public void onPacketSending(@NotNull PacketEvent event) {
                                     continue;
                                 }
                                 target.packetSenders.add(player.getUniqueId());
+                                target.sendDestroyItem(player);
                                 target.sendFakeItem(player);
                             }
                             return targetList;