Add Number Test and fix false number bug

Author: QuickWrite

src/main/java/net/quickwrite/fluent4j/ast/FluentVariant.java

@@ -1,5 +1,6 @@
 package net.quickwrite.fluent4j.ast;
 
+import net.quickwrite.fluent4j.exception.FluentParseException;
 import net.quickwrite.fluent4j.util.args.FluentArgs;
 import net.quickwrite.fluent4j.util.bundle.DirectFluentBundle;
 import net.quickwrite.fluent4j.ast.placeable.NumberLiteral;
@@ -21,14 +22,18 @@ public class FluentVariant implements FluentElement {
     private final FluentPlaceable identifier;
     private final FluentAttribute content;
 
-    public FluentVariant(FluentAttribute content) {
+    public FluentVariant(final FluentAttribute content) {
         this.identifier = getIdentifier(content.identifier);
         this.content = content;
     }
 
-    private FluentPlaceable getIdentifier(String slice) {
+    private FluentPlaceable getIdentifier(final String slice) {
         if (Character.isDigit(slice.charAt(0))) {
-            return NumberLiteral.getNumberLiteral(slice);
+            try {
+                return NumberLiteral.getNumberLiteral(slice);
+            } catch (final NumberFormatException ignored) {
+                throw new FluentParseException("Expected Number but got \"" + slice + "\"");
+            }
         }
 
         return new StringLiteral(slice);

src/main/java/net/quickwrite/fluent4j/util/StringSliceUtil.java

@@ -179,7 +179,12 @@ private static FluentPlaceable expressionGetDefault(final StringSlice slice) {
             if (isTerm)
                 slice.decrement();
 
-            return NumberLiteral.getNumberLiteral(getNumber(slice));
+            final StringSlice number = getNumber(slice);
+            try {
+                return NumberLiteral.getNumberLiteral(number);
+            } catch (final NumberFormatException ignored) {
+                throw new FluentParseException("Number", number.toString(), number.getPosition() - number.length());
+            }
         }
 
         final StringSlice msgIdentifier = getIdentifier(slice);

src/test/java/net/quickwrite/fluent4j/TestNumbers.java

@@ -0,0 +1,127 @@
+package net.quickwrite.fluent4j;
+
+import net.quickwrite.fluent4j.util.bundle.FluentBundle;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+
+import java.io.IOException;
+
+public class TestNumbers {
+    private FluentBundle bundle;
+
+    @Before
+    public void setUp() throws IOException {
+        this.bundle = GetFileHelper.getFluentBundle("numbers.ftl");
+    }
+
+    @Test
+    public void testIfExceptions() {
+        Assertions.assertTrue(bundle.hasExceptions());
+    }
+
+    @Test
+    public void testIntZero() {
+        Assertions.assertEquals("0", GetFileHelper.getMessage(bundle, "int-zero"));
+    }
+
+    @Test
+    public void testIntPositive() {
+        Assertions.assertEquals("1", GetFileHelper.getMessage(bundle, "int-positive"));
+    }
+
+    @Test
+    public void testIntNegative() {
+        Assertions.assertEquals("-1", GetFileHelper.getMessage(bundle, "int-negative"));
+    }
+
+    @Test
+    public void testIntNegativeZero() {
+        Assertions.assertEquals("0", GetFileHelper.getMessage(bundle, "int-negative-zero"));
+    }
+
+    @Test
+    public void testIntPositivePadded() {
+        Assertions.assertEquals("1", GetFileHelper.getMessage(bundle, "int-positive-padded"));
+    }
+
+    @Test
+    public void testIntNegativePadded() {
+        Assertions.assertEquals("-1", GetFileHelper.getMessage(bundle, "int-negative-padded"));
+    }
+
+    @Test
+    public void testIntZeroPadded() {
+        Assertions.assertEquals("0", GetFileHelper.getMessage(bundle, "int-zero-padded"));
+    }
+
+    @Test
+    public void testIntNegativeZeroPadded() {
+        Assertions.assertEquals("0", GetFileHelper.getMessage(bundle, "int-negative-zero-padded"));
+    }
+
+    @Test
+    public void testFloatZero() {
+        Assertions.assertEquals("0", GetFileHelper.getMessage(bundle, "float-zero"));
+    }
+
+    @Test
+    public void testFloatPositive() {
+        Assertions.assertEquals("0.01", GetFileHelper.getMessage(bundle, "float-positive"));
+    }
+
+    @Test
+    public void testFloatPositiveOne() {
+        Assertions.assertEquals("1.03", GetFileHelper.getMessage(bundle, "float-positive-one"));
+    }
+
+    @Test
+    public void testFloatPositiveWithoutFraction() {
+        Assertions.assertEquals("1", GetFileHelper.getMessage(bundle, "float-positive-without-fraction"));
+    }
+
+    @Test
+    public void testFloatNegative() {
+        Assertions.assertEquals("-0.01", GetFileHelper.getMessage(bundle, "float-negative"));
+    }
+
+    @Test
+    public void testFloatNegativeOne() {
+        Assertions.assertEquals("-1.03", GetFileHelper.getMessage(bundle, "float-negative-one"));
+    }
+
+    @Test
+    public void testFloatNegativeWithoutFraction() {
+        Assertions.assertEquals("-1", GetFileHelper.getMessage(bundle, "float-negative-without-fraction"));
+    }
+
+    @Test
+    public void testFloatPositivePaddedLeft() {
+        Assertions.assertEquals("1.03", GetFileHelper.getMessage(bundle, "float-positive-padded-left"));
+    }
+
+    @Test
+    public void testFloatPositivePaddedRight() {
+        Assertions.assertEquals("1.03", GetFileHelper.getMessage(bundle, "float-positive-padded-right"));
+    }
+
+    @Test
+    public void testFloatPositivePaddedBoth() {
+        Assertions.assertEquals("1.03", GetFileHelper.getMessage(bundle, "float-positive-padded-both"));
+    }
+
+    @Test
+    public void testFloatNegativePaddedLeft() {
+        Assertions.assertEquals("-1.03", GetFileHelper.getMessage(bundle, "float-negative-padded-left"));
+    }
+
+    @Test
+    public void testFloatNegativePaddedRight() {
+        Assertions.assertEquals("-1.03", GetFileHelper.getMessage(bundle, "float-negative-padded-right"));
+    }
+
+    @Test
+    public void testFloatNegativePaddedBoth() {
+        Assertions.assertEquals("-1.03", GetFileHelper.getMessage(bundle, "float-negative-padded-both"));
+    }
+}