move FeaturesSection.enableClassTreeStatIcons to StatsSection

move FeaturesSection.autoSaveMappings to EditorConfig
eliminate FeaturesSection

Author: supersaiyansubtlety

enigma-swing/src/main/java/org/quiltmc/enigma/gui/GuiController.java

@@ -197,7 +197,7 @@ public void openMappings(EntryTree<EntryMapping> mappings) {
 	}
 
 	public void regenerateAndUpdateStatIcons() {
-		if (Config.main().features.enableClassTreeStatIcons.value()) {
+		if (Config.stats().enableClassTreeStatIcons.value()) {
 			ProgressListener progressListener = ProgressListener.createEmpty();
 			this.gui.getMainWindow().getStatusBar().syncWith(progressListener);
 
@@ -570,7 +570,7 @@ public void applyChange(ValidationContext vc, EntryChange<?> change, boolean upd
 			return;
 		}
 
-		if (autosave && Config.main().features.autoSaveMappings.value() && this.gui.mappingsFileChooser.getSelectedFile() != null) {
+		if (autosave && Config.editor().autoSaveMappings.value() && this.gui.mappingsFileChooser.getSelectedFile() != null) {
 			this.gui.getController().saveMappings(this.gui.mappingsFileChooser.getSelectedFile().toPath(), true);
 		}
 

enigma-swing/src/main/java/org/quiltmc/enigma/gui/config/Config.java

@@ -81,9 +81,6 @@ public final class Config extends ReflectiveConfig {
 	@Comment("The settings for the statistics window.")
 	public final StatsSection stats = new StatsSection();
 
-	@Comment("Contains all features that can be toggled on or off.")
-	public final FeaturesSection features = new FeaturesSection();
-
 	@Comment("You shouldn't enable options in this section unless you know what you're doing!")
 	public final DevSection development = new DevSection();
 

enigma-swing/src/main/java/org/quiltmc/enigma/gui/config/EditorConfig.java

@@ -8,6 +8,9 @@
 
 @SerializedNameConvention(NamingSchemes.SNAKE_CASE)
 public class EditorConfig extends ReflectiveConfig {
+	@Comment("Enables auto save functionality, which will automatically save mappings when a change is made.")
+	public final TrackedValue<Boolean> autoSaveMappings = this.value(false);
+
 	@Comment("Whether editors' quick find toolbars should remain visible when they lose focus.")
 	public final TrackedValue<Boolean> persistentQuickFind = this.value(true);
 

enigma-swing/src/main/java/org/quiltmc/enigma/gui/config/FeaturesSection.java

@@ -22,6 +22,9 @@ public class StatsSection extends ReflectiveConfig.Section {
 	public final TrackedValue<Boolean> shouldIncludeSyntheticParameters = this.value(false);
 	public final TrackedValue<Boolean> shouldCountFallbackNames = this.value(false);
 
+	@Comment("Enables statistic icons in the class tree. This has a major performance impact on JAR files with lots of classes.")
+	public final TrackedValue<Boolean> enableClassTreeStatIcons = this.value(true);
+
 	public Set<StatType> getIncludedTypesForIcons(Set<StatType> editableTypes) {
 		var types = new HashSet<>(editableTypes);
 		types.removeIf(type -> !this.includedStatTypes.value().contains(type));

enigma-swing/src/main/java/org/quiltmc/enigma/gui/config/StatsSection.java

@@ -90,7 +90,7 @@ String getDisplayName() {
 			JLabel nodeLabel = new JLabel(icon);
 			panel.add(nodeLabel);
 
-			if (Config.main().features.enableClassTreeStatIcons.value()) {
+			if (Config.stats().enableClassTreeStatIcons.value()) {
 				if (this.controller.getStatsGenerator() != null) {
 					ProjectStatsResult stats = this.controller.getStatsGenerator().getResultNullable(Config.stats().createIconGenParameters(this.controller.getGui().getEditableStatTypes()));
 					if (stats == null) {

enigma-swing/src/main/java/org/quiltmc/enigma/gui/element/ClassTreeCellRenderer.java

@@ -80,7 +80,7 @@ public FileMenu(Gui gui) {
 		this.jarCloseItem.addActionListener(e -> this.gui.getController().closeJar());
 		this.maxRecentFilesItem.addActionListener(e -> this.onMaxRecentFilesClicked());
 		this.saveMappingsItem.addActionListener(e -> this.onSaveMappingsClicked());
-		this.autoSaveMappingsItem.addActionListener(e -> Config.main().features.autoSaveMappings.setValue(this.autoSaveMappingsItem.getState()));
+		this.autoSaveMappingsItem.addActionListener(e -> Config.editor().autoSaveMappings.setValue(this.autoSaveMappingsItem.getState()));
 		this.closeMappingsItem.addActionListener(e -> this.onCloseMappingsClicked());
 		this.dropMappingsItem.addActionListener(e -> this.gui.getController().dropMappings());
 		this.reloadMappingsItem.addActionListener(e -> this.onReloadMappingsClicked());
@@ -109,7 +109,7 @@ public void updateState(boolean jarOpen, ConnectionState state) {
 		this.saveMappingsItem.setEnabled(jarOpen && this.gui.mappingsFileChooser.getSelectedFile() != null && this.gui.getConnectionState() != ConnectionState.CONNECTED);
 		this.saveMappingsAs.updateState();
 		this.autoSaveMappingsItem.setEnabled(jarOpen);
-		this.autoSaveMappingsItem.setState(Config.main().features.autoSaveMappings.value());
+		this.autoSaveMappingsItem.setState(Config.editor().autoSaveMappings.value());
 		this.closeMappingsItem.setEnabled(jarOpen);
 		this.reloadMappingsItem.setEnabled(jarOpen);
 		this.reloadAllItem.setEnabled(jarOpen);

enigma-swing/src/main/java/org/quiltmc/enigma/gui/element/menu_bar/file/FileMenu.java

@@ -58,7 +58,7 @@ public void retranslate() {
 
 	@Override
 	public void updateState(boolean jarOpen, ConnectionState state) {
-		this.enableIcons.setSelected(Config.main().features.enableClassTreeStatIcons.value());
+		this.enableIcons.setSelected(Config.stats().enableClassTreeStatIcons.value());
 		this.includeSynthetic.setSelected(Config.main().stats.shouldIncludeSyntheticParameters.value());
 		this.countFallback.setSelected(Config.main().stats.shouldCountFallbackNames.value());
 
@@ -69,7 +69,7 @@ public void updateState(boolean jarOpen, ConnectionState state) {
 	}
 
 	private void onEnableIconsClicked() {
-		Config.main().features.enableClassTreeStatIcons.setValue(this.enableIcons.isSelected());
+		Config.stats().enableClassTreeStatIcons.setValue(this.enableIcons.isSelected());
 		this.updateIconsLater();
 	}
 

enigma-swing/src/main/java/org/quiltmc/enigma/gui/element/menu_bar/view/StatsMenu.java

@@ -113,7 +113,7 @@ public void done() {
 			}
 		};
 
-		if (Config.main().features.enableClassTreeStatIcons.value()) {
+		if (Config.stats().enableClassTreeStatIcons.value()) {
 			SwingUtilities.invokeLater(iconUpdateWorker::execute);
 		}
 

enigma-swing/src/main/java/org/quiltmc/enigma/gui/node/ClassSelectorClassNode.java

@@ -194,7 +194,7 @@ public CompletableFuture<Void> renamePackage(String path, String input) {
 				classSelector.restoreExpansionState(entry.getValue());
 			}
 
-			if (Config.main().features.autoSaveMappings.value() && this.gui.mappingsFileChooser.getSelectedFile() != null) {
+			if (Config.editor().autoSaveMappings.value() && this.gui.mappingsFileChooser.getSelectedFile() != null) {
 				this.gui.getController().saveMappings(this.gui.mappingsFileChooser.getSelectedFile().toPath(), true);
 			}
 		});