Skip to content

Commit d974835

Browse files
authored
Merge pull request #1609 from QwenLM/fix/settings-load-from-include-directories
fix: correct schema field name for context.loadFromIncludeDirectories
2 parents 32cddc2 + 066c393 commit d974835

File tree

6 files changed

+14
-16
lines changed

6 files changed

+14
-16
lines changed

packages/cli/src/config/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -932,7 +932,7 @@ export async function loadCliConfig(
932932
targetDir: cwd,
933933
includeDirectories,
934934
loadMemoryFromIncludeDirectories:
935-
settings.context?.loadMemoryFromIncludeDirectories || false,
935+
settings.context?.loadFromIncludeDirectories || false,
936936
importFormat: settings.context?.importFormat || 'tree',
937937
debugMode,
938938
question,

packages/cli/src/config/settingsSchema.test.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -218,14 +218,14 @@ describe('SettingsSchema', () => {
218218
},
219219
context: {
220220
includeDirectories: ['/path/to/dir'],
221-
loadMemoryFromIncludeDirectories: true,
221+
loadFromIncludeDirectories: true,
222222
},
223223
};
224224

225225
// TypeScript should not complain about these properties
226226
expect(settings.ui?.theme).toBe('dark');
227227
expect(settings.context?.includeDirectories).toEqual(['/path/to/dir']);
228-
expect(settings.context?.loadMemoryFromIncludeDirectories).toBe(true);
228+
expect(settings.context?.loadFromIncludeDirectories).toBe(true);
229229
});
230230

231231
it('should have includeDirectories setting in schema', () => {
@@ -243,21 +243,19 @@ describe('SettingsSchema', () => {
243243
).toEqual([]);
244244
});
245245

246-
it('should have loadMemoryFromIncludeDirectories setting in schema', () => {
246+
it('should have loadFromIncludeDirectories setting in schema', () => {
247247
expect(
248-
getSettingsSchema().context?.properties
249-
.loadMemoryFromIncludeDirectories,
248+
getSettingsSchema().context?.properties.loadFromIncludeDirectories,
250249
).toBeDefined();
251250
expect(
252-
getSettingsSchema().context?.properties.loadMemoryFromIncludeDirectories
253-
.type,
251+
getSettingsSchema().context?.properties.loadFromIncludeDirectories.type,
254252
).toBe('boolean');
255253
expect(
256-
getSettingsSchema().context?.properties.loadMemoryFromIncludeDirectories
254+
getSettingsSchema().context?.properties.loadFromIncludeDirectories
257255
.category,
258256
).toBe('Context');
259257
expect(
260-
getSettingsSchema().context?.properties.loadMemoryFromIncludeDirectories
258+
getSettingsSchema().context?.properties.loadFromIncludeDirectories
261259
.default,
262260
).toBe(false);
263261
});

packages/cli/src/config/settingsSchema.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ const SETTINGS_SCHEMA = {
687687
showInDialog: false,
688688
mergeStrategy: MergeStrategy.CONCAT,
689689
},
690-
loadMemoryFromIncludeDirectories: {
690+
loadFromIncludeDirectories: {
691691
type: 'boolean',
692692
label: 'Load Memory From Include Directories',
693693
category: 'Context',

packages/cli/src/ui/AppContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ export const AppContainer = (props: AppContainerProps) => {
623623
try {
624624
const { memoryContent, fileCount } = await loadHierarchicalGeminiMemory(
625625
process.cwd(),
626-
settings.merged.context?.loadMemoryFromIncludeDirectories
626+
settings.merged.context?.loadFromIncludeDirectories
627627
? config.getWorkspaceContext().getDirectories()
628628
: [],
629629
config.getDebugMode(),

packages/cli/src/ui/components/SettingsDialog.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1368,7 +1368,7 @@ describe('SettingsDialog', () => {
13681368
enabled: true,
13691369
},
13701370
context: {
1371-
loadMemoryFromIncludeDirectories: true,
1371+
loadFromIncludeDirectories: true,
13721372
fileFiltering: {
13731373
respectGitIgnore: true,
13741374
respectQwenIgnore: true,
@@ -1540,7 +1540,7 @@ describe('SettingsDialog', () => {
15401540
enableRecursiveFileSearch: false,
15411541
disableFuzzySearch: true,
15421542
},
1543-
loadMemoryFromIncludeDirectories: true,
1543+
loadFromIncludeDirectories: true,
15441544
},
15451545
});
15461546
const onSelect = vi.fn();
@@ -1605,7 +1605,7 @@ describe('SettingsDialog', () => {
16051605
enabled: false,
16061606
},
16071607
context: {
1608-
loadMemoryFromIncludeDirectories: false,
1608+
loadFromIncludeDirectories: false,
16091609
fileFiltering: {
16101610
respectGitIgnore: false,
16111611
respectQwenIgnore: false,

packages/core/src/config/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -712,7 +712,7 @@ export class Config {
712712
this.getDebugMode(),
713713
this.getFileService(),
714714
this.getExtensionContextFilePaths(),
715-
this.getFolderTrust(),
715+
this.isTrustedFolder(),
716716
this.getImportFormat(),
717717
);
718718
this.setUserMemory(memoryContent);

0 commit comments

Comments
 (0)