[proposal] Support Rolldown for Qwik’s Vite plugin

[NaitLee]

What is it about?

No response

What's the motivation for this proposal?

Vite is planning to integrate Rolldown, a new JavaScript bundler that is faster.

Projects using Vite can switch to rolldown-vite by doing this in package.json:

{
  "dependencies": {
-    "vite": "^7.0.0"
+    "vite": "npm:rolldown-vite@latest"
  }
}

The most significant change of rolldown-vite is that manualChunks is deprecated, and advancedChunks should be used instead. API Differences: manualChunks to advancedChunks

There’s compat code for manualChunks, unfortunately it doesn’t work for qwik build at the moment:

$ vite build
rolldown-vite v7.0.8 building for production...
✓ 40 modules transformed.
2717 |       }
2718 |       if (/[/\\](core|qwik)[/\\]dist[/\\]qwikloader\.js$/.test(id2)) {
2719 |         return "qwik-loader";
2720 |       }
2721 |     }
2722 |     const module = getModuleInfo(id2);
                                           ^
TypeError: null is not an object (evaluating 'getModuleInfo(id2).meta')
      at manualChunks (/tmp/test-project/node_modules/@qwik.dev/core/dist/optimizer.mjs:2722:37)

Bun v1.2.14 (Linux x64)

Reproduce:

bun create [email protected] empty test-project
cd test-project
sed -i 's/"vite": "7.0.0"/"vite": "npm:rolldown-vite@latest"/' package.json
bun install
bun run qwik add static
bun run build

See Qwik manualChunks and rolldown-vite bindingifyAdvancedChunks.

I think Qwik need to implement advancedChunks before Qwik 2 release :)

Proposed Solution / Feature

See example provided by vite:

manualChunks(id) {
  if (/\/react(?:-dom)?/.test(id)) {
    return 'vendor'
  }
}

advancedChunks: {
  groups: [{ name: 'vendor', test: /\/react(?:-dom)?/ }]
}

And looking into bindingifyAdvancedChunks can be helpful:

advancedChunks = {
  groups: [
    {
      name(moduleId, ctx) {
        return manualChunks(moduleId, {
          getModuleInfo: (id) => ctx.getModuleInfo(id),
        });
      },
    },
  ],
};

But note that ModuleInfo is also unsupported by rolldown, while Qwik currently looks into the (incomplete) module info. Probably we need a new approach doing chunks.

Links / References

Vite rolldown guide

Qwik manualChunks implementation

Rolldown bindingifyAdvancedChunks implementation

[wmertens]

hmm interesting, I had it working with the manualChunks just after it got merged, I think. So a bug on their side.

In any case, the resulting build had issues with css. But I don't think we need to make any changes on the Qwik side to make it work. just use pnpm overrides to set vite to rolldown-vite and to pin rolldown to the version you want.

[maiieul]

Yes this is definitely on our radar. I tried it too about a month ago and the preloader wouldn't work on v1. But the app was reactive though so that may be a new bug, unless it happens only on v2.

It seems you've been able to dig around the code a little bit already so if you want to champion this I think we'll happily go to stage 2 and provide help/guidance as much as we can (given we're all quite busy atm).

This might not be that much code to change, but we need to make sure the core features (reactivity, preloading, router, insights, etc.) all work seemlessly under rolldown (at least on v2).