Skip to content

Commit 05cf787

Browse files
committed
fix(preloader): set user interaction max deps to 100
1 parent 62f5aa8 commit 05cf787

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

packages/qwik/src/core/preloader/preloader.unit.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@ test('preloader script', () => {
2121
* dereference objects etc, but that actually results in worse compression
2222
*/
2323
const compressed = compress(Buffer.from(preLoader), { mode: 1, quality: 11 });
24-
expect([compressed.length, preLoader.length]).toEqual([1816, 5423]);
24+
expect([compressed.length, preLoader.length]).toEqual([1851, 5535]);
2525
});

packages/qwik/src/core/preloader/queue.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,11 @@ export const adjustProbabilities = (
204204
* too.
205205
*/
206206
let newInverseProbability: number;
207-
if (probability >= 0.99) {
207+
if (
208+
dep.$importProbability$ > 0.5 &&
209+
(probability === 1 || (probability >= 0.99 && depsCount < 100))
210+
) {
211+
depsCount++;
208212
// we're loaded at max probability, so elevate dynamic imports to 99% sure
209213
newInverseProbability = Math.min(0.01, 1 - dep.$importProbability$);
210214
} else {
@@ -228,10 +232,13 @@ export const handleBundle = (name: string, inverseProbability: number) => {
228232
}
229233
};
230234

235+
let depsCount: number;
236+
231237
export const preload = (name: string | (number | string)[], probability?: number) => {
232238
if (!name?.length) {
233239
return;
234240
}
241+
depsCount = 0;
235242

236243
let inverseProbability = probability ? 1 - probability : 0.4;
237244
if (Array.isArray(name)) {

0 commit comments

Comments
 (0)