feat(serdes): dedupe qrls

Author: wmertens

packages/qwik/src/core/shared/serdes/serdes.unit.ts

@@ -345,7 +345,7 @@ describe('shared-serialization', () => {
       ).toMatchInlineSnapshot(`
         "
         0 Task [
-          QRL 2
+          QRL "mock-chunk#task_qrl[1]"
           {number} 0
           {number} 0
           RootRef 1
@@ -356,12 +356,11 @@ describe('shared-serialization', () => {
           ]
         ]
         1 Object [
-          RootRef 3
+          RootRef 2
           {number} 1
         ]
-        2 {string} "mock-chunk#task_qrl[1]"
-        3 RootRef "0 5 0"
-        (95 chars)"
+        2 RootRef "0 5 0"
+        (91 chars)"
       `);
     });
     it(title(TypeIds.Resource), async () => {
@@ -390,10 +389,9 @@ describe('shared-serialization', () => {
         `
         "
         0 Component [
-          QRL 1
+          QRL "mock-chunk#dump_component"
         ]
-        1 {string} "mock-chunk#dump_component"
-        (41 chars)"
+        (37 chars)"
       `
       );
     });
@@ -944,6 +942,23 @@ describe('shared-serialization', () => {
         (103 chars)"
       `);
     });
+    it('should dedupe identical qrls', async () => {
+      const fn = () => 'hi';
+      const a = {};
+      const qrl1 = inlinedQrl(fn, 'dump_qrl', [a]);
+      const qrl2 = inlinedQrl(fn, 'dump_qrl', [a]);
+      expect(qrl1).not.toBe(qrl2);
+      const objs = await serialize(qrl1, [qrl2]);
+      expect(dumpState(objs)).toMatchInlineSnapshot(`
+        "
+        0 QRL "mock-chunk#dump_qrl[2]"
+        1 Array [
+          RootRef 0
+        ]
+        2 Object []
+        (42 chars)"
+      `);
+    });
   });
 
   describe('Serialization Weak Ref', () => {

packages/qwik/src/core/shared/serdes/serialize.ts

@@ -70,7 +70,7 @@ export async function serialize(serializationContext: SerializationContext): Pro
   const preloadQrls = new Set<QRLInternal>();
   const s11nWeakRefs = new Map<unknown, number>();
   let parent: unknown = null;
-  const isRootObject = () => depth === 0;
+  const qrlMap = new Map<string, QRLInternal>();
 
   const outputArray = (value: unknown[], writeFn: (value: unknown, idx: number) => void) => {
     $writer$.write('[');
@@ -168,13 +168,21 @@ export async function serialize(serializationContext: SerializationContext): Pro
       } else if (isQrl(value)) {
         if (!outputAsRootRef(value)) {
           const qrl = qrlToString(serializationContext, value);
-          const type = preloadQrls.has(value) ? TypeIds.PreloadQRL : TypeIds.QRL;
-          if (isRootObject()) {
-            output(type, qrl);
+
+          // Since we map QRLs to strings, we need to keep track of this secondary mapping
+          const existing = qrlMap.get(qrl);
+          if (existing) {
+            // We encountered the same QRL again, make it a root
+            $addRoot$(existing);
+            // We need to force because we might be adding the same root again
+            if (outputAsRootRef(existing, 0, true)) {
+              return;
+            }
           } else {
-            const id = serializationContext.$addRoot$(qrl);
-            output(type, id);
+            qrlMap.set(qrl, value);
           }
+          const type = preloadQrls.has(value) ? TypeIds.PreloadQRL : TypeIds.QRL;
+          output(type, qrl);
         }
       } else if (isQwikComponent(value)) {
         const [qrl]: [QRLInternal] = (value as any)[SERIALIZABLE_STATE];
@@ -672,7 +680,8 @@ export function shouldTrackObj(obj: unknown) {
      */
     (typeof obj === 'string' && obj.length > 1) ||
     /** Same reasoning but for bigint */
-    (typeof obj === 'bigint' && (obj > 9 || obj < 0))
+    (typeof obj === 'bigint' && (obj > 9 || obj < 0)) ||
+    isQrl(obj)
   );
 } /**
  * When serializing the object we need check if it is URL, RegExp, Map, Set, etc. This is time
@@ -697,8 +706,5 @@ export function isResource<T = unknown>(value: object): value is ResourceReturnI
 }
 
 export const frameworkType = (obj: any) => {
-  return (
-    (isObject(obj) && (obj instanceof SignalImpl || obj instanceof Task || isJSXNode(obj))) ||
-    isQrl(obj)
-  );
+  return obj && (obj instanceof SignalImpl || obj instanceof Task || isJSXNode(obj));
 };