Skip to content

Commit 20dc320

Browse files
authored
Merge pull request #8360 from QwikDev/fix-bindings
fix(build): ensure that bindings map is correct
2 parents 09fa6b3 + 7d8402b commit 20dc320

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

.changeset/eager-sides-sit.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@builder.io/qwik': patch
3+
---
4+
5+
FIX: the optimizer was not using the binary builds

scripts/submodule-optimizer.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ import RawPlugin from 'esbuild-plugin-raw';
1919
export async function submoduleOptimizer(config: BuildConfig) {
2020
const submodule = 'optimizer';
2121

22-
await generatePlatformBindingsData(config);
22+
// Uncomment this to regenerate the platform binding map for the optimizer. This is only necessary when adding new platform bindings to qwik, and should be committed to source control.
23+
// await generatePlatformBindingsData(config);
2324

2425
async function buildOptimizer() {
2526
const opts: BuildOptions = {

starters/apps/base/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
"devDependencies": {
1919
"@builder.io/qwik": "latest",
2020
"@builder.io/qwik-city": "latest",
21-
"@eslint/js": "latest",
21+
"@eslint/js": "^9",
2222
"@types/node": "latest",
2323
"typescript-eslint": "latest",
24-
"eslint": "latest",
24+
"eslint": "^9",
2525
"eslint-plugin-qwik": "latest",
2626
"globals": "latest",
2727
"prettier": "latest",

starters/apps/library/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@
3434
},
3535
"devDependencies": {
3636
"@builder.io/qwik": "latest",
37-
"@eslint/js": "latest",
37+
"@eslint/js": "^9",
3838
"@types/node": "latest",
3939
"typescript-eslint": "latest",
40-
"eslint": "latest",
40+
"eslint": "^9",
4141
"eslint-plugin-qwik": "latest",
4242
"globals": "latest",
4343
"np": "^8.0.4",

0 commit comments

Comments
 (0)