refactor: replace cross-spawn with execa for improved command execution and error handling; remove unused type definitions and update package configurations

Author: JerryWu1234

package.json

@@ -108,7 +108,6 @@
     "@qwik.dev/router": "workspace:*",
     "@types/brotli": "1.3.4",
     "@types/bun": "1.2.21",
-    "@types/cross-spawn": "6.0.6",
     "@types/express": "5.0.3",
     "@types/node": "24.3.0",
     "@types/path-browserify": "1.0.3",
@@ -122,7 +121,6 @@
     "all-contributors-cli": "6.26.1",
     "brotli": "1.3.3",
     "create-qwik": "workspace:*",
-    "cross-spawn": "7.0.6",
     "csstype": "3.1.3",
     "dotenv": "16.5.0",
     "esbuild": "0.25.10",

packages/qwik/package.json

@@ -97,8 +97,7 @@
     },
     "./insights": {
       "types": "./dist/insights.d.ts",
-      "import": "./dist/insights/index.qwik.mjs",
-      "require": "./dist/insights/index.qwik.cjs"
+      "import": "./dist/insights/index.qwik.mjs"
     },
     "./insights/vite": {
       "types": "./dist/insights/vite.d.ts",

packages/qwik/qwik-cli.mjs

@@ -1,4 +1,4 @@
 #!/usr/bin/env node
 // This requires the build to be run first.
-const qwik = require('./dist/cli.mjs');
+import * as qwik from './dist/cli.mjs';
 qwik.runCli();

packages/qwik/src/cli/qwik.cjs packages/qwik/src/cli/qwik.mjspackages/qwik/src/cli/qwik.cjs renamed to packages/qwik/src/cli/qwik.mjs

@@ -1,3 +1,3 @@
 #!/usr/bin/env node
-const qwik = require('./cli.mjs');
+import * as qwik from './cli.mjs';
 qwik.runCli();

packages/qwik/src/cli/utils/utils.ts

@@ -1,52 +1,36 @@
 import { blue, gray, green, magenta, red, reset, white } from 'kleur/colors';
 import { log, outro } from '@clack/prompts';
-
-import type { ChildProcess } from 'node:child_process';
 import type { IntegrationPackageJson } from '../types';
 import detectPackageManager from 'which-pm-runs';
 import fs from 'node:fs';
 import { join } from 'node:path';
-import spawn from 'cross-spawn';
-
+import { execa } from 'execa';
 export function runCommand(cmd: string, args: string[], cwd: string) {
-  let child: ChildProcess;
-
-  const install = new Promise<boolean>((resolve) => {
-    try {
-      child = spawn(cmd, args, {
-        cwd,
-        stdio: 'ignore',
-      });
-
-      child.on('error', (e) => {
-        if (e) {
-          if (e.message) {
-            log.error(red(String(e.message)) + `\n\n`);
-          } else {
-            log.error(red(String(e)) + `\n\n`);
-          }
-        }
-        resolve(false);
-      });
+  const child = execa(cmd, args, {
+    cwd,
+    stdio: 'ignore',
+  });
 
-      child.on('close', (code) => {
-        if (code === 0) {
-          resolve(true);
+  const install: Promise<boolean> = child
+    .then(() => {
+      return true;
+    })
+    .catch((e) => {
+      if (e) {
+        if (e.message) {
+          log.error(red(String(e.message)) + `\n\n`);
         } else {
-          resolve(false);
+          log.error(red(String(e)) + `\n\n`);
         }
-      });
-    } catch (e) {
-      resolve(false);
-    }
-  });
+      }
+      return false;
+    });
 
   const abort = async () => {
-    if (child) {
-      child.kill('SIGINT');
-    }
+    child.kill('SIGINT');
   };
 
+  // 5. Return the object synchronously
   return { abort, install };
 }
 

pnpm-lock.yaml

@@ -1,48 +1,36 @@
-import spawn from 'cross-spawn';
+import { execa } from 'execa';
 import { copyFile, writeFile } from 'fs/promises';
 import { existsSync } from 'node:fs';
 import { join } from 'node:path';
 import { ensureDir, type BuildConfig } from './util';
 
 export async function buildPlatformBinding(config: BuildConfig) {
-  await new Promise((resolve, reject) => {
-    try {
-      ensureDir(config.distQwikPkgDir);
-      ensureDir(config.distBindingsDir);
-
-      const cmd = `napi`;
-      const args = [
-        `build`,
-        `--cargo-name`,
-        'qwik_napi',
-        `--platform`,
-        `--config=packages/qwik/src/napi/napi.config.json`,
-        config.distBindingsDir,
-      ];
-
-      if (config.platformTarget) {
-        args.push(`--target`, config.platformTarget);
-      }
-      if (!config.dev) {
-        args.push(`--release`);
-        args.push(`--strip`);
-      }
+  ensureDir(config.distQwikPkgDir);
+  ensureDir(config.distBindingsDir);
 
-      const napiCwd = join(config.rootDir);
+  const cmd = `napi`;
+  const args = [
+    `build`,
+    `--cargo-name`,
+    'qwik_napi',
+    `--platform`,
+    `--config=packages/qwik/src/napi/napi.config.json`,
+    config.distBindingsDir,
+  ];
+
+  if (config.platformTarget) {
+    args.push(`--target`, config.platformTarget);
+  }
+  if (!config.dev) {
+    args.push(`--release`);
+    args.push(`--strip`);
+  }
 
-      const child = spawn(cmd, args, { stdio: 'inherit', cwd: napiCwd });
-      child.on('error', reject);
+  const napiCwd = join(config.rootDir);
 
-      child.on('close', (code) => {
-        if (code === 0) {
-          resolve(child.stdout);
-        } else {
-          reject(`napi exited with code ${code}`);
-        }
-      });
-    } catch (e) {
-      reject(e);
-    }
+  await execa(cmd, args, {
+    stdio: 'inherit',
+    cwd: napiCwd,
   });
 
   console.log('🐯 native binding');
@@ -99,21 +87,7 @@ export async function copyPlatformBindingWasm(config: BuildConfig) {
     // now unpack the package using tar, into the cache directory
     const unpackedPath = join(cacheDir, `${realPackageName}-unpacked`);
     ensureDir(unpackedPath);
-    await new Promise((resolve, reject) => {
-      const child = spawn('tar', ['-xvf', cachedPath, '-C', unpackedPath]);
-      child.on('error', (e) => {
-        console.error(e);
-        reject(e);
-      });
-      child.on('close', (code) => {
-        if (code === 0) {
-          resolve(child.stdout);
-        } else {
-          console.error(child.stdout);
-          reject(`tar exited with code ${code}`);
-        }
-      });
-    });
+    await execa('tar', ['-xvf', cachedPath, '-C', unpackedPath]);
 
     // now we need to find the bindings in the package
     cacheVersionDir = join(unpackedPath, 'package', 'bindings');

scripts/binding-platform.ts

@@ -1,5 +1,5 @@
 import { type BuildConfig, copyFile, emptyDir, ensureDir } from './util';
-import spawn from 'cross-spawn';
+import { execa } from 'execa';
 import { join } from 'node:path';
 import { rollup } from 'rollup';
 
@@ -18,25 +18,18 @@ export async function buildWasmBinding(config: BuildConfig) {
       args.push(`--release`);
     }
 
-    await new Promise((resolve, reject) => {
-      const child = spawn(cmd, args, {
-        stdio: 'inherit',
-        shell: true,
-        env: {
-          ...process.env,
-          ...env,
-        },
-      });
-      child.on('error', reject);
-
-      child.on('close', (code) => {
-        if (code === 0) {
-          resolve(child.stdout);
-        } else {
-          reject(`wasm-pack exited with code ${code}`);
-        }
-      });
+    // 2. Replace the entire Promise wrapper with one line
+    //    execa handles errors and non-zero exit codes automatically.
+    await execa(cmd, args, {
+      stdio: 'inherit', // 'inherit' is still used to show build output
+      shell: true,
+      env: {
+        ...process.env,
+        ...env,
+      },
     });
+
+    // 3. The return statement is unchanged
     return join(tmpBuildDir, 'qwik_wasm.js');
   }
 

scripts/binding-wasm.ts

@@ -35,7 +35,7 @@ export async function submoduleCli(config: BuildConfig) {
         },
       },
     ],
-    external: ['prettier', 'typescript', 'ts-morph', 'semver', 'ignore'],
+    external: ['prettier', 'typescript', 'ts-morph', 'semver', 'ignore', 'execa'],
     define: {
       'globalThis.CODE_MOD': 'true',
       'globalThis.QWIK_VERSION': JSON.stringify(config.distVersion),

scripts/submodule-cli.ts

@@ -17,12 +17,12 @@ async function buildComponents(config: BuildConfig) {
     build: {
       lib: {
         entry: entryPoint,
-        formats: ['es', 'cjs'],
-        fileName: (format) => `index.qwik.${format === 'es' ? 'mjs' : 'cjs'}`,
+        formats: ['es'],
+        fileName: () => 'index.qwik.mjs',
       },
       outDir: distBase,
       emptyOutDir: false,
-      target: 'es2020',
+      target: 'es2022',
       minify: true,
       rollupOptions: {
         external: (id) => /^(@|node:)/i.test(id),
@@ -39,8 +39,8 @@ async function buildVite(config: BuildConfig) {
     build: {
       lib: {
         entry: entryPoint,
-        formats: ['es', 'cjs'],
-        fileName: (format) => (format === 'es' ? 'index.mjs' : 'index.cjs'),
+        formats: ['es'],
+        fileName: () => 'index.mjs',
       },
       outDir: distBase,
       emptyOutDir: false,