fix(serde): Error serialization

Author: wmertens

packages/qwik/src/core/shared/shared-serialization.ts

@@ -324,14 +324,8 @@ const inflate = (
     case TypeIds.Error: {
       const d = data as unknown[];
       target.message = d[0];
-      const second = d[1];
-      if (second && Array.isArray(second)) {
-        for (let i = 0; i < second.length; i++) {
-          target[second[i++]] = second[i];
-        }
-        target.stack = d[2];
-      } else {
-        target.stack = second;
+      for (let i = 1; i < d.length; i += 2) {
+        target[d[i] as string] = d[i + 1];
       }
       break;
     }
@@ -818,7 +812,7 @@ export const createSerializationContext = (
       ) {
         // ignore
       } else if (obj instanceof Error) {
-        discoveredValues.push(...Object.values(obj));
+        discoveredValues.push(obj.message, ...Object.values(obj), isDev && obj.stack);
       } else if (isStore(obj)) {
         const target = getStoreTarget(obj)!;
         const effects = getStoreHandler(obj)!.$effects$;
@@ -1268,13 +1262,11 @@ function serialize(serializationContext: SerializationContext): void {
       output(TypeIds.Regex, value.toString());
     } else if (value instanceof Error) {
       const out: any[] = [value.message];
-      const extraProps = Object.entries(value).flat();
-      if (extraProps.length) {
-        out.push(extraProps);
-      }
+      // flatten gives us the right output
+      out.push(...Object.entries(value).flat());
       /// In production we don't want to leak the stack trace.
       if (isDev) {
-        out.push(value.stack);
+        out.push('stack', value.stack);
       }
       output(TypeIds.Error, out);
     } else if ($isSsrNode$(value)) {

packages/qwik/src/core/shared/shared-serialization.unit.ts

@@ -167,6 +167,7 @@ describe('shared-serialization', () => {
         "
         0 Error [
           String "hi"
+          String "stack"
           String "Error: hi\\n    at /...path/file.ts:123:456\\n    at file:/...path/file.js:123:456\\n    at file:/...path/file.js:123:456\\"...
         ]
         (x chars)"
@@ -176,10 +177,9 @@ describe('shared-serialization', () => {
         "
         0 Error [
           String "hi"
-          Array [
-            String "extra"
-            String "yey"
-          ]
+          String "extra"
+          String "yey"
+          String "stack"
           String "Error: hi\\n    at /...path/file.ts:123:456\\n    at file:/...path/file.js:123:456\\n    at file:/...path/file.js:123:456\\"...
         ]
         (x chars)"

packages/qwik/src/core/tests/container.spec.tsx

@@ -311,11 +311,14 @@ describe('serializer v2', () => {
 
     describe('ErrorSerializer, ///////// ' + TypeIds.Error, () => {
       it('should serialize and deserialize', async () => {
-        const obj = Object.assign(new Error('MyError'), { extra: 'property' });
+        const date = new Date();
+        const obj = Object.assign(new Error('MyError'), {
+          extra: { foo: ['bar', { hi: true }], bar: date },
+        });
         const result = (await withContainer((ssr) => ssr.addRoot(obj))).$getObjectById$(0);
-        expect(result).toBeInstanceOf(Error);
-        expect(result.message).toBe('MyError');
-        expect((result as any).extra).toBe('property');
+        expect(result.message).toEqual(obj.message);
+        expect(result.extra.foo).toEqual(['bar', { hi: true }]);
+        expect(result.extra.bar).toEqual(date);
       });
     });