Skip to content

Commit 4f128c9

Browse files
authored
Merge pull request #7908 from maiieul/set-packages-as-side-effect-free
chore: mark all qwik packages as side effect free
2 parents 1f50628 + 7bfb4b1 commit 4f128c9

File tree

7 files changed

+18
-6
lines changed

7 files changed

+18
-6
lines changed

.changeset/shaggy-pears-shine.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@builder.io/qwik': patch
3+
'@builder.io/qwik-city': patch
4+
---
5+
6+
FEAT: All qwik packages are now marked as side effect free in their package.json. This should remove a few unecessary empty imports added by rollup and then not tree-shaken like `import "./preloader.js"`.

packages/insights/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,5 +70,6 @@
7070
"test.unit": "vitest",
7171
"test.watch": "vitest --watch"
7272
},
73-
"type": "module"
73+
"type": "module",
74+
"sideEffects": false
7475
}

packages/qwik-city/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,5 +188,6 @@
188188
"build": "cd src/runtime && vite build --mode lib"
189189
},
190190
"type": "module",
191-
"types": "./lib/index.d.ts"
191+
"types": "./lib/index.d.ts",
192+
"sideEffects": false
192193
}

packages/qwik-labs/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,6 @@
5959
"test.unit": "vitest"
6060
},
6161
"type": "module",
62-
"types": "./lib/index.d.ts"
62+
"types": "./lib/index.d.ts",
63+
"sideEffects": false
6364
}

packages/qwik-react/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,5 +65,6 @@
6565
"typecheck": "tsc --noEmit"
6666
},
6767
"type": "module",
68-
"types": "./lib/types/index.qwik.d.ts"
68+
"types": "./lib/types/index.qwik.d.ts",
69+
"sideEffects": false
6970
}

packages/qwik-worker/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,6 @@
3636
"build": "vite build --mode lib"
3737
},
3838
"type": "module",
39-
"types": "./lib/types/index.d.ts"
39+
"types": "./lib/types/index.d.ts",
40+
"sideEffects": false
4041
}

packages/qwik/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,5 +171,6 @@
171171
"directory": "packages/qwik"
172172
},
173173
"type": "module",
174-
"types": "./dist/core.d.ts"
174+
"types": "./dist/core.d.ts",
175+
"sideEffects": false
175176
}

0 commit comments

Comments
 (0)