perf: remove unnecessary effects cleanups

Varixo · Varixo · commit 5eb1cd6c8256 · 2025-10-02T09:06:21.000+02:00
diff --git a/packages/qwik/src/core/client/vnode-diff.ts b/packages/qwik/src/core/client/vnode-diff.ts
@@ -183,9 +183,6 @@ export const vnode_diff = (
           if (Array.isArray(jsxValue)) {
             descend(jsxValue, false);
           } else if (isSignal(jsxValue)) {
-            if (vCurrent) {
-              clearAllEffects(container, vCurrent);
-            }
             expectVirtual(VirtualType.WrappedSignal, null);
             descend(
               trackSignalAndAssignHost(
diff --git a/packages/qwik/src/core/shared/component-execution.ts b/packages/qwik/src/core/shared/component-execution.ts
@@ -101,7 +101,7 @@ export const executeComponent = (
           container.setHostProp(renderHost, USE_ON_LOCAL_SEQ_IDX, null);
         }
 
-        if (vnode_isVNode(renderHost)) {
+        if (retryCount > 0 && vnode_isVNode(renderHost)) {
           clearAllEffects(container, renderHost);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ export const executeComponent = (`
`101`	`101`	`container.setHostProp(renderHost, USE_ON_LOCAL_SEQ_IDX, null);`
`102`	`102`	`}`
`103`	`103`
`104`		`- if (vnode_isVNode(renderHost)) {`
	`104`	`+ if (retryCount > 0 && vnode_isVNode(renderHost)) {`
`105`	`105`	`clearAllEffects(container, renderHost);`
`106`	`106`	`}`
`107`	`107`