test: refactor for chunkFileNames and entryFileNames as functions

Author: maiieul

packages/qwik/src/optimizer/src/plugins/rollup.ts

@@ -230,7 +230,14 @@ export function normalizeRollupOutputOptionsObject(
           return 'build/qwik-city.js';
         }
 
-        const sanitizedPath = sanitizePath(optimizer, chunkInfo.name);
+        // Sanitize The path to use dashes instead of slashes, to keep the same folder strucutre as without debug:true.
+        // Besides, Rollup doesn't accept absolute or relative paths as inputs for the [name] placeholder for the same reason.
+        const path = optimizer.sys.path;
+        const relativePath = path.relative(optimizer.sys.cwd(), chunkInfo.name);
+        const sanitizedPath = relativePath
+          .replace(/^(\.\.\/)+/, '')
+          .replace(/^\/+/, '')
+          .replace(/\//g, '-');
         chunkInfo.name = sanitizedPath;
         return `build/[name].js`;
       };
@@ -277,20 +284,6 @@ export function normalizeRollupOutputOptionsObject(
   return outputOpts;
 }
 
-/**
- * @private Sanitize The path to use dashes instead of slashes, to keep the same folder strucutre as
- *   without debug:true. Besides, Rollup doesn't accept absolute or relative paths as inputs for the
- *   [name] placeholder for the same reason.
- */
-export function sanitizePath(optimizer: Optimizer, pathToSanitize: string) {
-  const path = optimizer.sys.path;
-  const relativePath = path.relative(optimizer.sys.cwd(), pathToSanitize);
-  return relativePath
-    .replace(/^(\.\.\/)+/, '')
-    .replace(/^\/+/, '')
-    .replace(/\//g, '-');
-}
-
 export function createRollupError(id: string, diagnostic: Diagnostic) {
   const loc = diagnostic.highlights[0] ?? {};
   const err: Rollup.RollupError = Object.assign(new Error(diagnostic.message), {

packages/qwik/src/optimizer/src/plugins/vite.unit.ts

@@ -61,6 +61,13 @@ test('command: serve, mode: development', async () => {
   const build = c.build!;
   const rollupOptions = build!.rollupOptions!;
   const outputOptions = rollupOptions.output as Rollup.OutputOptions;
+  const chunkFileNames = outputOptions.chunkFileNames as (
+    chunkInfo: Rollup.PreRenderedChunk
+  ) => string;
+  const entryFileNames = outputOptions.entryFileNames as (
+    chunkInfo: Rollup.PreRenderedChunk
+  ) => string;
+  const fakeChunkInfo = { name: 'chunk.tsx' } as Rollup.PreRenderedChunk;
 
   assert.deepEqual(opts.target, 'client');
   assert.deepEqual(opts.buildMode, 'development');
@@ -71,8 +78,8 @@ test('command: serve, mode: development', async () => {
   assert.deepEqual(rollupOptions.input, normalizePath(resolve(cwd, 'src', 'entry.dev')));
 
   assert.deepEqual(outputOptions.assetFileNames, 'assets/[hash]-[name].[ext]');
-  assert.deepEqual(outputOptions.chunkFileNames, 'build/[name].js');
-  assert.deepEqual(outputOptions.entryFileNames, 'build/[name].js');
+  assert.deepEqual(chunkFileNames(fakeChunkInfo), 'build/[name].js');
+  assert.deepEqual(entryFileNames(fakeChunkInfo), 'build/[name].js');
   assert.deepEqual(outputOptions.format, 'es');
 
   assert.deepEqual(build.dynamicImportVarsOptions?.exclude, [/./]);