dont use async for processJSXNode

Author: Varixo

packages/qwik/src/core/ssr/ssr-render-jsx.ts

@@ -47,9 +47,17 @@ class ParentComponentData {
     public $componentFrame$: ISsrComponentFrame | null
   ) {}
 }
+class MaybeAsyncSignal {}
+
 type StackFn = () => ValueOrPromise<void>;
 type StackValue = ValueOrPromise<
-  JSXOutput | StackFn | Promise<JSXOutput> | typeof Promise | ParentComponentData | AsyncGenerator
+  | JSXOutput
+  | StackFn
+  | Promise<JSXOutput>
+  | typeof Promise
+  | ParentComponentData
+  | AsyncGenerator
+  | typeof MaybeAsyncSignal
 >;
 
 /** @internal */
@@ -70,6 +78,14 @@ export async function _walkJSX(
         options.currentStyleScoped = value.$scopedStyle$;
         options.parentComponentFrame = value.$componentFrame$;
         continue;
+      } else if (value === MaybeAsyncSignal) {
+        // It could be an async signal, but it is not resolved yet, we need to wait for it.
+        // We could do that in the processJSXNode,
+        // but it will mean that we need to await it there, and it will return a promise.
+        // We probably want to avoid creating a promise for all jsx nodes.
+        const trackFn = stack.pop() as () => StackValue;
+        await retryOnPromise(() => stack.push(trackFn()));
+        continue;
       } else if (typeof value === 'function') {
         if (value === Promise) {
           stack.push(await (stack.pop() as Promise<JSXOutput>));
@@ -78,7 +94,7 @@ export async function _walkJSX(
         await (value as StackFn).apply(ssr);
         continue;
       }
-      await processJSXNode(ssr, enqueue, value as JSXOutput, {
+      processJSXNode(ssr, enqueue, value as JSXOutput, {
         styleScoped: options.currentStyleScoped,
         parentComponentFrame: options.parentComponentFrame,
       });
@@ -87,7 +103,7 @@ export async function _walkJSX(
   await drain();
 }
 
-async function processJSXNode(
+function processJSXNode(
   ssr: SSRContainer,
   enqueue: (value: StackValue) => void,
   value: JSXOutput,
@@ -114,9 +130,8 @@ async function processJSXNode(
       ssr.openFragment(isDev ? [DEBUG_TYPE, VirtualType.WrappedSignal] : EMPTY_ARRAY);
       const signalNode = ssr.getLastNode();
       enqueue(ssr.closeFragment);
-      await retryOnPromise(() => {
-        enqueue(trackSignalAndAssignHost(value, signalNode, EffectProperty.VNODE, ssr));
-      });
+      enqueue(() => trackSignalAndAssignHost(value, signalNode, EffectProperty.VNODE, ssr));
+      enqueue(MaybeAsyncSignal);
     } else if (isPromise(value)) {
       ssr.openFragment(isDev ? [DEBUG_TYPE, VirtualType.Awaited] : EMPTY_ARRAY);
       enqueue(ssr.closeFragment);