Skip to content

Commit 783adea

Browse files
committed
fix(plugin): don't import node:fs in browser
1 parent 0d1e8f3 commit 783adea

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

packages/qwik/src/optimizer/src/plugins/plugin.ts

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -136,15 +136,20 @@ export function createQwikPlugin(optimizerOptions: OptimizerOptions = {}) {
136136
if (!internalOptimizer) {
137137
internalOptimizer = await createOptimizer(optimizerOptions);
138138
lazyNormalizePath = makeNormalizePath(internalOptimizer.sys);
139-
try {
140-
// only try once, don't spam the console
141-
if (maybeFs === undefined) {
142-
maybeFs = await internalOptimizer.sys.dynamicImport('node:fs');
139+
if (
140+
internalOptimizer.sys.env !== 'browsermain' &&
141+
internalOptimizer.sys.env !== 'webworker'
142+
) {
143+
try {
144+
// only try once, don't spam the console
145+
if (maybeFs === undefined) {
146+
maybeFs = await internalOptimizer.sys.dynamicImport('node:fs');
147+
}
148+
} catch {
149+
// eslint-disable-next-line no-console
150+
console.log('node:fs not available, disabling automatic manifest reading');
151+
maybeFs = null;
143152
}
144-
} catch {
145-
// eslint-disable-next-line no-console
146-
console.log('node:fs not available, disabling automatic manifest reading');
147-
maybeFs = null;
148153
}
149154
}
150155
};

packages/qwik/src/optimizer/src/plugins/utils.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import type { OptimizerSystem } from '../types';
22

33
export async function findDepPkgJsonPath(sys: OptimizerSystem, dep: string, parent: string) {
4+
if (sys.env === 'browsermain' || sys.env === 'webworker') {
5+
return undefined;
6+
}
47
const fs: typeof import('fs') = await sys.dynamicImport('node:fs');
58
let root = parent;
69
while (root) {

0 commit comments

Comments
 (0)