feat(cursors): better unit chore-execution test output

Author: Varixo

packages/qwik/src/core/reactive-primitives/impl/signal.unit.tsx

@@ -1,6 +1,6 @@
 import { $, _wrapProp, isBrowser } from '@qwik.dev/core';
 import { createDocument } from '@qwik.dev/core/testing';
-import { afterEach, beforeEach, describe, expect, expectTypeOf, it, vi } from 'vitest';
+import { afterEach, beforeEach, describe, expect, expectTypeOf, it } from 'vitest';
 import { getDomContainer } from '../../client/dom-container';
 import { implicit$FirstArg } from '../../shared/qrl/implicit_dollar';
 import { inlinedQrl } from '../../shared/qrl/qrl';

packages/qwik/src/core/shared/cursor/chore-execution.unit.ts

@@ -53,7 +53,9 @@ vi.mock('../component-execution', () => ({
 
 vi.mock('../utils/styles', () => ({
   serializeAttribute: vi.fn((property: string, value: any) => {
-    if (value == null) return null;
+    if (value == null) {
+      return null;
+    }
     return String(value);
   }),
 }));
@@ -397,9 +399,13 @@ describe('executeComponentChore', () => {
       throw error;
     });
 
+    const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+
     executeComponentChore(vNode, container, journal, cursor);
 
     expect(container.handleError).toHaveBeenCalledWith(error, vNode);
+
+    consoleErrorSpy.mockRestore();
   });
 
   it('should return promise if execution is async', async () => {

packages/qwik/src/core/shared/cursor/cursor-queue.ts

@@ -11,9 +11,9 @@ import type { Cursor } from './cursor';
 import { getCursorData } from './cursor-props';
 
 /** Global cursor queue array. Cursors are sorted by priority. */
-let globalCursorQueue: Cursor[] = [];
+const globalCursorQueue: Cursor[] = [];
 
-let pausedCursorQueue: Cursor[] = [];
+const pausedCursorQueue: Cursor[] = [];
 
 /**
  * Adds a cursor to the global queue. If the cursor already exists, it's removed and re-added to
@@ -108,26 +108,3 @@ export function removeCursorFromQueue(
     globalCursorQueue.splice(index, 1);
   }
 }
-
-/**
- * Checks if the global cursor queue is empty.
- *
- * @returns True if the queue is empty
- */
-export function isCursorQueueEmpty(): boolean {
-  return globalCursorQueue.length === 0;
-}
-
-/**
- * Gets the number of cursors in the global queue.
- *
- * @returns The number of cursors
- */
-export function getCursorQueueSize(): number {
-  return globalCursorQueue.length;
-}
-
-/** Clears all cursors from the global queue. */
-export function clearCursorQueue(): void {
-  globalCursorQueue = [];
-}

packages/qwik/src/core/tests/projection.spec.tsx

@@ -25,7 +25,7 @@ import { vnode_getProp, vnode_locate } from '../client/vnode-utils';
 import { HTML_NS, QContainerAttr, QDefaultSlot, SVG_NS } from '../shared/utils/markers';
 import { QContainerValue } from '../shared/types';
 import { VNodeFlags } from '../client/types';
-import { VirtualVNode } from '../client/vnode-impl';
+import { VirtualVNode } from '../shared/vnode/virtual-vnode';
 
 const DEBUG = false;
 
@@ -1589,7 +1589,7 @@ describe.each([
         { debug: DEBUG }
       );
       expect((vNode!.flags & VNodeFlags.Resolved) === VNodeFlags.Resolved).toBe(true);
-      expect(vnode_getProp(vNode, QDefaultSlot, null)).toBeInstanceOf(VirtualVNode);
+      expect(vnode_getProp(vNode!, QDefaultSlot, null)).toBeInstanceOf(VirtualVNode);
     });
   });
 

packages/qwik/src/core/tests/use-visible-task.spec.tsx

@@ -22,6 +22,7 @@ import { delay } from '../shared/utils/promises';
 import { ELEMENT_SEQ } from '../../server/qwik-copy';
 import { Task, TaskFlags } from '../use/use-task';
 import { USE_ON_LOCAL } from '../shared/utils/markers';
+import { vnode_getProp } from '../client/vnode-utils';
 
 const debug = false; //true;
 Error.stackTraceLimit = 100;
@@ -819,21 +820,21 @@ describe.each([
       if (render === ssrRenderToDom) {
         await trigger(document.body, 'div', 'qvisible');
       }
-      const seq = vNode!.getProp<any[]>(ELEMENT_SEQ, container.$getObjectById$)!;
+      const seq = vnode_getProp<any[]>(vNode!, ELEMENT_SEQ, container.$getObjectById$)!;
       const task = seq.find((task) => task instanceof Task)!;
       expect((task.$flags$ & TaskFlags.EVENTS_REGISTERED) === TaskFlags.EVENTS_REGISTERED).toBe(
         false
       );
       if (render === ssrRenderToDom) {
         // only on SSR after resuming we have no useOn props
-        expect(vNode!.getProp(USE_ON_LOCAL, null)).toBeNull();
+        expect(vnode_getProp<any>(vNode!, USE_ON_LOCAL, null)).toBeNull();
       }
 
       await trigger(document.body, 'button', 'click');
       expect((task.$flags$ & TaskFlags.EVENTS_REGISTERED) === TaskFlags.EVENTS_REGISTERED).toBe(
         true
       );
-      expect(vNode!.getProp(USE_ON_LOCAL, null)).not.toBeNull();
+      expect(vnode_getProp<any>(vNode!, USE_ON_LOCAL, null)).not.toBeNull();
     });
 
     it('#1717 - custom hooks should work', async () => {