Skip to content

Commit 80f318d

Browse files
authored
fix(rollup): call fileName hook with assetsDir and debug:true (#7638)
* fix(rollup): call fileName hook with assetsDir and debug:true * chore: changeset
1 parent 97ca152 commit 80f318d

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

.changeset/gold-colts-change.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@builder.io/qwik': patch
3+
---
4+
5+
FIX: assetsDir and debug:true will no longer break your application.

packages/qwik/src/optimizer/src/plugins/rollup.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,12 +194,22 @@ export function normalizeRollupOutputOptionsObject(
194194
return `build/${sanitized}.js`;
195195
};
196196
}
197-
// client production output
197+
// client development/debug output
198+
const getFilePath = (fileNamePattern: string | ((info: Rollup.PreRenderedChunk) => string)) =>
199+
typeof fileNamePattern === 'string'
200+
? useAssetsDir
201+
? `${opts.assetsDir}/${fileNamePattern}`
202+
: fileNamePattern
203+
: useAssetsDir
204+
? (chunkInfo: Rollup.PreRenderedChunk) =>
205+
`${opts.assetsDir}/${fileNamePattern(chunkInfo)}`
206+
: (chunkInfo: Rollup.PreRenderedChunk) => fileNamePattern(chunkInfo);
207+
198208
if (!outputOpts.entryFileNames) {
199-
outputOpts.entryFileNames = useAssetsDir ? `${opts.assetsDir}/${fileName}` : fileName;
209+
outputOpts.entryFileNames = getFilePath(fileName);
200210
}
201211
if (!outputOpts.chunkFileNames) {
202-
outputOpts.chunkFileNames = useAssetsDir ? `${opts.assetsDir}/${fileName}` : fileName;
212+
outputOpts.chunkFileNames = getFilePath(fileName);
203213
}
204214
} else if (opts.buildMode === 'production') {
205215
// server production output

0 commit comments

Comments
 (0)