fix(core): don't use illegal script type

type must be valid MIME type if not 'module' etc

Author: wmertens

packages/qwik/src/core/shared/component-execution.ts

@@ -299,20 +299,7 @@ function injectPlaceholderElement(
   return [null, jsx];
 }
 
-/**
- * Creates a <script> element with a placeholder type.
- *
- * @returns A <script> element with a placeholder type.
- */
+/** @returns An empty <script> element for adding qwik metadata attributes to */
 function createPlaceholderScriptNode(): JSXNodeInternal<string> {
-  return new JSXNodeImpl(
-    'script',
-    {},
-    {
-      type: 'placeholder',
-      hidden: '',
-    },
-    null,
-    3
-  );
+  return new JSXNodeImpl('script', {}, { hidden: '' }, null, 3);
 }

packages/qwik/src/core/tests/use-on.spec.tsx

@@ -242,7 +242,7 @@ describe.each([
       expect(vNode).toMatchVDOM(
         <Component ssr-required>
           <Fragment ssr-required>
-            Count: <Signal ssr-required>{'123'}</Signal>!<script type="placeholder" hidden></script>
+            Count: <Signal ssr-required>{'123'}</Signal>!<script hidden></script>
           </Fragment>
         </Component>
       );
@@ -251,7 +251,7 @@ describe.each([
       expect(vNode).toMatchVDOM(
         <Component ssr-required>
           <Fragment ssr-required>
-            Count: <Signal ssr-required>{'124'}</Signal>!<script type="placeholder" hidden></script>
+            Count: <Signal ssr-required>{'124'}</Signal>!<script hidden></script>
           </Fragment>
         </Component>
       );
@@ -441,7 +441,7 @@ describe.each([
       expect(vNode).toMatchVDOM(
         <Component ssr-required>
           <Fragment ssr-required>
-            Count: <Signal ssr-required>{'123'}</Signal>!<script type="placeholder" hidden></script>
+            Count: <Signal ssr-required>{'123'}</Signal>!<script hidden></script>
           </Fragment>
         </Component>
       );
@@ -450,7 +450,7 @@ describe.each([
       expect(vNode).toMatchVDOM(
         <Component ssr-required>
           <Fragment ssr-required>
-            Count: <Signal ssr-required>{'124'}</Signal>!<script type="placeholder" hidden></script>
+            Count: <Signal ssr-required>{'124'}</Signal>!<script hidden></script>
           </Fragment>
         </Component>
       );
@@ -857,7 +857,7 @@ describe.each([
               <Component ssr-required>
                 <div>test</div>
               </Component>
-              <script type="placeholder" hidden></script>
+              <script hidden></script>
             </Component>
           </Component>
         </Component>
@@ -888,7 +888,7 @@ describe.each([
               <Projection ssr-required>
                 <div>test</div>
               </Projection>
-              <script type="placeholder" hidden></script>
+              <script hidden></script>
             </Component>
           </Component>
         </Component>

packages/qwik/src/core/tests/use-visible-task.spec.tsx

@@ -242,7 +242,7 @@ describe.each([
       <Component ssr-required>
         <Fragment ssr-required>
           <Signal ssr-required>{'run'}</Signal>
-          <script type="placeholder" hidden></script>
+          <script hidden></script>
         </Fragment>
       </Component>
     );
@@ -264,7 +264,7 @@ describe.each([
       <Component ssr-required>
         <Fragment ssr-required>
           <Signal ssr-required>{'run'}</Signal>
-          <script type="placeholder" hidden></script>
+          <script hidden></script>
         </Fragment>
         <Fragment ssr-required>
           <Signal ssr-required>{'run'}</Signal>
@@ -288,7 +288,7 @@ describe.each([
     expect(vNode).toMatchVDOM(
       <Component ssr-required>
         <Fragment ssr-required>
-          <script type="placeholder" hidden></script>
+          <script hidden></script>
         </Fragment>
       </Component>
     );