test: request-event redirect

Author: maiieul

packages/qwik-city/src/middleware/request-handler/request-event.unit.ts

@@ -0,0 +1,124 @@
+import { describe, it, expect, vi } from 'vitest';
+import { createRequestEvent } from './request-event';
+import { RedirectMessage } from './redirect-handler';
+import type { ServerRequestEvent, QwikSerializer } from './types';
+
+const mockQwikSerializer: QwikSerializer = {
+  _deserializeData: vi.fn(),
+  _serializeData: vi.fn(),
+  _verifySerializable: vi.fn(),
+};
+
+function createMockServerRequestEvent(url = 'http://localhost:3000/test'): ServerRequestEvent {
+  const mockRequest = new Request(url);
+
+  return {
+    mode: 'server',
+    url: new URL(url),
+    locale: undefined,
+    platform: {},
+    request: mockRequest,
+    env: {
+      get: vi.fn(),
+    },
+    getClientConn: vi.fn(() => ({ ip: '127.0.0.1' })),
+    getWritableStream: vi.fn(() => {
+      const writer = {
+        write: vi.fn(),
+        close: vi.fn(),
+      };
+      return {
+        getWriter: () => writer,
+        locked: false,
+        pipeTo: vi.fn(),
+      } as any;
+    }),
+  };
+}
+
+describe('request-event redirect', () => {
+  it('should not cache redirects by default', () => {
+    const serverRequestEv = createMockServerRequestEvent();
+    const requestEv = createRequestEvent(
+      serverRequestEv,
+      null,
+      [],
+      true,
+      '/',
+      mockQwikSerializer,
+      vi.fn()
+    );
+
+    requestEv.headers.set('Cache-Control', 'max-age=3600, public');
+
+    const result = requestEv.redirect(301, '/new-location');
+
+    expect(result).toBeInstanceOf(RedirectMessage);
+    expect(requestEv.headers.get('Location')).toBe('/new-location');
+    expect(requestEv.headers.get('Cache-Control')).toBeNull();
+    expect(requestEv.status()).toBe(301);
+  });
+
+  it('should set Cache-Control to no-store for redirects with status > 301', () => {
+    const serverRequestEv = createMockServerRequestEvent();
+    const requestEv = createRequestEvent(
+      serverRequestEv,
+      null,
+      [],
+      true,
+      '/',
+      mockQwikSerializer,
+      vi.fn()
+    );
+
+    const result = requestEv.redirect(307, '/new-location');
+
+    expect(result).toBeInstanceOf(RedirectMessage);
+    expect(requestEv.headers.get('Location')).toBe('/new-location');
+    expect(requestEv.headers.get('Cache-Control')).toBe('no-store');
+    expect(requestEv.status()).toBe(307);
+  });
+
+  it('should fix invalid redirect URLs with multiple slashes', () => {
+    const serverRequestEv = createMockServerRequestEvent();
+    const requestEv = createRequestEvent(
+      serverRequestEv,
+      null,
+      [],
+      true,
+      '/',
+      mockQwikSerializer,
+      vi.fn()
+    );
+
+    const consoleSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+
+    const result = requestEv.redirect(302, '/path//with///multiple////slashes');
+
+    expect(result).toBeInstanceOf(RedirectMessage);
+    expect(requestEv.headers.get('Location')).toBe('/path/with/multiple/slashes');
+    expect(consoleSpy).toHaveBeenCalledWith(
+      'Redirect URL /path//with///multiple////slashes is invalid, fixing to /path/with/multiple/slashes'
+    );
+  });
+
+  it('should throw error when trying to redirect after headers are sent', () => {
+    const serverRequestEv = createMockServerRequestEvent();
+    const requestEv = createRequestEvent(
+      serverRequestEv,
+      null,
+      [],
+      true,
+      '/',
+      mockQwikSerializer,
+      vi.fn()
+    );
+
+    // Trigger getWritableStream to simulate headers being sent
+    requestEv.getWritableStream();
+
+    expect(() => {
+      requestEv.redirect(302, '/should-fail');
+    }).toThrow('Response already sent');
+  });
+});