Skip to content

Commit a8e2cd5

Browse files
committed
fix: send only minimal required data for lazy loaders data
1 parent 031cc1f commit a8e2cd5

File tree

1 file changed

+18
-9
lines changed

1 file changed

+18
-9
lines changed

packages/qwik-router/src/middleware/request-handler/resolve-request-handlers.ts

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,9 @@ export async function renderQData(requestEv: RequestEvent) {
594594
let loaders = getRequestLoaders(requestEv);
595595
const selectedLoaderIds = requestEv.query.getAll(QLOADER_KEY);
596596

597-
if (selectedLoaderIds.length > 0) {
597+
const hasCustomLoaders = selectedLoaderIds.length > 0;
598+
599+
if (hasCustomLoaders) {
598600
const selectedLoaders: Record<string, unknown> = {};
599601
for (const loaderId of selectedLoaderIds) {
600602
const loader = loaders[loaderId];
@@ -603,14 +605,21 @@ export async function renderQData(requestEv: RequestEvent) {
603605
loaders = selectedLoaders;
604606
}
605607

606-
const qData: ClientPageData = {
607-
loaders,
608-
action: requestEv.sharedMap.get(RequestEvSharedActionId),
609-
status: status !== 200 ? status : 200,
610-
href: getPathname(requestEv.url, trailingSlash),
611-
redirect: redirectLocation ?? undefined,
612-
isRewrite: requestEv.sharedMap.get(RequestEvIsRewrite),
613-
};
608+
const qData: ClientPageData = hasCustomLoaders
609+
? {
610+
// send minimal data to the client
611+
loaders,
612+
status: status !== 200 ? status : 200,
613+
href: getPathname(requestEv.url, trailingSlash),
614+
}
615+
: {
616+
loaders,
617+
action: requestEv.sharedMap.get(RequestEvSharedActionId),
618+
status: status !== 200 ? status : 200,
619+
href: getPathname(requestEv.url, trailingSlash),
620+
redirect: redirectLocation ?? undefined,
621+
isRewrite: requestEv.sharedMap.get(RequestEvIsRewrite),
622+
};
614623
const writer = requestEv.getWritableStream().getWriter();
615624
const qwikSerializer = (requestEv as RequestEventInternal)[RequestEvQwikSerializer];
616625
// write just the page json data to the response body

0 commit comments

Comments
 (0)