chore(ci): always deploy docs (#7485)

Author: wmertens

.github/workflows/deploy-docs.yml

@@ -26,6 +26,7 @@ jobs:
         id: check-artifact
         uses: actions/github-script@v7
         with:
+          retries: 3
           script: |
             try {
               const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
@@ -35,21 +36,17 @@ jobs:
               });
               const hasDocsArtifact = artifacts.data.artifacts.some(a => a.name === 'artifact-docs');
               core.setOutput('has-docs', hasDocsArtifact);
-              // Always return success from this script
-              return true;
             } catch (error) {
               console.error('Error checking for artifacts:', error);
               core.setOutput('has-docs', false);
-              // Always return success from this script
-              return true;
             }
 
       - name: Checkout code
-        if: ${{ steps.check-artifact.outputs['has-docs'] == true }}
+        if: ${{ steps.check-artifact.outputs.has-docs == 'true' }}
         uses: actions/checkout@v4
 
       - name: Download docs artifact
-        if: ${{ steps.check-artifact.outputs['has-docs'] == true }}
+        if: ${{ steps.check-artifact.outputs.has-docs == 'true' }}
         uses: actions/download-artifact@v4
         with:
           name: artifact-docs
@@ -58,7 +55,7 @@ jobs:
           path: packages/docs
 
       - name: Verify dist directory exists
-        if: ${{ steps.check-artifact.outputs['has-docs'] == true }}
+        if: ${{ steps.check-artifact.outputs.has-docs == 'true' }}
         run: |
           ls -la packages/docs
           if [ ! -d "packages/docs/dist" ]; then
@@ -69,7 +66,7 @@ jobs:
 
       # not the official version, so be careful when updating
       - name: Deploy to Cloudflare Pages
-        if: ${{ steps.check-artifact.outputs['has-docs'] == true }}
+        if: ${{ steps.check-artifact.outputs.has-docs == 'true' }}
         uses: AdrianGonz97/refined-cf-pages-action@6c0d47ff7c97c48fa702b6d9f71f7e3a7c30c7d8
         with:
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
@@ -79,5 +76,5 @@ jobs:
           githubToken: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Skip message when no docs artifact
-        if: ${{ steps.check-artifact.outputs['has-docs'] != true }}
+        if: ${{ steps.check-artifact.outputs.has-docs != 'true' }}
         run: echo "No docs artifact found, skipping deployment"