fix(router): more external deps, remove core from vite plugin

still gets core via dev server

Author: wmertens

package.json

@@ -177,6 +177,7 @@
     "overrides": {
       "@builder.io/qwik": "npm:@qwik.dev/core@*",
       "@builder.io/qwik-city": "npm:@qwik.dev/router",
+      "@types/estree": "1.0.8",
       "prettier": "3.6.2",
       "typescript": "5.8.3",
       "vfile": "6.0.3"

packages/docs/package.json

@@ -19,10 +19,10 @@
     "@qwik.dev/partytown": "0.11.2",
     "@qwik.dev/react": "workspace:*",
     "@qwik.dev/router": "workspace:*",
-    "@shikijs/colorized-brackets": "3.9.1",
-    "@shikijs/rehype": "3.9.1",
-    "@shikijs/transformers": "3.9.1",
-    "@shikijs/types": "3.9.1",
+    "@shikijs/colorized-brackets": "3.9.2",
+    "@shikijs/rehype": "3.9.2",
+    "@shikijs/transformers": "3.9.2",
+    "@shikijs/types": "3.9.2",
     "@supabase/supabase-js": "2.53.0",
     "@tailwindcss/vite": "4.1.11",
     "@types/leaflet": "1.9.20",
@@ -44,7 +44,7 @@
     "qwik-image": "0.0.16",
     "react": "18.3.1",
     "react-dom": "18.3.1",
-    "shiki": "3.9.1",
+    "shiki": "3.9.2",
     "snarkdown": "2.0.0",
     "tailwindcss": "4.1.11",
     "terser": "5.43.1",

packages/qwik-router/package.json

@@ -4,44 +4,42 @@
   "version": "2.0.0-beta.7",
   "bugs": "https://github.com/QwikDev/qwik/issues",
   "dependencies": {
+    "@azure/functions": "3.5.1",
     "@mdx-js/mdx": "^3.1.0",
+    "@netlify/edge-functions": "^2.17.0",
     "@types/mdx": "^2.0.13",
+    "estree-util-value-to-estree": "^3.4.0",
+    "github-slugger": "^2.0.0",
+    "hast-util-heading-rank": "^2.1.1",
+    "hast-util-to-string": "^2.0.0",
+    "kleur": "^4.1.5",
+    "marked": "^12.0.2",
+    "mdast-util-mdx": "^3.0.0",
+    "refractor": "^4.8.1",
+    "rehype-autolink-headings": "^7.1.0",
+    "remark-frontmatter": "^5.0.0",
+    "remark-gfm": "^4.0.1",
+    "set-cookie-parser": "^2.7.1",
     "source-map": "^0.7.4",
     "svgo": "^3.3.2",
-    "undici": "*",
+    "typescript": "^5.8.3",
+    "unified": "^11.0.5",
+    "unist-util-visit": "^5.0.0",
     "valibot": ">=0.36.0 <2",
-    "vfile": "6.0.3",
+    "vfile": "^6.0.3",
     "vite-imagetools": "^7.1.0",
-    "zod": "3.25.48"
+    "yaml": "^2.6.1",
+    "zod": "^3.25.40"
   },
   "devDependencies": {
-    "@azure/functions": "3.5.1",
-    "@microsoft/api-extractor": "7.52.10",
-    "@netlify/edge-functions": "2.17.0",
     "@qwik.dev/core": "workspace:*",
+    "@microsoft/api-extractor": "7.52.10",
     "@types/mdast": "4.0.4",
     "@types/node": "24.2.1",
     "@types/refractor": "3.4.1",
     "@types/set-cookie-parser": "2.4.10",
-    "estree-util-value-to-estree": "3.4.0",
-    "github-slugger": "2.0.0",
-    "hast-util-heading-rank": "2.1.1",
-    "hast-util-to-string": "2.0.0",
-    "kleur": "4.1.5",
-    "marked": "12.0.2",
-    "mdast-util-mdx": "3.0.0",
-    "refractor": "4.8.1",
-    "rehype-autolink-headings": "7.1.0",
-    "remark-frontmatter": "5.0.0",
-    "remark-gfm": "4.0.1",
-    "set-cookie-parser": "2.7.1",
     "tsm": "2.3.0",
-    "typescript": "5.8.3",
-    "unified": "11.0.5",
-    "unist-util-visit": "5.0.0",
-    "uvu": "0.5.6",
-    "vite": "7.1.0",
-    "yaml": "2.6.1"
+    "uvu": "0.5.6"
   },
   "engines": {
     "node": "^18.17.0 || ^20.3.0 || >=21.0.0"
@@ -186,6 +184,10 @@
   "homepage": "https://qwik.dev/",
   "license": "MIT",
   "main": "./lib/index.qwik.mjs",
+  "peerDependencies": {
+    "@qwik.dev/core": "workspace:^",
+    "vite": ">=5 <8"
+  },
   "publishConfig": {
     "access": "public"
   },

packages/qwik-router/src/adapters/netlify-edge/vite/index.ts

@@ -1,4 +1,3 @@
-import { basePathname } from '@qwik-router-config';
 import type { SsgRenderOptions } from 'packages/qwik-router/src/ssg';
 import fs, { existsSync } from 'node:fs';
 import { join } from 'node:path';
@@ -39,7 +38,7 @@ export function netlifyEdgeAdapter(opts: NetlifyEdgeAdapterOptions = {}): any {
       };
     },
 
-    async generate({ serverOutDir }) {
+    async generate({ serverOutDir, basePathname }) {
       if (opts.functionRoutes !== false) {
         // https://docs.netlify.com/edge-functions/create-integration/#generate-declarations
 

packages/qwik-router/src/runtime/src/deepFreeze.ts

@@ -0,0 +1,13 @@
+export const deepFreeze = (obj: any) => {
+  if (obj == null) {
+    return obj;
+  }
+  Object.getOwnPropertyNames(obj).forEach((prop) => {
+    const value = obj[prop];
+    // we assume that a frozen object is a circular reference and fully deep frozen
+    if (value && typeof value === 'object' && !Object.isFrozen(value)) {
+      deepFreeze(value);
+    }
+  });
+  return Object.freeze(obj);
+};

packages/qwik-router/src/runtime/src/routing.ts

@@ -11,7 +11,7 @@ import {
   RouteDataProp,
   type RouteModule,
 } from './types';
-import { deepFreeze } from './utils';
+import { deepFreeze } from './deepFreeze';
 
 /** LoadRoute() runs in both client and server. */
 export const loadRoute = async (

packages/qwik-router/src/runtime/src/server-functions.ts

@@ -64,7 +64,7 @@ import type {
 import { useAction, useLocation, useQwikRouterEnv } from './use-functions';
 
 import type { FormSubmitCompletedDetail } from './form-component';
-import { deepFreeze } from './utils';
+import { deepFreeze } from './deepFreeze';
 
 /** @internal */
 export const routeActionQrl = ((

packages/qwik-router/src/runtime/src/utils.ts

@@ -88,20 +88,6 @@ export const isPromise = (value: any): value is Promise<any> => {
   return value && typeof value.then === 'function';
 };
 
-export const deepFreeze = (obj: any) => {
-  if (obj == null) {
-    return obj;
-  }
-  Object.getOwnPropertyNames(obj).forEach((prop) => {
-    const value = obj[prop];
-    // we assume that a frozen object is a circular reference and fully deep frozen
-    if (value && typeof value === 'object' && !Object.isFrozen(value)) {
-      deepFreeze(value);
-    }
-  });
-  return Object.freeze(obj);
-};
-
 export const createLoaderSignal = (
   loadersObject: Record<string, unknown>,
   loaderId: string,

packages/qwik-router/src/ssg/index.ts

@@ -10,7 +10,7 @@ import type { SsgOptions, SsgRenderOptions, SsgResult } from './types';
  */
 export async function generate(opts: SsgOptions) {
   const ssgPlatform = await getEntryModule();
-  const result: SsgResult = await ssgPlatform.generate(opts);
+  const result: SsgResult = (await ssgPlatform.generate(opts)) as any;
   return result;
 }
 
@@ -20,27 +20,16 @@ export type {
   SsgResult as StaticGenerateResult,
 };
 
-function getEntryModulePath() {
+function getEntryModule() {
   if (isDeno()) {
-    return './deno.mjs';
+    return import('./deno');
   }
-  if (isNode() || isBun()) {
-    if (isCjs()) {
-      return './node.cjs';
-    }
-    return './node.mjs';
+  if (isBun() || isNode()) {
+    return import('./node');
   }
   throw new Error(`Unsupported platform`);
 }
 
-function getEntryModule() {
-  const entryModule = getEntryModulePath();
-  if (isCjs()) {
-    return require(entryModule);
-  }
-  return import(entryModule);
-}
-
 function isDeno() {
   return typeof Deno !== 'undefined';
 }
@@ -53,10 +42,5 @@ function isNode() {
   return !isBun() && !isDeno() && typeof process !== 'undefined' && !!process.versions?.node;
 }
 
-function isCjs() {
-  const req = 'require';
-  return isNode() && typeof globalThis[req] === 'function';
-}
-
 declare const Deno: any;
 declare const Bun: any;

packages/qwik/src/optimizer/src/plugins/vite.ts

@@ -356,13 +356,7 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
     async configResolved(config) {
       basePathname = config.base;
       if (!(basePathname.startsWith('/') && basePathname.endsWith('/'))) {
-        // TODO v2: make this an error
-        console.error(
-          `warning: vite's config.base must begin and end with /. This will be an error in v2. If you have a valid use case, please open an issue.`
-        );
-        if (!basePathname.endsWith('/')) {
-          basePathname += '/';
-        }
+        throw new Error(`vite's config.base must begin and end with /`);
       }
       const useSourcemap = !!config.build.sourcemap;
       if (useSourcemap && qwikViteOpts.optimizerOptions?.sourcemap === undefined) {