Skip to content

Commit ba136ba

Browse files
Varixowmertens
authored andcommitted
feat: remove redirect from qdata
1 parent 0f7d2de commit ba136ba

File tree

5 files changed

+6
-18
lines changed

5 files changed

+6
-18
lines changed

packages/qwik-router/src/middleware/request-handler/qdata-endpoints.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { IsQData } from './user-response';
99
export interface QData {
1010
status: number;
1111
href: string;
12-
redirect?: string;
1312
isRewrite?: boolean;
1413
}
1514

@@ -24,14 +23,12 @@ export async function qDataHandler(requestEv: RequestEvent) {
2423
}
2524

2625
const status = requestEv.status();
27-
const redirectLocation = requestEv.headers.get('Location');
2826

2927
requestEv.headers.set('Content-Type', 'application/json; charset=utf-8');
3028

3129
const qData: QData = {
3230
status,
3331
href: getPathname(requestEv.url),
34-
redirect: redirectLocation ?? undefined,
3532
isRewrite: requestEv.sharedMap.get(RequestEvIsRewrite),
3633
};
3734

packages/qwik-router/src/runtime/src/constants.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
1-
import type { ClientPageData } from './types';
21
import type { SerializationStrategy } from '@qwik.dev/core/internal';
32

43
export const MODULE_CACHE = /*#__PURE__*/ new WeakMap<any, any>();
54

6-
export const CLIENT_DATA_CACHE = new Map<string, Promise<ClientPageData | undefined>>();
7-
85
export const QACTION_KEY = 'qaction';
96
export const QACTION_FORMAT_KEY = 'format';
107

packages/qwik-router/src/runtime/src/qwik-router-component.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {
3030
type SerializationStrategy,
3131
} from '@qwik.dev/core/internal';
3232
import { clientNavigate } from './client-navigate';
33-
import { CLIENT_DATA_CACHE, DEFAULT_LOADERS_SERIALIZATION_STRATEGY, Q_ROUTE } from './constants';
33+
import { DEFAULT_LOADERS_SERIALIZATION_STRATEGY, Q_ROUTE } from './constants';
3434
import {
3535
ContentContext,
3636
ContentInternalContext,
@@ -555,7 +555,6 @@ export const useQwikRouter = (props?: QwikRouterProps) => {
555555
}
556556
}
557557
}
558-
CLIENT_DATA_CACHE.clear();
559558

560559
const win = window as ClientSPAWindow;
561560
if (!win._qRouterSPA) {

packages/qwik-router/src/runtime/src/types.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import type {
1818
} from '@qwik.dev/router/middleware/request-handler';
1919
import type * as v from 'valibot';
2020
import type * as z from 'zod';
21+
import type { QData } from '../../middleware/request-handler/qdata-endpoints';
2122
import type { Q_ROUTE } from './constants';
2223

2324
export type {
@@ -343,10 +344,9 @@ export interface ClientActionData {
343344
data: unknown;
344345
}
345346

346-
export interface ClientPageData extends Omit<EndpointResponse, 'loadersSerializationStrategy'> {
347-
href: string;
348-
redirect?: string;
349-
isRewrite?: boolean;
347+
export interface ClientPageData extends QData {
348+
loaders: Record<string, unknown>;
349+
action?: ClientActionData;
350350
}
351351

352352
export interface LoaderData {

packages/qwik-router/src/runtime/src/use-endpoint.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,6 @@ export const loadClientData = async (
8585
location.href = url.href;
8686
return;
8787
}
88-
if (clientData.redirect) {
89-
// server function asked for redirect
90-
location.href = clientData.redirect;
91-
}
9288
return clientData;
9389
});
9490
} else {
@@ -111,8 +107,7 @@ export const loadClientData = async (
111107
: undefined,
112108
href: v?.href ?? pagePathname,
113109
status: v?.status ?? 200,
114-
redirect: v?.redirect,
115-
isRewrite: v?.isRewrite,
110+
isRewrite: v?.isRewrite ?? false,
116111
} satisfies ClientPageData;
117112
});
118113
};

0 commit comments

Comments
 (0)