chore: add version check code to not show warning on >=4.52

Author: maiieul

packages/qwik/src/optimizer/src/plugins/rollup.ts

@@ -17,6 +17,7 @@ import {
   type QwikPlugin,
   type QwikPluginOptions,
 } from './plugin';
+import { findDepPkgJsonPath } from './utils';
 
 type QwikRollupPluginApi = {
   getOptimizer: () => Optimizer;
@@ -75,7 +76,7 @@ export function qwikRollup(qwikRollupOpts: QwikRollupPluginOptions = {}): any {
     },
 
     outputOptions(rollupOutputOpts) {
-      return normalizeRollupOutputOptionsObject(qwikPlugin, rollupOutputOpts, false);
+      return normalizeRollupOutputOptionsObject(qwikPlugin, rollupOutputOpts, false) as any;
     },
 
     async buildStart() {
@@ -150,11 +151,11 @@ export function normalizeRollupOutputOptions(
   };
 }
 
-export function normalizeRollupOutputOptionsObject(
+export async function normalizeRollupOutputOptionsObject(
   qwikPlugin: QwikPlugin,
   rollupOutputOptsObj: Rollup.OutputOptions | undefined,
   useAssetsDir: boolean
-): Rollup.OutputOptions {
+): Promise<Rollup.OutputOptions> {
   const outputOpts: Rollup.OutputOptions = { ...rollupOutputOptsObj };
   const opts = qwikPlugin.getOptions();
   const optimizer = qwikPlugin.getOptimizer();
@@ -252,10 +253,32 @@ export function normalizeRollupOutputOptionsObject(
    */
   outputOpts.hoistTransitiveImports = false;
 
-  outputOpts.onlyExplicitManualChunks = true;
-  console.warn(
-    `⚠️ For the latest and greatest, we recommend to install rollup@^4.52.0 directly in your project. It enables the new Rollup \`outputOpts.onlyExplicitManualChunks\` feature flag, which improves preloading performance and reduces cache invalidation for a snappier user experience.`
-  );
+  const userPkgJsonPath = await findDepPkgJsonPath(optimizer.sys, 'rollup', optimizer.sys.cwd());
+  if (userPkgJsonPath) {
+    try {
+      const fs: typeof import('fs') = await optimizer.sys.dynamicImport('node:fs');
+      const pkgJsonStr = await fs.promises.readFile(userPkgJsonPath, 'utf-8');
+      const pkgJson = JSON.parse(pkgJsonStr);
+      const version = String(pkgJson?.version || '');
+      const [major, minor, patch] = version.split('.').map((n: string) => parseInt(n, 10)) as [
+        number,
+        number,
+        number,
+      ];
+      const isGte452 =
+        Number.isFinite(major) &&
+        (major > 4 || (major === 4 && (minor > 52 || (minor === 52 && (patch || 0) >= 0))));
+      if (isGte452) {
+        outputOpts.onlyExplicitManualChunks = true;
+      } else {
+        console.warn(
+          `⚠️ For the latest and greatest, we recommend to install rollup@^4.52.0 directly in your project. It enables the new Rollup \`outputOpts.onlyExplicitManualChunks\` feature flag, which improves preloading performance and reduces cache invalidation for a snappier user experience.`
+        );
+      }
+    } catch {
+      // If we cannot determine the installed Rollup version, avoid warning
+    }
+  }
 
   return outputOpts;
 }

packages/qwik/src/optimizer/src/plugins/utils.ts

@@ -0,0 +1,23 @@
+import type { OptimizerSystem } from '../types';
+
+export async function findDepPkgJsonPath(sys: OptimizerSystem, dep: string, parent: string) {
+  const fs: typeof import('fs') = await sys.dynamicImport('node:fs');
+  let root = parent;
+  while (root) {
+    const pkg = sys.path.join(root, 'node_modules', dep, 'package.json');
+    try {
+      await fs.promises.access(pkg);
+      // use 'node:fs' version to match 'vite:resolve' and avoid realpath.native quirk
+      // https://github.com/sveltejs/vite-plugin-svelte/issues/525#issuecomment-1355551264
+      return fs.promises.realpath(pkg);
+    } catch {
+      //empty
+    }
+    const nextRoot = sys.path.dirname(root);
+    if (nextRoot === root) {
+      break;
+    }
+    root = nextRoot;
+  }
+  return undefined;
+}

packages/qwik/src/optimizer/src/plugins/vite.ts

@@ -32,6 +32,7 @@ import {
 import { createRollupError, normalizeRollupOutputOptions } from './rollup';
 import { VITE_DEV_CLIENT_QS, configureDevServer, configurePreviewServer } from './vite-dev-server';
 import { parseId } from './vite-utils';
+import { findDepPkgJsonPath } from './utils';
 
 const DEDUPE = [QWIK_CORE_ID, QWIK_JSX_RUNTIME_ID, QWIK_JSX_DEV_RUNTIME_ID];
 
@@ -752,28 +753,6 @@ export async function render(document, rootNode, opts) {
 }`;
 }
 
-async function findDepPkgJsonPath(sys: OptimizerSystem, dep: string, parent: string) {
-  const fs: typeof import('fs') = await sys.dynamicImport('node:fs');
-  let root = parent;
-  while (root) {
-    const pkg = sys.path.join(root, 'node_modules', dep, 'package.json');
-    try {
-      await fs.promises.access(pkg);
-      // use 'node:fs' version to match 'vite:resolve' and avoid realpath.native quirk
-      // https://github.com/sveltejs/vite-plugin-svelte/issues/525#issuecomment-1355551264
-      return fs.promises.realpath(pkg);
-    } catch {
-      //empty
-    }
-    const nextRoot = sys.path.dirname(root);
-    if (nextRoot === root) {
-      break;
-    }
-    root = nextRoot;
-  }
-  return undefined;
-}
-
 const findQwikRoots = async (
   sys: OptimizerSystem,
   packageJsonDir: string