Merge pull request #7368 from QwikDev/v2-fix-backrefs-serialization

fix: signals back refs serialization

Author: wmertens

.changeset/seven-pumpkins-argue.md

@@ -0,0 +1,5 @@
+---
+'@qwik.dev/core': patch
+---
+
+fix: infinity serialization loop

packages/qwik/src/core/shared/shared-serialization.ts

@@ -835,7 +835,7 @@ export const createSerializationContext = (
           discoveredValues.push(v);
         }
         if (obj.$effects$) {
-          discoveredValues.push(...obj.$effects$);
+          discoveredValues.push(obj.$effects$);
         }
         // WrappedSignal uses syncQrl which has no captured refs
         if (obj instanceof WrappedSignal) {
@@ -847,6 +847,7 @@ export const createSerializationContext = (
             discoveredValues.push(obj.$hostElement$);
           }
         } else if (obj instanceof ComputedSignal) {
+          discoverEffectBackRefs(obj[_EFFECT_BACK_REF], discoveredValues);
           discoveredValues.push(obj.$computeQrl$);
         }
       } else if (obj instanceof Task) {
@@ -944,18 +945,7 @@ const discoverEffectBackRefs = (
   discoveredValues: unknown[]
 ) => {
   if (effectsBackRefs) {
-    // We need serialize effect subscriptions with back refs
-    let hasBackRefs = false;
-    for (const [, effect] of effectsBackRefs) {
-      const backRefs = effect[EffectSubscriptionProp.BACK_REF];
-      if (backRefs) {
-        hasBackRefs = true;
-        break;
-      }
-    }
-    if (hasBackRefs) {
-      discoveredValues.push(effectsBackRefs);
-    }
+    discoveredValues.push(effectsBackRefs);
   }
 };
 

packages/qwik/src/core/signal/signal.ts

@@ -32,7 +32,7 @@ import type { OnRenderFn } from '../shared/component.public';
 import { _EFFECT_BACK_REF, NEEDS_COMPUTATION } from './flags';
 import { QError, qError } from '../shared/error/error';
 import { isDomContainer } from '../client/dom-container';
-import type { BackRef } from './signal-cleanup';
+import { type BackRef } from './signal-cleanup';
 import { getSubscriber } from './subscriber';
 
 const DEBUG = false;
@@ -328,7 +328,7 @@ export const triggerEffects = (
  *
  * The value is available synchronously, but the computation is done lazily.
  */
-export class ComputedSignal<T> extends Signal<T> {
+export class ComputedSignal<T> extends Signal<T> implements BackRef {
   /**
    * The compute function is stored here.
    *
@@ -340,6 +340,7 @@ export class ComputedSignal<T> extends Signal<T> {
   // we need the old value to know if effects need running after computation
   $invalid$: boolean = true;
   $forceRunEffects$: boolean = false;
+  [_EFFECT_BACK_REF]: Map<EffectProperty | string, EffectSubscription> | null = null;
 
   constructor(container: Container | null, fn: QRLInternal<() => T>) {
     // The value is used for comparison when signals trigger, which can only happen