fix(ssr): reset factor when needed

Author: wmertens

packages/qwik/src/core/preloader/bundle-graph.ts

@@ -5,7 +5,7 @@ import {
   maxSignificantInverseProbabilityStr,
   maxSimultaneousPreloadsStr,
 } from './constants';
-import { adjustProbabilities, bundles, log, trigger } from './queue';
+import { adjustProbabilities, bundles, log, shouldResetFactor, trigger } from './queue';
 import type { BundleGraph, BundleImport, ImportProbability } from './types';
 import { BundleImportState_None, BundleImportState_Alias } from './types';
 
@@ -22,7 +22,7 @@ const makeBundle = (name: string, deps?: ImportProbability[]) => {
     $name$: name,
     $url$: url,
     $state$: url ? BundleImportState_None : BundleImportState_Alias,
-    $deps$: deps,
+    $deps$: shouldResetFactor ? deps?.map((d) => ({ ...d, $factor$: 1 })) : deps,
     $inverseProbability$: 1,
     $createdTs$: Date.now(),
     $waitedMs$: 0,

packages/qwik/src/core/preloader/queue.ts

@@ -17,6 +17,7 @@ import {
 } from './types';
 
 export const bundles: BundleImports = new Map();
+export let shouldResetFactor: boolean;
 let queueDirty: boolean;
 let preloadCount = 0;
 const queue: BundleImport[] = [];
@@ -32,6 +33,7 @@ export const log = (...args: any[]) => {
 export const resetQueue = () => {
   bundles.clear();
   queueDirty = false;
+  shouldResetFactor = true;
   preloadCount = 0;
   queue.length = 0;
 };
@@ -178,6 +180,7 @@ export const adjustProbabilities = (
   if (bundle.$deps$) {
     seen ||= new Set();
     seen.add(bundle);
+    const probability = 1 - bundle.$inverseProbability$;
     for (const dep of bundle.$deps$) {
       const depBundle = getBundle(dep.$name$)!;
       const prevAdjust = dep.$factor$;
@@ -188,7 +191,7 @@ export const adjustProbabilities = (
        * We can multiply this chance together with all other bundle adjustments to get the chance
        * that a dep will be loaded given all the chances of the other bundles
        */
-      const newInverseProbability = 1 - dep.$probability$ * (1 - bundle.$inverseProbability$);
+      const newInverseProbability = 1 - dep.$probability$ * probability;
 
       /** We need to undo the previous adjustment */
       const factor = newInverseProbability / prevAdjust;