Skip to content

Commit f3c6412

Browse files
wmertenssapphi-red
andcommitted
fix(vite): deadlock in rolldown-vite
Co-authored-by: sapphi-red <[email protected]>
1 parent 23b917f commit f3c6412

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

packages/qwik/src/optimizer/src/plugins/plugin.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -759,9 +759,8 @@ export function createQwikPlugin(optimizerOptions: OptimizerOptions = {}) {
759759
// unchanged imports are not missing in our internal transform cache
760760
// This can happen in the repl when the plugin is re-initialized
761761
// and possibly in other places
762-
for (const id of deps.values()) {
763-
await ctx.load({ id });
764-
}
762+
// NOTE: this should be Promise.all to avoid deadlocks
763+
await Promise.all([...deps.values()].map((id) => ctx.load({ id })));
765764

766765
ctx.addWatchFile(id);
767766

starters/e2e/qwikcity/nav.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { $ } from "bun";
21
import {
32
assertPage,
43
getScrollHeight,

0 commit comments

Comments
 (0)