Merge pull request #8395 from azat-io/feat/eslint-10

feat(eslint-plugin-qwik): support eslint v10

Author: wmertens

.changeset/late-parrots-open.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-qwik': patch
+---
+
+Support ESLint v10

packages/eslint-plugin-qwik/package.json

@@ -5,14 +5,14 @@
   "author": "Builder Team",
   "bugs": "https://github.com/QwikDev/qwik/issues",
   "dependencies": {
-    "@typescript-eslint/utils": "^8.38.0",
+    "@typescript-eslint/utils": "^8.56.1",
     "jsx-ast-utils": "^3.3.5"
   },
   "devDependencies": {
     "@builder.io/qwik": "workspace:^",
     "@builder.io/qwik-city": "workspace:^",
     "@types/estree": "1.0.8",
-    "@typescript-eslint/rule-tester": "8.38.0",
+    "@typescript-eslint/rule-tester": "8.56.1",
     "redent": "4.0.0"
   },
   "engines": {
@@ -31,7 +31,7 @@
   "license": "MIT",
   "main": "dist/index.js",
   "peerDependencies": {
-    "eslint": "^8.57.0 || ^9.0.0"
+    "eslint": "^8.57.0 || ^9.0.0 || ^10.0.0"
   },
   "repository": {
     "type": "git",

packages/eslint-plugin-qwik/qwik.unit.ts

@@ -17,9 +17,6 @@ const testConfig = {
   },
   languageOptions: {
     parserOptions: {
-      projectService: {
-        allowDefaultProject: ['*.ts*'],
-      },
       sourceType: 'module',
       ecmaFeatures: {
         jsx: true,
@@ -32,6 +29,8 @@ const testConfig = {
 } as RuleTesterConfig;
 
 const ruleTester = new RuleTester(testConfig);
+type RuleTesterRule = Parameters<RuleTester['defineRule']>[1];
+
 interface TestCase {
   name: string;
   filename: string;
@@ -40,6 +39,10 @@ interface TestCase {
 interface InvalidTestCase extends TestCase {
   errors: { messageId: string }[];
 }
+
+const isRuleName = (ruleName: string): ruleName is keyof typeof rules =>
+  Object.prototype.hasOwnProperty.call(rules, ruleName);
+
 await (async function setupEsLintRuleTesters() {
   // list './test' directory content and set up one RuleTester per directory
   let testDir = join(dirname(new URL(import.meta.url).pathname), './tests');
@@ -51,17 +54,17 @@ await (async function setupEsLintRuleTesters() {
 
   const ruleNames = await readdir(testDir);
   for (const ruleName of ruleNames) {
-    const rule = rules[ruleName];
     if (ruleName.endsWith('.json')) {
       continue;
     }
-    if (!rule) {
+    if (!isRuleName(ruleName)) {
       throw new Error(
         `Test directory has rule '${ruleName}' but related eslint rule is missing. Valid rules are: ${Object.keys(
           rules
         ).join(', ')}`
       );
     }
+    const rule = rules[ruleName] as RuleTesterRule;
     const ruleDir = join(testDir, ruleName);
     const valid: TestCase[] = [];
     const invalid: InvalidTestCase[] = [];