feat: Add Standard Schema validator to qwik-city #7518
Conversation
🦋 Changeset detectedLatest commit: 3ab676c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Interesting! If it doesn't increase build size when not in use, that sounds great. Can you run npx syncpack-fix-mismatches? And you also have to run pnpm api.update |
adrian-budau
force-pushed
the
main
branch
2 times, most recently
from
09cd3fe to
6d47bfe
Compare
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
|
I'd like @fabian-hiller to have a quick look at this before merging. |
There was a problem hiding this comment.
@adrian-budau actually, I forgot that Fabian already worked on this in #7281, with specific attention to the types of error returns, which are not handled correctly here.
Do you think you could continue that PR? Fabian has no time right now...
|
Well I started the work based on that PR so sure, but I'd like a little more context on what exactly needs to be changed about the error returns? |
|
Yes, the problem is with the dot-path error type. It would be great if you could finish it and get it merged! |
|
If I remember correctly, my PR missed testing and updating the docs. Also, there was an idea to include the types directly into the repo to avoid adding a dependency. Feel free to copy the code from my PR. |
gioboa
added
the
WAITING FOR: user
|
It would be great if we could get this or my PR merged at some pint. |
gioboa
removed
the
WAITING FOR: user
What is it?
Description
Based on #7281
Adds a
schema$validator accepting any Standard Schema confirming validation libraryChecklist
pnpm change