subscript(position:) should replace and not append a new element

dmcrodrigues · andersio · commit 1461e5f23fce · 2016-12-21T18:53:40.000+01:00
diff --git a/Sources/ReactiveArray.swift b/Sources/ReactiveArray.swift
@@ -68,7 +68,7 @@ extension ReactiveArray: MutableCollection {
             return elements[position]
         }
         set {
-            replaceSubrange(position..<position, with: CollectionOfOne(newValue))
+            replaceSubrange(position..<index(after: position), with: CollectionOfOne(newValue))
         }
     }
 
diff --git a/Tests/ReactiveArrayTests.swift b/Tests/ReactiveArrayTests.swift
@@ -92,7 +92,7 @@ class ReactiveArrayTests: XCTestCase {
         XCTAssertEqual(array[2], 3)
     }
 
-    func test_subscripting_insert_at_tail() {
+    func test_subscripting_replace_at_head() {
 
         var changeset: Changeset<Int>? = nil
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ extension ReactiveArray: MutableCollection {`
`68`	`68`	`return elements[position]`
`69`	`69`	`}`
`70`	`70`	`set {`
`71`		`- replaceSubrange(position..<position, with: CollectionOfOne(newValue))`
	`71`	`+ replaceSubrange(position..<index(after: position), with: CollectionOfOne(newValue))`
`72`	`72`	`}`
`73`	`73`	`}`
`74`	`74`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ class ReactiveArrayTests: XCTestCase {`
`92`	`92`	`XCTAssertEqual(array[2], 3)`
`93`	`93`	`}`
`94`	`94`
`95`		`- func test_subscripting_insert_at_tail() {`
	`95`	`+ func test_subscripting_replace_at_head() {`
`96`	`96`
`97`	`97`	`var changeset: Changeset<Int>? = nil`
`98`	`98`