Skip to content

Commit 7fff01f

Browse files
Merge pull request #38 from RADAR-CNS/release_0.1
Release 0.1
2 parents 8b2a9a7 + a83d444 commit 7fff01f

File tree

7 files changed

+18
-34
lines changed

7 files changed

+18
-34
lines changed

.idea/.name

Lines changed: 0 additions & 1 deletion
This file was deleted.

.idea/compiler.xml

Lines changed: 1 addition & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ plugins {
1717
//---------------------------------------------------------------------------//
1818

1919
group = 'org.radarcns'
20-
version = '0.1-alpha.3-SNAPSHOT'
20+
version = '0.1'
2121
ext.description = 'Kafka backend for processing device data.'
2222

2323
mainClassName = 'org.radarcns.RadarBackend'

src/main/java/org/radarcns/monitor/AbstractKafkaMonitor.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,11 @@ public AbstractKafkaMonitor(RadarPropertyHandler radar, Collection<String> topic
8888

8989
properties = new Properties();
9090
String deserializer = KafkaAvroDeserializer.class.getName();
91+
String monitorClientId = getClass().getName() + "-" + clientId;
9192
properties.setProperty(KEY_DESERIALIZER_CLASS_CONFIG, deserializer);
9293
properties.setProperty(VALUE_DESERIALIZER_CLASS_CONFIG, deserializer);
9394
properties.setProperty(GROUP_ID_CONFIG, groupId);
94-
properties.setProperty(CLIENT_ID_CONFIG, clientId);
95+
properties.setProperty(CLIENT_ID_CONFIG, monitorClientId);
9596
properties.setProperty(ENABLE_AUTO_COMMIT_CONFIG, "true");
9697
properties.setProperty(AUTO_COMMIT_INTERVAL_MS_CONFIG, "1001");
9798
properties.setProperty(SESSION_TIMEOUT_MS_CONFIG, "15101");
@@ -105,7 +106,7 @@ public AbstractKafkaMonitor(RadarPropertyHandler radar, Collection<String> topic
105106
this.topics = topics;
106107
this.pollTimeout = new AtomicLong(Long.MAX_VALUE);
107108
this.done = false;
108-
this.clientId = clientId;
109+
this.clientId = monitorClientId;
109110
this.groupId = groupId;
110111

111112
PersistentStateStore localStateStore;
@@ -121,7 +122,7 @@ public AbstractKafkaMonitor(RadarPropertyHandler radar, Collection<String> topic
121122
S localState = stateDefault;
122123
if (stateStore != null && stateDefault != null) {
123124
try {
124-
localState = stateStore.retrieveState(groupId, clientId, stateDefault);
125+
localState = stateStore.retrieveState(groupId, monitorClientId, stateDefault);
125126
logger.info("Using existing {} from persistence store.",
126127
stateDefault.getClass().getName());
127128
} catch (IOException ex) {

src/main/java/org/radarcns/monitor/BatteryLevelMonitor.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,10 @@ protected void evaluateRecord(ConsumerRecord<GenericRecord, GenericRecord> recor
9797
key.getSourceId(), key.getUserId(), record.value());
9898
}
9999
} else if (previousLevel <= Status.LOW.getLevel()) {
100-
updateStatus(key, Status.NORMAL);
100+
// Remove the email alert for battery monitor for normal level because
101+
// it is not crucial and to prevent spamming a user's email account.
102+
// Uncomment the line below if needed.
103+
// updateStatus(key, Status.NORMAL);
101104
logger.info("Battery of sensor {} of user {} is has returned to normal: {}",
102105
key.getSourceId(), key.getUserId(), record.value());
103106
}

src/test/java/org/radarcns/monitor/BatteryLevelMonitorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,14 @@ public void evaluateRecord() throws Exception {
8989
sendMessage(monitor, 1.0f, false);
9090
sendMessage(monitor, 0.1f, true);
9191
sendMessage(monitor, 0.1f, false);
92-
sendMessage(monitor, 0.3f, true);
92+
sendMessage(monitor, 0.3f, false);
9393
sendMessage(monitor, 0.4f, false);
9494
sendMessage(monitor, 0.01f, true);
9595
sendMessage(monitor, 0.01f, false);
9696
sendMessage(monitor, 0.1f, false);
9797
sendMessage(monitor, 0.1f, false);
9898
sendMessage(monitor, 0.01f, true);
99-
sendMessage(monitor, 1f, true);
99+
sendMessage(monitor, 1f, false);
100100
}
101101

102102
private void sendMessage(BatteryLevelMonitor monitor, float batteryLevel, boolean sentMessage)
@@ -130,4 +130,4 @@ public void retrieveState() throws Exception {
130130
Map<String, Float> values = state2.getLevels();
131131
assertThat(values, hasEntry(measurementKeyToString(key1), 0.1f));
132132
}
133-
}
133+
}

src/test/java/org/radarcns/monitor/KafkaMonitorFactoryTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ public void createBatteryMonitor() throws Exception {
5555
assertEquals(BatteryLevelMonitor.class, monitor.getClass());
5656
BatteryLevelMonitor batteryMonitor = (BatteryLevelMonitor) monitor;
5757
batteryMonitor.evaluateRecords(new ConsumerRecords<>(Collections.emptyMap()));
58-
assertTrue(new File(config.getPersistencePath(), "battery_monitors_1.yml").isFile());
58+
assertTrue(new File(config.getPersistencePath(), "battery_monitors_" +
59+
BatteryLevelMonitor.class.getName() + "-1.yml").isFile());
5960
}
6061

6162
@Test(expected = IOException.class)
@@ -79,7 +80,8 @@ public void createDisconnectMonitor() throws Exception {
7980
assertEquals(DisconnectMonitor.class, monitor.getClass());
8081
DisconnectMonitor disconnectMonitor = (DisconnectMonitor) monitor;
8182
disconnectMonitor.evaluateRecords(new ConsumerRecords<>(Collections.emptyMap()));
82-
assertTrue(new File(config.getPersistencePath(), "disconnect_monitor_1.yml").isFile());
83+
assertTrue(new File(config.getPersistencePath(), "disconnect_monitor_" +
84+
DisconnectMonitor.class.getName() + "-1.yml").isFile());
8385
}
8486

8587
@Test
@@ -148,4 +150,4 @@ public static ConfigRadar getBatteryMonitorConfig(int port, TemporaryFolder fold
148150
config.setBatteryMonitor(getBatteryMonitorConfig(port));
149151
return config;
150152
}
151-
}
153+
}

0 commit comments

Comments
 (0)