Skip to content

Commit aa09d7d

Browse files
Merge pull request #37 from RADAR-CNS/fix_battery_alert
Update BatteryLevelMonitor.java
2 parents 1d14072 + 0edc0c7 commit aa09d7d

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/main/java/org/radarcns/monitor/BatteryLevelMonitor.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,10 @@ protected void evaluateRecord(ConsumerRecord<GenericRecord, GenericRecord> recor
9797
key.getSourceId(), key.getUserId(), record.value());
9898
}
9999
} else if (previousLevel <= Status.LOW.getLevel()) {
100-
updateStatus(key, Status.NORMAL);
100+
// Remove the email alert for battery monitor for normal level because
101+
// it is not crucial and to prevent spamming a user's email account.
102+
// Uncomment the line below if needed.
103+
// updateStatus(key, Status.NORMAL);
101104
logger.info("Battery of sensor {} of user {} is has returned to normal: {}",
102105
key.getSourceId(), key.getUserId(), record.value());
103106
}

src/test/java/org/radarcns/monitor/BatteryLevelMonitorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,14 @@ public void evaluateRecord() throws Exception {
8989
sendMessage(monitor, 1.0f, false);
9090
sendMessage(monitor, 0.1f, true);
9191
sendMessage(monitor, 0.1f, false);
92-
sendMessage(monitor, 0.3f, true);
92+
sendMessage(monitor, 0.3f, false);
9393
sendMessage(monitor, 0.4f, false);
9494
sendMessage(monitor, 0.01f, true);
9595
sendMessage(monitor, 0.01f, false);
9696
sendMessage(monitor, 0.1f, false);
9797
sendMessage(monitor, 0.1f, false);
9898
sendMessage(monitor, 0.01f, true);
99-
sendMessage(monitor, 1f, true);
99+
sendMessage(monitor, 1f, false);
100100
}
101101

102102
private void sendMessage(BatteryLevelMonitor monitor, float batteryLevel, boolean sentMessage)
@@ -130,4 +130,4 @@ public void retrieveState() throws Exception {
130130
Map<String, Float> values = state2.getLevels();
131131
assertThat(values, hasEntry(measurementKeyToString(key1), 0.1f));
132132
}
133-
}
133+
}

0 commit comments

Comments
 (0)