Merge pull request #104 from RADAR-base/update-mpclient

Removed oauth-client-util dependency and replaced with ktor

Author: blootsvoets

buildSrc/src/main/kotlin/Versions.kt

@@ -1,3 +1,4 @@
+@Suppress("ConstPropertyName", "MemberVisibilityCanBePrivate")
 object Versions {
     const val project = "0.4.2-SNAPSHOT"
 
@@ -17,10 +18,9 @@ object Versions {
 
     const val okhttp = "4.11.0"
 
-    const val managementPortal = "2.0.0"
-
     const val firebaseAdmin = "9.1.0"
     const val radarSchemas = "0.8.4"
+    const val ktor = "2.3.5"
 
     const val junit = "5.9.3"
     const val wiremock = "2.27.2"

kafka-connect-fitbit-source/build.gradle.kts

@@ -4,13 +4,18 @@ dependencies {
     api(project(":kafka-connect-rest-source"))
     api("io.confluent:kafka-connect-avro-converter:${Versions.confluent}")
     api("org.radarbase:radar-schemas-commons:${Versions.radarSchemas}")
-    implementation("org.radarbase:oauth-client-util:${Versions.managementPortal}")
+    implementation("org.radarbase:radar-commons-kotlin:${Versions.radarCommons}")
 
     implementation(platform("com.fasterxml.jackson:jackson-bom:${Versions.jackson}"))
     implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml")
     implementation("com.fasterxml.jackson.datatype:jackson-datatype-jsr310")
     implementation("com.google.firebase:firebase-admin:${Versions.firebaseAdmin}")
 
+    implementation("io.ktor:ktor-client-auth:${Versions.ktor}")
+    implementation("io.ktor:ktor-client-content-negotiation:${Versions.ktor}")
+    implementation("io.ktor:ktor-serialization-jackson:${Versions.ktor}")
+    implementation("io.ktor:ktor-client-cio-jvm:${Versions.ktor}")
+
     // Included in connector runtime
     compileOnly("org.apache.kafka:connect-api:${Versions.kafka}")
     compileOnly(platform("com.fasterxml.jackson:jackson-bom:${Versions.jackson}"))

kafka-connect-fitbit-source/src/main/java/org/radarbase/connect/rest/fitbit/FitbitRestSourceConnectorConfig.java

@@ -17,11 +17,10 @@
 
 package org.radarbase.connect.rest.fitbit;
 
+import static io.ktor.http.URLUtilsKt.URLBuilder;
 import static org.apache.kafka.common.config.ConfigDef.NO_DEFAULT_VALUE;
 
 import java.lang.reflect.InvocationTargetException;
-import java.net.MalformedURLException;
-import java.net.URL;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -31,8 +30,9 @@
 import java.util.List;
 import java.util.Map;
 
+import io.ktor.http.URLParserException;
+import io.ktor.http.Url;
 import okhttp3.Headers;
-import okhttp3.HttpUrl;
 import org.apache.kafka.common.config.ConfigDef;
 import org.apache.kafka.common.config.ConfigDef.Importance;
 import org.apache.kafka.common.config.ConfigDef.NonEmptyString;
@@ -470,18 +470,18 @@ public Path getFitbitUserCredentialsPath() {
     return Paths.get(getString(FITBIT_USER_CREDENTIALS_DIR_CONFIG));
   }
 
-  public HttpUrl getFitbitUserRepositoryUrl() {
+  public Url getFitbitUserRepositoryUrl() {
     String urlString = getString(FITBIT_USER_REPOSITORY_URL_CONFIG).trim();
     if (urlString.charAt(urlString.length() - 1) != '/') {
       urlString += '/';
     }
-    HttpUrl url = HttpUrl.parse(urlString);
-    if (url == null) {
+    try {
+      return URLBuilder(urlString).build();
+    } catch (URLParserException ex) {
       throw new ConfigException(FITBIT_USER_REPOSITORY_URL_CONFIG,
           getString(FITBIT_USER_REPOSITORY_URL_CONFIG),
-          "User repository URL " + urlString + " cannot be parsed as URL.");
+          "User repository URL " + urlString + " cannot be parsed as URL: " + ex);
     }
-    return url;
   }
 
   public Headers getClientCredentials() {
@@ -524,15 +524,17 @@ public String getFitbitUserRepositoryClientSecret() {
     return getPassword(FITBIT_USER_REPOSITORY_CLIENT_SECRET_CONFIG).value();
   }
 
-  public URL getFitbitUserRepositoryTokenUrl() {
+  public Url getFitbitUserRepositoryTokenUrl() {
     String value = getString(FITBIT_USER_REPOSITORY_TOKEN_URL_CONFIG);
     if (value == null || value.isEmpty()) {
       return null;
     } else {
       try {
-        return new URL(getString(FITBIT_USER_REPOSITORY_TOKEN_URL_CONFIG));
-      } catch (MalformedURLException e) {
-        throw new ConfigException("Fitbit user repository token URL is invalid.");
+        return URLBuilder(value).build();
+      } catch (URLParserException ex) {
+        throw new ConfigException(FITBIT_USER_REPOSITORY_URL_CONFIG,
+                getString(FITBIT_USER_REPOSITORY_URL_CONFIG),
+                "Fitbit user repository token URL " + value + " cannot be parsed as URL: " + ex);
       }
     }
   }